New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 642010 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 661623
issue 662559
issue 853281



Sign in to add a comment

FontTest.DeriveFont failing on Android

Project Member Reported by thakis@chromium.org, Aug 29 2016

Issue description

https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroidASan/builds/3781/steps/gfx_unittests/logs/stdio


I   56.546s run_tests_on_device(02d15ce0f0c9d6fb)  >>ScopedMainEntryLogger
I   56.546s run_tests_on_device(02d15ce0f0c9d6fb)  Note: Google Test filter = FontTest.DeriveFont
I   56.546s run_tests_on_device(02d15ce0f0c9d6fb)  [==========] Running 1 test from 1 test case.
I   56.546s run_tests_on_device(02d15ce0f0c9d6fb)  [----------] Global test environment set-up.
I   56.546s run_tests_on_device(02d15ce0f0c9d6fb)  [----------] 1 test from FontTest
I   56.546s run_tests_on_device(02d15ce0f0c9d6fb)  [ RUN      ] FontTest.DeriveFont
I   56.546s run_tests_on_device(02d15ce0f0c9d6fb)  [ERROR:platform_font_android.cc(20)] Not implemented reached in static gfx::PlatformFont *gfx::PlatformFont::CreateFromNameAndSize(const std::string &, int)
I   56.546s run_tests_on_device(02d15ce0f0c9d6fb)  [FATAL:ref_counted.h(322)] Assert failed: ptr_ != __null. 
I   56.546s run_tests_on_device(02d15ce0f0c9d6fb)  #00 0x7a04ab7f /data/app-lib/org.chromium.native_test-2/libbase.cr.so+0x00101b7f
I   56.546s run_tests_on_device(02d15ce0f0c9d6fb)  #01 0x7b5cf125 /data/app-lib/org.chromium.native_test-2/libgfx.cr.so+0x0003e125
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #02 0x7b5cf2df /data/app-lib/org.chromium.native_test-2/libgfx.cr.so+0x0003e2df
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #03 0x7c52230d /data/app-lib/org.chromium.native_test-2/lib_gfx_unittests__library.cr.so+0x0007530d
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #04 0x7c90d549 /data/app-lib/org.chromium.native_test-2/lib_gfx_unittests__library.cr.so+0x00460549
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #05 0x7c90ec87 /data/app-lib/org.chromium.native_test-2/lib_gfx_unittests__library.cr.so+0x00461c87
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #06 0x7c90fbc5 /data/app-lib/org.chromium.native_test-2/lib_gfx_unittests__library.cr.so+0x00462bc5
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #07 0x7c91cb4f /data/app-lib/org.chromium.native_test-2/lib_gfx_unittests__library.cr.so+0x0046fb4f
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #08 0x7c91c307 /data/app-lib/org.chromium.native_test-2/lib_gfx_unittests__library.cr.so+0x0046f307
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #09 0x7c89dacb /data/app-lib/org.chromium.native_test-2/lib_gfx_unittests__library.cr.so+0x003f0acb
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #10 0x7c8d4b2b /data/app-lib/org.chromium.native_test-2/lib_gfx_unittests__library.cr.so+0x00427b2b
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #11 0x7c579045 /data/app-lib/org.chromium.native_test-2/lib_gfx_unittests__library.cr.so+0x000cc045
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #12 0x7c8688a5 /data/app-lib/org.chromium.native_test-2/lib_gfx_unittests__library.cr.so+0x003bb8a5
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #13 0x42f2dbcf /system/lib/libdvm.so+0x0001dbcf
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #14 0x42f5e125 /system/lib/libdvm.so+0x0004e125
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #15 0x42f36fe3 /system/lib/libdvm.so+0x00026fe3
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #16 0x42f3dfa3 /system/lib/libdvm.so+0x0002dfa3
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #17 0x42f3b63b /system/lib/libdvm.so+0x0002b63b
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #18 0x42f70863 /system/lib/libdvm.so+0x00060863
I   56.547s run_tests_on_device(02d15ce0f0c9d6fb)  #19 0x42f787c5 /system/lib/libdvm.so+0x000687c5
I   56.548s run_tests_on_device(02d15ce0f0c9d6fb)  #20 0x42f36fe3 /system/lib/libdvm.so+0x00026fe3
I   56.548s run_tests_on_device(02d15ce0f0c9d6fb)  #21 0x42f3dfa3 /system/lib/libdvm.so+0x0002dfa3
I   56.548s run_tests_on_device(02d15ce0f0c9d6fb)  #22 0x42f3b63b /system/lib/libdvm.so+0x0002b63b
I   56.548s run_tests_on_device(02d15ce0f0c9d6fb)  #23 0x42f7057f /system/lib/libdvm.so+0x0006057f
I   56.548s run_tests_on_device(02d15ce0f0c9d6fb)  #24 0x42f59d0d /system/lib/libdvm.so+0x00049d0d
I   56.548s run_tests_on_device(02d15ce0f0c9d6fb)  #25 0x4079f2b3 /system/lib/libandroid_runtime.so+0x0004d2b3
I   56.548s run_tests_on_device(02d15ce0f0c9d6fb)  #26 0x4079ffd9 /system/lib/libandroid_runtime.so+0x0004dfd9
I   56.548s run_tests_on_device(02d15ce0f0c9d6fb)  #27 0x400f705d /system/bin/app_process32+0x0000105d
I   56.548s run_tests_on_device(02d15ce0f0c9d6fb)  #28 0x4068934b /system/lib/libc.so+0x0000e34b
I   56.548s run_tests_on_device(02d15ce0f0c9d6fb)  #29 0x400f6d7f /system/bin/app_process32+0x00000d7f
I   56.548s run_tests_on_device(02d15ce0f0c9d6fb)  
I   56.548s run_tests_on_device(02d15ce0f0c9d6fb)  [ERROR:test_suite.cc(270)] Currently running: FontTest.DeriveFont
I   56.548s run_tests_on_device(02d15ce0f0c9d6fb)  
I   56.548s run_tests_on_device(02d15ce0f0c9d6fb)  FontTest.DeriveFontUNKNOWN
I   56.548s run_tests_on_device(02d15ce0f0c9d6fb)  OK (0 tests)
I   56.549s run_tests_on_device(073141810069b922)  Finished running tests on this device.
I   56.549s run_tests_on_device(0693cc46003be734)  Finished running tests on this device.
I   56.550s run_tests_on_device(02d15ce0f0c9d6fb)  Finished running tests on this device.
I   56.550s run_tests_on_device(06931af4003be783)  Finished running tests on this device.



gfx_unittests doesn't run on the internal asan bots as far as I can tell, so it's probably just broken everywhere (maybe everywhere under asan).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55e49e91f12516db04b13c28a9a8097d3f31f38c

commit 55e49e91f12516db04b13c28a9a8097d3f31f38c
Author: Nico Weber <thakis@chromium.org>
Date: Mon Aug 29 18:47:22 2016

ClangToTAndroidASan: Run base_unittests instead of gfx_unittests.

gfx_unittests fails a test, and the non-fyi bots seem to not run it.

BUG= 642010 
R=hans@chromium.org

Review URL: https://codereview.chromium.org/2290723002 .

Cr-Commit-Position: refs/heads/master@{#415025}

[modify] https://crrev.com/55e49e91f12516db04b13c28a9a8097d3f31f38c/testing/buildbot/chromium.fyi.json

Comment 2 by aelias@chromium.org, Aug 29 2016

Cc: siev...@chromium.org
I don't think it's likely broken everywhere, this just seems to be a non-implemented platform method: "[ERROR:platform_font_android.cc(20)] Not implemented reached in static gfx::PlatformFont *gfx::PlatformFont::CreateFromNameAndSize".  This sounds like an Aura-specific unittest that's wrongly put inside the more basic gfx package.
This is also failing on the new x64 Android bot we just set up: https://build.chromium.org/p/chromium.fyi/builders/ClangToTAndroid%20x64/builds/126/steps/gfx_unittests/logs/stdio

Who's a good person to decide what to do here? Should that test be disabled on android?
Blocking: 661623
Ideally, it should be refactored into an Aura-specific test package so that it "naturally" doesn't run on Android, but as a short-term fix it's fine to disable, yes.
Cc: thakis@chromium.org
Owner: thakis@chromium.org
Status: Assigned (was: Untriaged)
As mentioned in #5, you can go ahead and disable it.
Blocking: 662559
Cc: karandeepb@chromium.org
Regarding #2, don't really think there is anything Views specific here. The test just checks the Font class API. Think, it should be disabled explicitly on Android like the other tests in the file.
Owner: ----
Status: Available (was: Assigned)
Summary: FontTest.DeriveFont failing on Android (was: FontTest.DeriveFont failing on ClangToTAndroidASan)
Ok, test is disabled, but leaving this open for the disabled test.
Project Member

Comment 11 by sheriffbot@chromium.org, Nov 13 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Blocking: 853281
Owner: wychen@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db6633b3ee5a565b4b610a1509c99b23209cb7d5

commit db6633b3ee5a565b4b610a1509c99b23209cb7d5
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Mon Jul 23 23:38:35 2018

Use Linux fonts impl on Android

Right now Android build uses platform_font_linux if the VR
support is enabled. VR support is enabled on all Android ARM
builds (see |enable_gvr_services| and crbug/733935).

We'd like to use RenderText in compositor UI, so this CL
makes all Android builds use platform_font_linux, regardless
of whether VR is enabled.

This only affects non-ARM Android builds.

Bug:  853281 ,  642010 
Change-Id: I843c53964f1af932ad9f00b67ac690c5b43916ab
Reviewed-on: https://chromium-review.googlesource.com/1142484
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577324}
[modify] https://crrev.com/db6633b3ee5a565b4b610a1509c99b23209cb7d5/ui/gfx/BUILD.gn
[delete] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gfx/canvas_notimplemented.cc
[modify] https://crrev.com/db6633b3ee5a565b4b610a1509c99b23209cb7d5/ui/gfx/font_render_params.h
[delete] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gfx/platform_font_android.cc
[delete] https://crrev.com/51ad9a0f7c64429061c98373a6b1625f1750c359/ui/gfx/text_utils_android.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6cd98df116e9945e90dd347b2a55bdb236ccd78

commit f6cd98df116e9945e90dd347b2a55bdb236ccd78
Author: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Date: Tue Jul 24 00:12:14 2018

Enable font-related unit tests on Android

FontListTest::Fonts_GetHeight_GetBaseline is still disabled
because I couldn't find two fonts with different baseline and
different height on Android.

This depends on crrev.com/c/1142484 for non-ARM build.

Bug:  853281 ,  489354 ,  642010 
Change-Id: Iacf6124794ee53f5f9e30f59bdd958f3883c7ea2
Reviewed-on: https://chromium-review.googlesource.com/1141175
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577359}
[modify] https://crrev.com/f6cd98df116e9945e90dd347b2a55bdb236ccd78/ui/gfx/canvas_unittest.cc
[modify] https://crrev.com/f6cd98df116e9945e90dd347b2a55bdb236ccd78/ui/gfx/font_list_unittest.cc
[modify] https://crrev.com/f6cd98df116e9945e90dd347b2a55bdb236ccd78/ui/gfx/font_names_testing.cc
[modify] https://crrev.com/f6cd98df116e9945e90dd347b2a55bdb236ccd78/ui/gfx/font_unittest.cc
[modify] https://crrev.com/f6cd98df116e9945e90dd347b2a55bdb236ccd78/ui/gfx/text_utils_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment