New issue
Advanced search Search tips

Issue 642006 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 600469



Sign in to add a comment

"git cl upload" gives confusing error message if there's no change in the checkout

Project Member Reported by rdsmith@chromium.org, Aug 29 2016

Issue description

I recently fat-fingered the file I was editing s.t. the checkout I was in had no change from its upstream branch when I did "git cl upload".  The error message did give a reasonable clue as to what was going on, but could have been a fair ways more specific:

...
Presubmit checks passed.
Waiting for Emacs...
No output from ['git', 'diff', '--no-color', '--no-ext-diff', '--full-index', '--ignore-submodules', '--src-prefix=a/', '--dst-prefix=b/', '5d0334b8dba68367e4fea3bbd49993172ea0a0fc', 'HEAD']

Got exception while uploading -- saving description to /Users/rdsmith/.git_cl_description_backup

Not a high priority, but I suspect this'll be true for gerrit as well, so I thought I'd at least mention it.

 
Cc: tandrii@chromium.org
Status: Available (was: Untriaged)
Blockedon: 600469
Components: -Infra>Codereview Infra>SDK Infra>Codereview>Rietveld
I've tried the same for gerrit, and to my surprise it worked just fine: https://chromium-review.googlesource.com/c/377978/

Thus, this is Rietveld specific.
Status: WontFix (was: Available)
Closing in bulk due to Rietveld’s deprecation in favor of Gerrit. If you feel this bug should not have been closed, please feel free to re-open.

Sign in to add a comment