New issue
Advanced search Search tips

Issue 642000 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

selecting text/copy often fails i nInbox

Project Member Reported by chaok@google.com, Aug 29 2016

Issue description

Mode: force_next
Version: 55.0.2842.0
Reproduction Steps: 
1. inbox/ > Navigate to email address, text in message, etc. 
2. try to use search+s to start/stop selection by word/character
3. CtrL+c/v to copy/paste, but note how often time the copied text is from a previous copy, and not the current one


 
The Search+S selection command doesn't appear to be listed with the other
commands in the CVOX panel.
Labels: Phase3 inbox
Owner: dtseng@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 30 2016

Labels: Hotlist-Google

Comment 4 by dtseng@chromium.org, Aug 31 2016

Status: wontfix (was: Assigned)
I can't reproduce this. I'm selecting parts of the sender (e.g. JetBlue ... to me).
Try again on the next revision.

Comment 5 by chaok@google.com, Aug 31 2016

I think I figured out the issue:
TL;DR: text selection isn't supported when using object-nav, but is when using line, words, or characters.

1. if using search+left/right to nav by objects > search+s > ctrl+c will not copy
2. However, if using search+up/down, search+shift+left/right, or search+shift+ctrl+left/right > search+s to start/end selection > ctrl+c will copy.
In Classic, it is possible to perform text selection using object-nav, so I was thinking it would work in NExt as well, but looks like it's not?

Comment 6 by dtseng@chromium.org, Aug 31 2016

Owner: dmazz...@chromium.org
Status: assigned (was: WontFix)
Blink issue; reassigning to Dominic. Selecting by child node indicies is broken.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7d8eae7194d623c7e2ff753f79524da9864af7e

commit a7d8eae7194d623c7e2ff753f79524da9864af7e
Author: dtseng <dtseng@chromium.org>
Date: Wed Oct 12 17:41:58 2016

Make ChromeVox use child-index based offsets again for selection.

Make further adjustments to selection node and index:
- line breaks, when selected, appear to do nothing in Blink/AX; this is either passing offsets before or after the line break. Make the index adjument walk up to the child of the selected node and use its index in parent
- adjust nodes accordingly as well
- the clipboard text output requires the clipboard actually have the copied text. Since ChromeVox appears to get the ctrl+c first, this is often stale.

BUG= 642000 , 641728 
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2385343002
Cr-Commit-Position: refs/heads/master@{#424782}

[modify] https://crrev.com/a7d8eae7194d623c7e2ff753f79524da9864af7e/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js
[modify] https://crrev.com/a7d8eae7194d623c7e2ff753f79524da9864af7e/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js
[modify] https://crrev.com/a7d8eae7194d623c7e2ff753f79524da9864af7e/chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors_test.extjs

Comment 8 by dtseng@chromium.org, Oct 13 2016

Status: Fixed (was: Assigned)

Comment 9 by chaok@google.com, Oct 19 2016

Status: Verified (was: Fixed)
Fixed in: 56.0.2894.0

Sign in to add a comment