Issue 641996 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	jamescook@chromium.org
Closed:	Aug 2016
Cc:	benchan@chromium.org adlr@chromium.org dtapu...@chromium.org vitalyb...@chromium.org █ armansito@chromium.org █ wiley@chromium.org mustash-bugs@google.com
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
Proj-Mustash-Mash VerifyIn-55 VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Remove unused D-Bus library code in //chromeos/dbus

Project Member Reported by jamescook@chromium.org, Aug 29 2016

Issue description

There's a moderate amount of unused code in //chromeos/dbus, for example clients for audio DSP, peerd, etc.

I'm going to remove it. We can always restore it from git history if we need it.

(Motivation: mustash D-Bus work discussed in go/dbus-in-mustash and issue 629707.)

Comment 1 by dtapu...@chromium.org, Aug 29 2016

sgtm

Comment 2 by jamescook@chromium.org, Aug 29 2016

Cc: benchan@chromium.org

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/283ab821d3c138b0584c3e54de1e0755a069deab

commit 283ab821d3c138b0584c3e54de1e0755a069deab
Author: jamescook <jamescook@chromium.org>
Date: Tue Aug 30 05:22:45 2016

chromeos: Remove unused AP manager client libraries

These are unused and no longer needed. We can revive them from git history if
we need them again.

BUG= 641996 
TEST=compiles

Review-Url: https://codereview.chromium.org/2286423002
Cr-Commit-Position: refs/heads/master@{#415150}

[modify] https://crrev.com/283ab821d3c138b0584c3e54de1e0755a069deab/chromeos/chromeos.gyp
[add] https://crrev.com/283ab821d3c138b0584c3e54de1e0755a069deab/chromeos/dbus/README.md
[delete] https://crrev.com/2fb7e150d959023d9a793a74e30cea42798c56b4/chromeos/dbus/ap_manager_client.cc
[delete] https://crrev.com/2fb7e150d959023d9a793a74e30cea42798c56b4/chromeos/dbus/ap_manager_client.h
[modify] https://crrev.com/283ab821d3c138b0584c3e54de1e0755a069deab/chromeos/dbus/dbus_client_bundle.cc
[modify] https://crrev.com/283ab821d3c138b0584c3e54de1e0755a069deab/chromeos/dbus/dbus_client_bundle.h
[modify] https://crrev.com/283ab821d3c138b0584c3e54de1e0755a069deab/chromeos/dbus/dbus_thread_manager.cc
[modify] https://crrev.com/283ab821d3c138b0584c3e54de1e0755a069deab/chromeos/dbus/dbus_thread_manager.h
[delete] https://crrev.com/2fb7e150d959023d9a793a74e30cea42798c56b4/chromeos/dbus/fake_ap_manager_client.cc
[delete] https://crrev.com/2fb7e150d959023d9a793a74e30cea42798c56b4/chromeos/dbus/fake_ap_manager_client.h

Project Member

Comment 4 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ee192b5dee4fdc94fbafd8964546d8b0a7613df

commit 4ee192b5dee4fdc94fbafd8964546d8b0a7613df
Author: jamescook <jamescook@chromium.org>
Date: Tue Aug 30 06:31:07 2016

chromeos: Remove unused peerd D-Bus client libraries

These are unused and no longer needed. We can revive them from git history if
we need them again.

BUG= 641996 
TEST=compiles

Review-Url: https://codereview.chromium.org/2295433002
Cr-Commit-Position: refs/heads/master@{#415226}

[modify] https://crrev.com/4ee192b5dee4fdc94fbafd8964546d8b0a7613df/chromeos/chromeos.gyp
[modify] https://crrev.com/4ee192b5dee4fdc94fbafd8964546d8b0a7613df/chromeos/dbus/README.md
[modify] https://crrev.com/4ee192b5dee4fdc94fbafd8964546d8b0a7613df/chromeos/dbus/dbus_client_bundle.cc
[modify] https://crrev.com/4ee192b5dee4fdc94fbafd8964546d8b0a7613df/chromeos/dbus/dbus_client_bundle.h
[modify] https://crrev.com/4ee192b5dee4fdc94fbafd8964546d8b0a7613df/chromeos/dbus/dbus_thread_manager.cc
[modify] https://crrev.com/4ee192b5dee4fdc94fbafd8964546d8b0a7613df/chromeos/dbus/dbus_thread_manager.h
[delete] https://crrev.com/2820bbca0e3e9fa68df28eb4831e8d0471926aac/chromeos/dbus/fake_peer_daemon_manager_client.cc
[delete] https://crrev.com/2820bbca0e3e9fa68df28eb4831e8d0471926aac/chromeos/dbus/fake_peer_daemon_manager_client.h
[delete] https://crrev.com/2820bbca0e3e9fa68df28eb4831e8d0471926aac/chromeos/dbus/peer_daemon_manager_client.cc
[delete] https://crrev.com/2820bbca0e3e9fa68df28eb4831e8d0471926aac/chromeos/dbus/peer_daemon_manager_client.h

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64996a9695131f29dc8c4e3f6b1591f50970b7d7

commit 64996a9695131f29dc8c4e3f6b1591f50970b7d7
Author: jamescook <jamescook@chromium.org>
Date: Tue Aug 30 16:50:46 2016

chromeos: Remove unused NFC D-Bus client library

Remove the chrome D-Bus bindings code and web UI test code. We can revive
them from git history if we need them again.

BUG= 641996 
TEST=compiles
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2292703002
Cr-Commit-Position: refs/heads/master@{#415321}

[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/build/gn_migration.gypi
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/chrome/browser/browser_resources.grd
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chrome/browser/resources/chromeos/nfc_debug.css
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chrome/browser/resources/chromeos/nfc_debug.html
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chrome/browser/resources/chromeos/nfc_debug.js
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/chrome/browser/ui/webui/DEPS
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chrome/browser/ui/webui/chromeos/nfc_debug_ui.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chrome/browser/ui/webui/chromeos/nfc_debug_ui.h
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/chrome/common/url_constants.cc
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/chrome/common/url_constants.h
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/chromeos/chromeos.gyp
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/chromeos/dbus/README.md
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/chromeos/dbus/dbus_client_bundle.cc
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/chromeos/dbus/dbus_client_bundle.h
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/chromeos/dbus/dbus_thread_manager.cc
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/chromeos/dbus/dbus_thread_manager.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/fake_nfc_adapter_client.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/fake_nfc_adapter_client.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/fake_nfc_device_client.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/fake_nfc_device_client.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/fake_nfc_manager_client.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/fake_nfc_manager_client.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/fake_nfc_record_client.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/fake_nfc_record_client.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/fake_nfc_tag_client.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/fake_nfc_tag_client.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/nfc_adapter_client.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/nfc_adapter_client.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/nfc_client_helpers.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/nfc_client_helpers.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/nfc_client_unittest.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/nfc_device_client.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/nfc_device_client.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/nfc_manager_client.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/nfc_manager_client.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/nfc_property_set.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/nfc_property_set.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/nfc_record_client.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/nfc_record_client.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/nfc_tag_client.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/chromeos/dbus/nfc_tag_client.h
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/device/BUILD.gn
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/device/nfc/BUILD.gn
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/DEPS
[modify] https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7/device/nfc/nfc.gyp
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_adapter.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_adapter.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_adapter_chromeos.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_adapter_chromeos.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_adapter_factory.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_adapter_factory.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_chromeos_unittest.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_ndef_record.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_ndef_record.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_ndef_record_unittest.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_ndef_record_utils_chromeos.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_ndef_record_utils_chromeos.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_peer.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_peer.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_peer_chromeos.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_peer_chromeos.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_tag.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_tag.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_tag_chromeos.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_tag_chromeos.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_tag_technology.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_tag_technology.h
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_tag_technology_chromeos.cc
[delete] https://crrev.com/82c4e80517dfaef9422cb124df9f1add28b28029/device/nfc/nfc_tag_technology_chromeos.h

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c89638bfc9a32ab3abf43a289e0ec36f378d9efe

commit c89638bfc9a32ab3abf43a289e0ec36f378d9efe
Author: jamescook <jamescook@chromium.org>
Date: Wed Aug 31 17:58:21 2016

chromeos: Remove Introspectable D-Bus client library

This is unused and no longer needed. We can revive it from git history if
we need it again.

BUG= 641996 
TEST=compiles

Review-Url: https://codereview.chromium.org/2298603002
Cr-Commit-Position: refs/heads/master@{#415679}

[modify] https://crrev.com/c89638bfc9a32ab3abf43a289e0ec36f378d9efe/chromeos/chromeos.gyp
[modify] https://crrev.com/c89638bfc9a32ab3abf43a289e0ec36f378d9efe/chromeos/dbus/README.md
[modify] https://crrev.com/c89638bfc9a32ab3abf43a289e0ec36f378d9efe/chromeos/dbus/dbus_client_bundle.cc
[modify] https://crrev.com/c89638bfc9a32ab3abf43a289e0ec36f378d9efe/chromeos/dbus/dbus_client_bundle.h
[modify] https://crrev.com/c89638bfc9a32ab3abf43a289e0ec36f378d9efe/chromeos/dbus/dbus_thread_manager.cc
[modify] https://crrev.com/c89638bfc9a32ab3abf43a289e0ec36f378d9efe/chromeos/dbus/dbus_thread_manager.h
[delete] https://crrev.com/44f23455c950be91f4626c6c600e009cd4b1480c/chromeos/dbus/fake_introspectable_client.cc
[delete] https://crrev.com/44f23455c950be91f4626c6c600e009cd4b1480c/chromeos/dbus/fake_introspectable_client.h
[delete] https://crrev.com/44f23455c950be91f4626c6c600e009cd4b1480c/chromeos/dbus/introspectable_client.cc
[delete] https://crrev.com/44f23455c950be91f4626c6c600e009cd4b1480c/chromeos/dbus/introspectable_client.h
[delete] https://crrev.com/44f23455c950be91f4626c6c600e009cd4b1480c/chromeos/dbus/introspectable_client_unittest.cc