PG for chromium: parse for LGTM in reply text, warn that LGTM != CR+1 |
||||||||||
Issue descriptionChromium devs new to Gerrit forget that LGTM in text isn't sufficient. So, can we help them before they waste their and our (see issue 641384) time? I think this can be part of Chromium plugin for PG.
,
Aug 30 2016
,
Aug 31 2016
The log from the tryjob has: ** Presubmit ERRORS ** Missing LGTM from an OWNER for these files In addition to this feature, that should also be more clear on what is needed.
,
Sep 27 2016
,
Oct 20 2016
,
Jan 13 2017
,
May 16 2017
Maybe a plugin? It could watch reply event, and if it has LGTM as a first word, will show a notification and auto-set the score.
,
May 16 2017
,
May 16 2017
,
May 19 2017
,
May 23 2017
Filed child tracking bug on PG side: https://bugs.chromium.org/p/gerrit/issues/detail?id=6280
,
May 31 2017
,
Jun 13 2017
Plugin CL here: https://chromium-review.googlesource.com/c/532173
,
Jun 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/chromium-behavior/+/4af7767e3e2959c53cd2994e2042047e542e9673 commit 4af7767e3e2959c53cd2994e2042047e542e9673 Author: Aaron Gable <agable@chromium.org> Date: Tue Jun 13 23:12:18 2017 First commit of chromium LGTM behavior plugin Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=641991 [add] https://crrev.com/4af7767e3e2959c53cd2994e2042047e542e9673/src/main/resources/static/chromium-behavior.html [add] https://crrev.com/4af7767e3e2959c53cd2994e2042047e542e9673/codereview.settings [add] https://crrev.com/4af7767e3e2959c53cd2994e2042047e542e9673/README.md [add] https://crrev.com/4af7767e3e2959c53cd2994e2042047e542e9673/BUILD [add] https://crrev.com/4af7767e3e2959c53cd2994e2042047e542e9673/LICENSE
,
Jun 15 2017
Code has been imported and will go out with the next deploy. Marking fixed, can verify when deployed. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by tandrii@chromium.org
, Aug 29 2016