Importing //tools in //build causes failures in some downstream projects |
||||
Issue descriptionLanding https://codereview.chromium.org/2272713004/ allowed us to more easily generate used resource whitelists on android but this causes problems to some downstream projects where //build is included but //tools is not (e.g. v8: https://codereview.chromium.org/2286213002/) Resource whitelisting should work on android while not introducing any side effects for other projects.
,
Aug 29 2016
A possible (non)solution would be to include the two components outside of build (grit and closure_compiler) as deps in v8. It'd make gn happy, but also download two unused repos on all v8 bots and dev machines. I'd prefer making imports to things outside of //build conditional, being off by default in subprojects like v8, skia, pdfium, etc.
,
Aug 29 2016
Adding a check to see if enable_resource_whitelist_generation is set instead of importing from //tools is another possible solution: https://codereview.chromium.org/2288273002/
,
Aug 29 2016
,
Aug 29 2016
Re 3: Even better!
,
Aug 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47f910a6e58b633bd902adce24feecf26901f84d commit 47f910a6e58b633bd902adce24feecf26901f84d Author: estevenson <estevenson@chromium.org> Date: Tue Aug 30 04:46:07 2016 Fix imports in gcc_toolchain.gni to not rely on //tools. Importing //tools into gcc_toolchain.gni breaks certain downstream projects that include //build but not //tools. This CL changes gcc_toolchain.gni to only rely on files within //build. BUG= 641981 Review-Url: https://codereview.chromium.org/2288273002 Cr-Commit-Position: refs/heads/master@{#415113} [modify] https://crrev.com/47f910a6e58b633bd902adce24feecf26901f84d/build/config/android/config.gni [modify] https://crrev.com/47f910a6e58b633bd902adce24feecf26901f84d/build/toolchain/gcc_toolchain.gni [modify] https://crrev.com/47f910a6e58b633bd902adce24feecf26901f84d/chrome/chrome_repack_locales.gni [modify] https://crrev.com/47f910a6e58b633bd902adce24feecf26901f84d/tools/grit/grit_rule.gni
,
Aug 30 2016
,
Aug 30 2016
Thanks for fixing! |
||||
►
Sign in to add a comment |
||||
Comment 1 by estevenson@chromium.org
, Aug 29 2016