New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641955 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.6%-13.4% improvement in webrtc_perf_tests at 13917:13921

Project Member Reported by ivoc@chromium.org, Aug 29 2016

Issue description

See graphs below.
 

Comment 1 by ivoc@chromium.org, Aug 29 2016

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=641955

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggf6LqwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_qqEtQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_va7vgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvovwpQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggevDqwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggevDqwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvufvqAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_tjEvQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvs37_AgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvurevQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_tuHsQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvovLsgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvq6SogoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_oSvoAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_sq1qAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvo__uQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgwejluwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvpyrvQkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_oK6tQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICggaumsAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgwdSdtwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_pCOrgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvqe9qwkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_sTCqAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvou6rQoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_pymuwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_t6V9QgM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_oT-tgoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_vbxtgkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvovVowoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvuqqrAsM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_o6goAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvovstAoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvrO_twkM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg_pDpvwoM,agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgvouhvAoM


Bot(s) for this bug's original alert(s):

webrtc-android-tests-nexus5
webrtc-linux-large-tests
webrtc-mac-large-tests

Comment 2 by ivoc@chromium.org, Aug 29 2016

Cc: maxmorin@chromium.org
Labels: -M-52 M-55
Owner: peah@chromium.org
Hi Per, could you have a quick look if these stat improvements are expected as a result from this CL: https://codereview.webrtc.org/2268163004 
Thanks!

Comment 3 by ivoc@chromium.org, Aug 29 2016

Cc: ivoc@chromium.org
There are two possible reasons for speedup. First, eliminating the int conversion itself is good. Second, this code is most likely vectorised now, it might not have been before.

Comment 5 by peah@chromium.org, Aug 31 2016

Wow, that is a much bigger improvement than I would have anticipated. I think this is fine though, and it is an improvement that could have been related to that CL, so I'll close the issue.

Comment 6 by peah@chromium.org, Aug 31 2016

Status: WontFix (was: Assigned)

Sign in to add a comment