Issue metadata
Sign in to add a comment
|
23.2%-100% improvement in webrtc_perf_tests at 13937:13937 |
||||||||||||||||||||
Issue descriptionSee graphs below.
,
Aug 29 2016
Hi Per, It looks like your CL where you deactivated the intelligibility enhancer by default (https://codereview.webrtc.org/2272423003) also causes the DefaultApmDesktopAndIntelligibilityEnhancer stats to fall to zero. Could you have a look if this is desired behavior, or if we should look for a way to keep those stats active, even when the intelligibility enhancer is off by default? Thanks.
,
Aug 31 2016
Thanks for the headsup! I will deactivate those tests until the IE is active again by default. The regressions in this issue are expected, so I'll close this as wontfix.
,
Aug 31 2016
,
Sep 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/external/webrtc.git/+/d29e3ea4b2f4d7901ddcda5f229c30f4daf731f6 commit d29e3ea4b2f4d7901ddcda5f229c30f4daf731f6 Author: peah <peah@webrtc.org> Date: Wed Sep 14 04:42:39 2016 Added build flag around the Intelligibility enhancer performance test code BUG= chromium:641931 Review-Url: https://codereview.webrtc.org/2294093004 Cr-Commit-Position: refs/heads/master@{#14202} [modify] https://crrev.com/d29e3ea4b2f4d7901ddcda5f229c30f4daf731f6/webrtc/BUILD.gn [modify] https://crrev.com/d29e3ea4b2f4d7901ddcda5f229c30f4daf731f6/webrtc/modules/audio_processing/audio_processing_performance_unittest.cc [modify] https://crrev.com/d29e3ea4b2f4d7901ddcda5f229c30f4daf731f6/webrtc/webrtc_tests.gypi |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ivoc@chromium.org
, Aug 29 2016