Regression: Unwanted space is seen on back navigation in md-settings |
||||||||
Issue descriptionVersion: 55.0.2843.0 dev OS: Ubuntu 14.04,windows What steps will reproduce the problem? (1)Launch chrome and go to chrome://md-settings/siteSettings >> Go to cookies section >> Add more exceptions so that scrollbar is seen (2) Now scroll to bottom of page >> Click on back navigation and observe Expected: No such extra space should be seen on back navigation. Actual: Instead extra space is seen in site settings page on back navigation. This is a regression issue broken in M54.
,
Aug 29 2016
Good Build: 54.0.2839.0 dev Bad Build: 54.0.2840.0 dev CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/4656783ba4a9e4b76eae6f2ad0392c45bca9df69..eb9681e84dffcad3042407c86aa4768e6f321cee Suspecting https://codereview.chromium.org/2230123002 from changelog @michaelpg: Please confirm the issue.
,
Sep 1 2016
This reproduces after reverting my patch, although it's a little harder to trigger (seems to require going back and forth twice). Dave... how do we make overscroll less breaky?
,
Sep 6 2016
dschuyler@ gentle ping.. this issue is marked as RBS, could you please check the issue and update.
,
Sep 7 2016
,
Sep 7 2016
CL was reviewed, just need to rebase and test now that
,
Sep 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6b0168feb6dca854ac181a1daf43b1d27c9d4e8 commit e6b0168feb6dca854ac181a1daf43b1d27c9d4e8 Author: michaelpg <michaelpg@chromium.org> Date: Wed Sep 07 04:25:32 2016 MD Settings: Reset scroll when sliding subpages When navigating from one subpage to another in the same section (sliding settings-animated-pages), we should scroll to top so different-height cards don't result in glitches or empty space. BUG= 641930 R=dschuyler@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2305533002 Cr-Commit-Position: refs/heads/master@{#416844} [modify] https://crrev.com/e6b0168feb6dca854ac181a1daf43b1d27c9d4e8/chrome/browser/resources/settings/settings_page/main_page_behavior.js
,
Sep 12 2016
Verified the fix on the latest M-55(55.0.2858.0) on Windows-10, Mac OS 10.11.6 and Linux Ubuntu 14.04. This is working as intended. michaelpg@ch@: Could you please get the fix merged to M-54 as well. Thank you!
,
Sep 13 2016
Removing Release-Block-Stable since MD Settings has not launched yet.
,
Sep 20 2016
#8: No, there's no reason to merge this as the page hasn't launched. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kavvaru@chromium.org
, Aug 29 2016Status: Untriaged (was: Unconfirmed)