New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641899 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[MD dropdown] Regression:Text does not appear properly in chrome://md-settings/fonts

Reported by adha...@etouch.net, Aug 29 2016

Issue description

Version:55.0.2842.0 (Official Build) d49de86acc4a6b7382a2fff2a7d9939673df3b76-refs/heads/master@{#414942}
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4)

What steps will reproduce the problem?
(1)Launch chrome and navigate to chrome://md-settings/fonts.
(2)Click on drop down list in front of "Encoding"
(3)Select Chinese Traditional(Big5) or Chinese Simplified(GBK)option.(Kindly refer the video)
(4)Observe.

Actual:Text is not seen properly i.e seen chopped after step 3.

Expected:Text should be seen properly after step 3.

This is a Regression issue broken in M-54,below is the Narrow bisect info:
https://chromium.googlesource.com/chromium/src/+log/e64374883a7e2d4bfc5d43d2e92ec98d9a9c5f16..af78369e67aadb067975e87f9aab642e80e0c172?pretty=fuller&n=100

Suspecting:r412396?

Good build:54.0.2830.0
Bad build:54.0.2831.0

Kindly help to re-assign if your change is not the cause for this issue.
 
Actual result.mp4
466 KB View Download
Expected result.mp4
358 KB View Download

Comment 1 by adha...@etouch.net, Aug 29 2016

Labels: -54 M-54
Cc: tsergeant@chromium.org dpa...@chromium.org
Owner: dbeam@chromium.org
Another custom properties regression, this one is quite minor: it seems like the text aligns right when it is selected, but then switches back to left alignment when focus changes.

Comment 3 by dbeam@chromium.org, Aug 30 2016

Owner: dschuyler@chromium.org
Labels: Proj-MaterialDesign-WebUI
Summary: [MD dropdown] Regression:Text does not appear properly in chrome://md-settings/fonts (was: Regression:Text does not appear properly in chrome://md-settings/fonts)
This bug is obsolete, since the Encoding UI has been removed as of https://codereview.chromium.org/2254273003.

@dschuyler: Is there anything we can remove from the C++ side related to encodings? See https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/appearance_page/fonts_browser_proxy.js?q=encoding+file:%5Esrc/chrome/browser/resources/settings/&sq=package:chromium&l=20&dr=C.
Owner: dpa...@chromium.org
Hi Demetrios, I think this will be handled/fixed by your work on the action (pop-up) menu. If not, feel free to hand it back to me.
Owner: dschuyler@chromium.org
Hi Dave. See my comment#6 and question. This is already obsolete (there is no encoding dropdown list anymore). Just wondering if there is anything more we can delete. Otherwise let's close this issue.
Status: Started (was: Assigned)
Ah, I see, thanks! I've put up a CL with a few minor touch-ups.
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08b1d375eb4870c3e0f2bf4654f9b3faf29e6254

commit 08b1d375eb4870c3e0f2bf4654f9b3faf29e6254
Author: dschuyler <dschuyler@chromium.org>
Date: Sat Oct 08 02:45:44 2016

[MD settings] touch-up removal of encoding settings

This CL changes some comments and closure compiler values to touch-up
after the removal of the encodings menu.

BUG= 641899 ,  597488 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2398233004
Cr-Commit-Position: refs/heads/master@{#424050}

[modify] https://crrev.com/08b1d375eb4870c3e0f2bf4654f9b3faf29e6254/chrome/browser/resources/settings/appearance_page/fonts_browser_proxy.js
[modify] https://crrev.com/08b1d375eb4870c3e0f2bf4654f9b3faf29e6254/chrome/browser/ui/webui/settings/font_handler.cc
[modify] https://crrev.com/08b1d375eb4870c3e0f2bf4654f9b3faf29e6254/chrome/browser/ui/webui/settings/font_handler.h

Status: Fixed (was: Started)

Sign in to add a comment