Custom properties should not be allowed as descriptors
Reported by
r...@opera.com,
Aug 29 2016
|
|||
Issue descriptionCustom properties like "--my-var: 10" is kept as font-face descriptors and are observable through CSSOM.
,
Sep 13 2016
,
Nov 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bfc0527d0b204f20d238d8e998f9485b637dd4a3 commit bfc0527d0b204f20d238d8e998f9485b637dd4a3 Author: timloh <timloh@chromium.org> Date: Tue Nov 08 02:34:20 2016 Disallow CSS custom properties as descriptors CSS custom properties are properties so should be not allowed where we only otherwise allow descriptors. This patch makes the parser reject custom properties in at rules (excluding in keyframe blocks, which take properties instead of descriptors). BUG= 641873 Review-Url: https://codereview.chromium.org/2478623003 Cr-Commit-Position: refs/heads/master@{#430484} [add] https://crrev.com/bfc0527d0b204f20d238d8e998f9485b637dd4a3/third_party/WebKit/LayoutTests/fast/css/variables/variables-in-at-rules-expected.txt [add] https://crrev.com/bfc0527d0b204f20d238d8e998f9485b637dd4a3/third_party/WebKit/LayoutTests/fast/css/variables/variables-in-at-rules.html [modify] https://crrev.com/bfc0527d0b204f20d238d8e998f9485b637dd4a3/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
,
Nov 8 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dstockwell@chromium.org
, Aug 30 2016