Issue metadata
Sign in to add a comment
|
Regression: Accessibility overlay is seen changed and misplaced at OOBE screen |
||||||||||||||||||||||
Issue descriptionVersion: 55.0.2842.0/8751.0.0_Dev Paine, Spring OS: Chrome What steps will reproduce the problem? (1)Recover OS via USB>> go to accessibility settings on bottom left of the OOBE screen>> and observe the overlay Expected: The UI of the overlay should not be changed and misplaced (It should be as shown in Actual screenshot) Actual: Instead the UI of the overlay has been changed and misplaced (Refer screenshot) This is a Regression issue as issue is not seen in M54: 54.0.2806.0/8639.0.0 dev-channel Spring Issue is not applicable to Linux and Windows
,
Nov 8 2016
alemate@ did something change from M54 to M55 here? Regardless, this should be fixed by new OOBE in M56, right?
,
Nov 15 2016
Any update on this? This is marked as a 55 stable blocker, and we are nearing 55 stable.
,
Nov 17 2016
,
Nov 17 2016
https://codereview.chromium.org/2513583002/ is on review.
,
Nov 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a713652fa5868b8d3d5dae03856f8e785b5fcff7 commit a713652fa5868b8d3d5dae03856f8e785b5fcff7 Author: alemate <alemate@chromium.org> Date: Fri Nov 18 03:26:20 2016 ChromeOS OOBE: use old-style bubble for OOBE Accessibility popup. "Classic" ChromeOS OOBE requires old-style bubble to display Accessibility popup. This change adds special flag to revert bubble style to old design for "Classic" OOBE. BUG= 641866 Review-Url: https://codereview.chromium.org/2513583002 Cr-Commit-Position: refs/heads/master@{#433060} [modify] https://crrev.com/a713652fa5868b8d3d5dae03856f8e785b5fcff7/ui/login/bubble.css [modify] https://crrev.com/a713652fa5868b8d3d5dae03856f8e785b5fcff7/ui/login/bubble.js
,
Nov 18 2016
,
Nov 19 2016
Your change meets the bar and is auto-approved for M55 (branch: 2883)
,
Nov 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65137bf12da85a750f34be8e9ebfc21ab78ec7f4 commit 65137bf12da85a750f34be8e9ebfc21ab78ec7f4 Author: Alexander Alekseev <alemate@chromium.org> Date: Sat Nov 19 08:27:20 2016 ChromeOS OOBE: use old-style bubble for OOBE Accessibility popup. "Classic" ChromeOS OOBE requires old-style bubble to display Accessibility popup. This change adds special flag to revert bubble style to old design for "Classic" OOBE. BUG= 641866 Review-Url: https://codereview.chromium.org/2513583002 Cr-Commit-Position: refs/heads/master@{#433060} (cherry picked from commit a713652fa5868b8d3d5dae03856f8e785b5fcff7) Review URL: https://codereview.chromium.org/2514853003 . Cr-Commit-Position: refs/branch-heads/2883@{#622} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/65137bf12da85a750f34be8e9ebfc21ab78ec7f4/ui/login/bubble.css [modify] https://crrev.com/65137bf12da85a750f34be8e9ebfc21ab78ec7f4/ui/login/bubble.js
,
Nov 19 2016
,
Nov 20 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Nov 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8e59ddb87e3326da268c2f1737141c43bae43d5 commit e8e59ddb87e3326da268c2f1737141c43bae43d5 Author: Alexander Alekseev <alemate@chromium.org> Date: Mon Nov 21 10:09:02 2016 ChromeOS OOBE: use old-style bubble for OOBE Accessibility popup. "Classic" ChromeOS OOBE requires old-style bubble to display Accessibility popup. This change adds special flag to revert bubble style to old design for "Classic" OOBE. BUG= 641866 Review-Url: https://codereview.chromium.org/2513583002 Cr-Commit-Position: refs/heads/master@{#433060} (cherry picked from commit a713652fa5868b8d3d5dae03856f8e785b5fcff7) Review URL: https://codereview.chromium.org/2521543002 . Cr-Commit-Position: refs/branch-heads/2924@{#23} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/e8e59ddb87e3326da268c2f1737141c43bae43d5/ui/login/bubble.css [modify] https://crrev.com/e8e59ddb87e3326da268c2f1737141c43bae43d5/ui/login/bubble.js
,
Dec 7 2016
I think it's a regression (if it is) from M53 to M54. R53-8530.96.0 keeps the bubble above "Accessibility" link, but R54-8743.87.0 - below the link. This is because "connect" dialog became shorter: 490px vs 453px. I don't think it is important since we had it in M54. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by durga.behera@chromium.org
, Aug 29 2016