Frame selection in the console tab has extension ID instead of name
Reported by
elir...@gmail.com,
Aug 29 2016
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Steps to reproduce the problem: 1. Open dev tools 2. Navigate to the console tab 3. Try selecting a different frame/target There are only extension IDs and no names which makes it harder to choose the desired frame What is the expected behavior? It used to show the extension names instead of ID which is way easier to work with. What went wrong? The selection shows only extension IDs without the name which makes it harder to choose the desired frame Did this work before? Yes Around a month ago Chrome version: 52.0.2743.116 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 22.0 r0
,
Aug 29 2016
Started: https://codereview.chromium.org/2297443002
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d007925ee3e983d83a6a28fea59c9553f16a73a commit 6d007925ee3e983d83a6a28fea59c9553f16a73a Author: lushnikov <lushnikov@chromium.org> Date: Wed Aug 31 02:59:44 2016 DevTools: show extension name in console execution context selector. BUG= 641851 R=dgozman Review-Url: https://codereview.chromium.org/2297443002 Cr-Commit-Position: refs/heads/master@{#415548} [modify] https://crrev.com/6d007925ee3e983d83a6a28fea59c9553f16a73a/chrome/browser/devtools/devtools_sanity_browsertest.cc [modify] https://crrev.com/6d007925ee3e983d83a6a28fea59c9553f16a73a/third_party/WebKit/LayoutTests/http/tests/inspector/console-test.js [modify] https://crrev.com/6d007925ee3e983d83a6a28fea59c9553f16a73a/third_party/WebKit/Source/devtools/front_end/Tests.js [modify] https://crrev.com/6d007925ee3e983d83a6a28fea59c9553f16a73a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js [modify] https://crrev.com/6d007925ee3e983d83a6a28fea59c9553f16a73a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
,
Oct 4 2016
,
Oct 4 2016
Looks like this has to be merged to 54
,
Oct 4 2016
[Automated comment] Less than 2 weeks to go before stable on M54, manual review required.
,
Oct 6 2016
Do we need this for M54? We're less than a week from stable cut, and I'm generally only taking security/crash fixes at this point (with some exceptions). If there's a strong reason it needs to be on 54 we can merge it, but I'd prefer to wait to M55.
,
Oct 7 2016
ok sure, we can wait for 55. Thank you!
,
Oct 7 2016
Great, thanks! |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by lushnikov@chromium.org
, Aug 29 2016Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)