New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641841 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Security

Blocked on:
issue 643804



Sign in to add a comment

Stack-buffer-overflow in Hunspell::suggest

Project Member Reported by ClusterFuzz, Aug 29 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6316104744173568

Fuzzer: libfuzzer_hunspell_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Stack-buffer-overflow WRITE {*}
Crash Address: 0x7ff9a9df6a70
Crash State:
  Hunspell::suggest
  Hunspell::suggest
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=414871:414881

Minimized Testcase (0.10 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96uGY-R2IlAazOz453Gq1xM2qLy-l_U3ax8ZmMlMBoz1VFSRNCycdvgDfgEm65YauMn219bq0DaiUlTC4ETWHBkx8qZd87qqH2_pUnLDKczMlxpDzzguUNjTo5F39VX4oYxIJ652sshfdTz0WB8KkQcnbLDyA?testcase_id=6316104744173568

Issue manually filed by: inferno

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Owner: groby@chromium.org
Status: Assigned (was: Untriaged)
Just a fyi, this is after your changes went in - https://chromium.googlesource.com/chromium/src/+/5d6411a1a10652b1a3d9ced8d744f7e427918805.
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 29 2016

Labels: M-54
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 29 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 29 2016

Labels: Pri-1
Components: UI>Browser>Spellcheck
Project Member

Comment 6 by sheriffbot@chromium.org, Sep 1 2016

Labels: -Security_Impact-Head Security_Impact-Beta

Comment 7 by groby@chromium.org, Sep 2 2016

Blockedon: 643804
Labels: -Pri-1 -ReleaseBlock-Beta Pri-2
Additional context:

Yes, hunspell has issues. That's the reason we isolated it into the render process in the first place - untrusted third-party code.

Here's why I don't think this is P1:

1) The exploit for this is extremely difficult to trigger. It requires
  * The user typing a specific word into an editable field.
  * The user right-clicking onto the misspelling to actually fix it.
  * The exploit also depends on the actual dictionary. 
2) It is contained in the renderer.
3) hunspell has significantly changed, upgrading most string handling to std::string. We should roll new DEPS, instead of fixing this bug.

I'll leave this open for now, since I hope we'll get to a new DEPS roll soon, which might well close many of these bugs. Filed bug #643804 for that.

Removing release blocker status (and downgrading priority), because I don't think it's severe enough to justify that.




Project Member

Comment 8 by sheriffbot@chromium.org, Sep 9 2016

Labels: ReleaseBlock-Stable

Comment 9 by groby@chromium.org, Sep 15 2016

Labels: -ReleaseBlock-Stable
Uh, no. Not RBS. See c#7

Also, waiting for update to newest hunspell.
Project Member

Comment 10 by sheriffbot@chromium.org, Sep 15 2016

Labels: ReleaseBlock-Stable
Labels: -ReleaseBlock-Stable
Project Member

Comment 12 by sheriffbot@chromium.org, Sep 29 2016

groby: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Sep 29 2016

Labels: ReleaseBlock-Stable
Labels: -Security_Severity-High -ReleaseBlock-Stable Security_Severity-Medium
Removing RBS and downgrading priority.
Project Member

Comment 15 by sheriffbot@chromium.org, Oct 4 2016

Labels: ReleaseBlock-Stable
Labels: -Security_Impact-Beta -ReleaseBlock-Stable
Removing RBS again, and "Security_Impact=Beta" label, which should prevent Sheriffbot from adding the blocker label back.
Labels: -Security_Severity-Medium Security_Impact-Beta Security_Severity-Low
Dropping to low and adding beta.  We'll see what sheriffbot thinks ...
Yeah. About that "DEPS roll soon" - upstream is a bit discombobulated right now, and failing plenty of our unit tests. So, delaying this further.

Project Member

Comment 19 by sheriffbot@chromium.org, Oct 13 2016

Labels: -Security_Impact-Beta Security_Impact-Stable
Labels: -M-54 M-56
Project Member

Comment 21 by ClusterFuzz, Dec 14 2016

ClusterFuzz has detected this issue as fixed in range 438154:438196.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6316104744173568

Fuzzer: libfuzzer_hunspell_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Stack-buffer-overflow WRITE {*}
Crash Address: 0x7ff9a9df6a70
Crash State:
  Hunspell::suggest
  Hunspell::suggest
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=414871:414881
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_asan&range=438154:438196

Minimized Testcase (0.10 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96uGY-R2IlAazOz453Gq1xM2qLy-l_U3ax8ZmMlMBoz1VFSRNCycdvgDfgEm65YauMn219bq0DaiUlTC4ETWHBkx8qZd87qqH2_pUnLDKczMlxpDzzguUNjTo5F39VX4oYxIJ652sshfdTz0WB8KkQcnbLDyA?testcase_id=6316104744173568

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 22 by ClusterFuzz, Dec 14 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6316104744173568 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 23 by sheriffbot@chromium.org, Dec 15 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: Release-0-M56
Project Member

Comment 25 by sheriffbot@chromium.org, Mar 23 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck

Sign in to add a comment