The histogram Net.QuicSession.ConnectionCloseErrorCodeClient shows a big spike in packet write errors and is correlated with the recent code to set the DF bit. We should use a field trial to quantify the impact.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bedd5745be79b6a15b1d5f6212411d5d7484b11e commit bedd5745be79b6a15b1d5f6212411d5d7484b11e Author: rch <rch@chromium.org> Date: Tue Aug 30 19:11:48 2016 Use a field trial to decide if QUIC should attempt to prevent packet fragmentation. BUG= 641791 Review-Url: https://codereview.chromium.org/2283393002 Cr-Commit-Position: refs/heads/master@{#415385} [modify] https://crrev.com/bedd5745be79b6a15b1d5f6212411d5d7484b11e/components/network_session_configurator/network_session_configurator.cc [modify] https://crrev.com/bedd5745be79b6a15b1d5f6212411d5d7484b11e/components/network_session_configurator/network_session_configurator_unittest.cc [modify] https://crrev.com/bedd5745be79b6a15b1d5f6212411d5d7484b11e/net/http/http_network_session.cc [modify] https://crrev.com/bedd5745be79b6a15b1d5f6212411d5d7484b11e/net/http/http_network_session.h [modify] https://crrev.com/bedd5745be79b6a15b1d5f6212411d5d7484b11e/net/quic/chromium/quic_stream_factory.cc [modify] https://crrev.com/bedd5745be79b6a15b1d5f6212411d5d7484b11e/net/quic/chromium/quic_stream_factory.h [modify] https://crrev.com/bedd5745be79b6a15b1d5f6212411d5d7484b11e/net/quic/chromium/quic_stream_factory_test.cc
Your change meets the bar and is auto-approved for M54 (branch: 2840)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d1e9b9f752f5d938417c5acc0e18e4ad0ec9a2a commit 8d1e9b9f752f5d938417c5acc0e18e4ad0ec9a2a Author: Ryan Hamilton <rch@chromium.org> Date: Thu Sep 01 16:37:56 2016 [m54 merge] Use a field trial to decide if QUIC should attempt to prevent packet fragmentation. BUG= 641791 Review-Url: https://codereview.chromium.org/2283393002 Cr-Commit-Position: refs/heads/master@{#415385} (cherry picked from commit bedd5745be79b6a15b1d5f6212411d5d7484b11e) Review URL: https://codereview.chromium.org/2296763007 . Cr-Commit-Position: refs/branch-heads/2840@{#98} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/8d1e9b9f752f5d938417c5acc0e18e4ad0ec9a2a/components/network_session_configurator/network_session_configurator.cc [modify] https://crrev.com/8d1e9b9f752f5d938417c5acc0e18e4ad0ec9a2a/components/network_session_configurator/network_session_configurator_unittest.cc [modify] https://crrev.com/8d1e9b9f752f5d938417c5acc0e18e4ad0ec9a2a/net/http/http_network_session.cc [modify] https://crrev.com/8d1e9b9f752f5d938417c5acc0e18e4ad0ec9a2a/net/http/http_network_session.h [modify] https://crrev.com/8d1e9b9f752f5d938417c5acc0e18e4ad0ec9a2a/net/quic/chromium/quic_stream_factory.cc [modify] https://crrev.com/8d1e9b9f752f5d938417c5acc0e18e4ad0ec9a2a/net/quic/chromium/quic_stream_factory.h [modify] https://crrev.com/8d1e9b9f752f5d938417c5acc0e18e4ad0ec9a2a/net/quic/chromium/quic_stream_factory_test.cc
Comment 1 by bugdroid1@chromium.org
, Aug 30 2016