Flexbox quirky/broken on Dev
Reported by
meatwadd...@gmail.com,
Aug 28 2016
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2842.0 Safari/537.36 Example URL: http://frowcss.com/ Steps to reproduce the problem: 1. Visit http://frowcss.com/ 2. Scroll down a little to the examples 3. The flexbox content is positioned outside of it's containing div What is the expected behavior? There should be a simple two column layout on the page, visit the same URL in the current, stable version of Chrome or any other browser for comparison. What went wrong? Chrome seems to be extremely quirky right now with flexbox, as toggling some of the rules in the dev inspector causes the content to snap back into their expected place. Does it occur on multiple sites: N/A Is it a problem with a plugin? No Did this work before? Yes 52.0.2743.116 Does this work in other browsers? Yes Chrome version: 55.0.2842.0 Channel: canary OS Version: OS X 10.11.6 Flash Version: Sorry if this is a duplicate, tried to see if someone logged something already but wasn't sure what to search for.
,
Aug 29 2016
,
Aug 29 2016
,
Aug 29 2016
You are probably looking for a change made after 408451 (known good), but no later than 408456 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/0ba8786cfbc72edbdb38e37bcc9b29d0ac0696ee..955a53c8bc7f04b4830acabf7291c603314e0a53 So, almost certainly https://chromium.googlesource.com/chromium/src/+/955a53c8bc7f04b4830acabf7291c603314e0a53 Will look more to see if this is a duplicate of bug 634672
,
Aug 29 2016
,
Aug 30 2016
==================================== Good Build: 54.0.2800.0 Base Position: 406166 Bad Build: 54.0.2824.0 Base Position: 410520 ===================================== Able to repro this issue on Windows 7, MAC (10.11.6) & Ubuntu Trusty (14.04) for the Google Chrome Canary Version - 55.0.2843.0 This is a regression issue broken in M54, below mentioned is the bisect info: CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/c0cf770bd57739b34ae035f0fb75bbb9e81f4026..bb0fcd524db62e400ae4d18accbb6931effbbcc6 Suspecting Commit: 955a53c8bc7f04b4830acabf7291c603314e0a53 Review URL: https://codereview.chromium.org/2191683003 @cbiesinger: Could you please look into the issue, and if it has nothing to do with your changes and if possible please do assign it to the concerned owner. Thank you.
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/112c0577ad48a4cfe0b6046364f67bd97dc14eff commit 112c0577ad48a4cfe0b6046364f67bd97dc14eff Author: cbiesinger <cbiesinger@chromium.org> Date: Thu Sep 01 01:54:43 2016 Revert of [css-flexbox] align-content should apply even when there's just a single line (patchset #2 id:20001 of https://codereview.chromium.org/2191683003/ ) Reason for revert: Caused multiple regressions ( bug 634672 , bug 641789 ) and I'd like more time to investigate them before shipping this to users. Original issue's description: > [css-flexbox] align-content should apply even when there's just a single line > > In Jan 2015 the spec changed in > https://drafts.csswg.org/css-flexbox/#change-201409-align-content-wrapping > > Change our code accordingly. This effectively reverts commit > 764735dc12285a09a32b7d5ad3a8d6f178b0ab83 > > BUG=599828 > R=eae@chromium.org,dgrogan@chromium.org > > Committed: https://crrev.com/955a53c8bc7f04b4830acabf7291c603314e0a53 > Cr-Commit-Position: refs/heads/master@{#408456} TBR=dgrogan@chromium.org,eae@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=599828, 634672 , 641789 Review-Url: https://codereview.chromium.org/2289793003 Cr-Commit-Position: refs/heads/master@{#415844} [modify] https://crrev.com/112c0577ad48a4cfe0b6046364f67bd97dc14eff/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/112c0577ad48a4cfe0b6046364f67bd97dc14eff/third_party/WebKit/LayoutTests/css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html [modify] https://crrev.com/112c0577ad48a4cfe0b6046364f67bd97dc14eff/third_party/WebKit/LayoutTests/css3/flexbox/flexbox-wordwrap.html [modify] https://crrev.com/112c0577ad48a4cfe0b6046364f67bd97dc14eff/third_party/WebKit/LayoutTests/css3/flexbox/multiline-align-content.html [modify] https://crrev.com/112c0577ad48a4cfe0b6046364f67bd97dc14eff/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
,
Sep 6 2016
Verified the Merge of reverted CL from C#7 and this is WAI as intended on the latest M-54(54.0.2840.14), Windows-10 , Mac OS 10.11.6 and Linux Ubuntu 14.04. Reverted CL was merged to M-54 in Issue 634672 , C#18. Adding the verified label therefore.
,
Sep 8 2016
Do you want to keep this open now that the revert has landed Christian or should we mark it as Fixed?
,
Sep 9 2016
I'd like to keep this open as a reminder to investigate exactly why this use case broke, for when we reland this (and in case it also affects actual wrapping flexboxes)
,
Oct 18 2016
(changing type and priority now that the regression has been addressed)
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/829b6a7b22da492c51544d1f0e97ac23b5919467 commit 829b6a7b22da492c51544d1f0e97ac23b5919467 Author: Christian Biesinger <cbiesinger@chromium.org> Date: Fri Sep 02 18:55:18 2016 Revert of [css-flexbox] align-content should apply even when there's just a single line (patchset #2 id:20001 of https://codereview.chromium.org/2191683003/ ) Reason for revert: Caused multiple regressions ( bug 634672 , bug 641789 ) and I'd like more time to investigate them before shipping this to users. Original issue's description: > [css-flexbox] align-content should apply even when there's just a single line > > In Jan 2015 the spec changed in > https://drafts.csswg.org/css-flexbox/#change-201409-align-content-wrapping > > Change our code accordingly. This effectively reverts commit > 764735dc12285a09a32b7d5ad3a8d6f178b0ab83 > > BUG=599828 > R=eae@chromium.org,dgrogan@chromium.org > > Committed: https://crrev.com/955a53c8bc7f04b4830acabf7291c603314e0a53 > Cr-Commit-Position: refs/heads/master@{#408456} TBR=dgrogan@chromium.org,eae@chromium.org BUG=599828, 634672 , 641789 Review-Url: https://codereview.chromium.org/2289793003 Cr-Commit-Position: refs/heads/master@{#415844} (cherry picked from commit 112c0577ad48a4cfe0b6046364f67bd97dc14eff) Review URL: https://codereview.chromium.org/2309493002 . Cr-Commit-Position: refs/branch-heads/2840@{#130} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/829b6a7b22da492c51544d1f0e97ac23b5919467/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/829b6a7b22da492c51544d1f0e97ac23b5919467/third_party/WebKit/LayoutTests/css3/flexbox/alignContent-applies-with-flexWrap-wrap-with-single-line.html [modify] https://crrev.com/829b6a7b22da492c51544d1f0e97ac23b5919467/third_party/WebKit/LayoutTests/css3/flexbox/flexbox-wordwrap.html [modify] https://crrev.com/829b6a7b22da492c51544d1f0e97ac23b5919467/third_party/WebKit/LayoutTests/css3/flexbox/multiline-align-content.html [modify] https://crrev.com/829b6a7b22da492c51544d1f0e97ac23b5919467/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
,
Oct 28 2016
Decided to reopen the original bug for continuing this work. This bug as filed is fixed. See bug 599828 for further work.
,
Nov 7
(instructions: resize window to be smaller; you should still see the first line ("xxx.") and the bullet for the list)
,
Nov 14
Testcase in https://chromium-review.googlesource.com/c/chromium/src/+/1323906 as align-content-wrap-004.html |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by karandeepb@chromium.org
, Aug 29 2016Labels: -Pri-2 Pri-1
Status: Untriaged (was: Unconfirmed)