New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641776 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
not working at Google anymore
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

TDI: Improve how task manager shows subframe process(es)

Project Member Reported by ojan@chromium.org, Aug 28 2016

Issue description

In investigating  issue 641775 , I found the task manager really hard to use. I wanted to be able to see which tab the subframe was associated with (took a long time to realize I could double-click on the item in the task manager to focus that tab).

Also, the http://web-subframes.invalid/ is pretty confusing and looks like a bug.

Could we have the text instead be one of the following?

-Subframe for <title of parent tab>
-Subframe for process <parent's PID>
 

Comment 1 by nasko@chromium.org, Aug 29 2016

Cc: creis@chromium.org a...@chromium.org nasko@chromium.org
Owner: nick@chromium.org
Were you using Canary? There have been improvements to Task Manager to make it easier to use that just recently came to the Mac.

Comment 2 by ojan@chromium.org, Aug 29 2016

I was on canary on Mac. I think it was up to date.

Comment 3 by a...@chromium.org, Aug 29 2016

The Mac's task manager should behave identically to the Views task manager. If there is any difference, assign to me. If not, then your issues are with the core TM code, and Nick is your peep.
Status: Assigned (was: Untriaged)
[mac triage]

Comment 5 by creis@chromium.org, Aug 30 2016

Labels: -OS-Mac Proj-TopDocumentIsolation-BlockingLaunch OS-All
Summary: TDI: Improve how task manager shows subframe process(es) (was: task manager UI for OOPIF still could use some work)
Yes, this is an area we have plans to improve for --top-document-isolation mode, which is what this bug is about.  (Things are already in decent shape for --isolate-extensions and full --site-per-process.)

Specifically, the http://web-subframes.invalid/ URL is just a short-term placeholder.  I think Nick has some plans for how to improve how the TDI process is displayed.

Comment 6 by a...@chromium.org, Oct 21 2016

Ojan, what do you think? This is https://codereview.chromium.org/2437253002 .
Screen Shot 2016-10-20 at 6.47.25 PM.png
58.7 KB View Download

Comment 7 by ojan@chromium.org, Oct 24 2016

lgtm, thanks! What does it look like if there are frames from multiple tabs in a single process?

Comment 8 by a...@chromium.org, Oct 24 2016

This doesn't have the automagic sorting (it's manually sorted by task name) but like this.
Screen Shot 2016-10-20 at 6.50.04 PM.png
57.4 KB View Download

Comment 9 by ojan@chromium.org, Oct 24 2016

That looks great. Thanks!
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85cacb7b374d9018a67202f6082a4100423380b2

commit 85cacb7b374d9018a67202f6082a4100423380b2
Author: avi <avi@chromium.org>
Date: Wed Oct 26 22:39:33 2016

Improve TDI render process naming in the task manager.

BUG= 641776 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2437253002
Cr-Commit-Position: refs/heads/master@{#427855}

[modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/chrome/app/generated_resources.grd
[modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/chrome/browser/task_manager/providers/web_contents/renderer_task.h
[modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/chrome/browser/task_manager/providers/web_contents/subframe_task.cc
[modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/chrome/browser/task_manager/providers/web_contents/subframe_task.h
[modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/chrome/browser/task_manager/providers/web_contents/subframe_task_browsertest.cc
[modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/chrome/browser/task_manager/providers/web_contents/web_contents_task_provider.cc
[modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/content/browser/frame_host/render_frame_host_manager.cc
[modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/content/browser/site_instance_impl.cc
[modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/content/browser/site_instance_impl.h
[modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/content/browser/site_instance_impl_unittest.cc
[modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/content/public/browser/site_instance.h
[modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/content/test/content_browser_test_utils_internal.cc

Comment 11 by a...@chromium.org, Oct 26 2016

So the Task Manager naming issue is fixed. Does this bug include other issues that need fixing?

Comment 12 by nick@chromium.org, Oct 26 2016

I consider this fixed.

Comment 13 by a...@chromium.org, Oct 26 2016

Ojan?

Comment 14 by ojan@chromium.org, Oct 27 2016

Status: Fixed (was: Assigned)
Agreed. Thanks!

Sign in to add a comment