TDI: Improve how task manager shows subframe process(es) |
||||
Issue descriptionIn investigating issue 641775 , I found the task manager really hard to use. I wanted to be able to see which tab the subframe was associated with (took a long time to realize I could double-click on the item in the task manager to focus that tab). Also, the http://web-subframes.invalid/ is pretty confusing and looks like a bug. Could we have the text instead be one of the following? -Subframe for <title of parent tab> -Subframe for process <parent's PID>
,
Aug 29 2016
I was on canary on Mac. I think it was up to date.
,
Aug 29 2016
The Mac's task manager should behave identically to the Views task manager. If there is any difference, assign to me. If not, then your issues are with the core TM code, and Nick is your peep.
,
Aug 30 2016
[mac triage]
,
Aug 30 2016
Yes, this is an area we have plans to improve for --top-document-isolation mode, which is what this bug is about. (Things are already in decent shape for --isolate-extensions and full --site-per-process.) Specifically, the http://web-subframes.invalid/ URL is just a short-term placeholder. I think Nick has some plans for how to improve how the TDI process is displayed.
,
Oct 21 2016
Ojan, what do you think? This is https://codereview.chromium.org/2437253002 .
,
Oct 24 2016
lgtm, thanks! What does it look like if there are frames from multiple tabs in a single process?
,
Oct 24 2016
This doesn't have the automagic sorting (it's manually sorted by task name) but like this.
,
Oct 24 2016
That looks great. Thanks!
,
Oct 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85cacb7b374d9018a67202f6082a4100423380b2 commit 85cacb7b374d9018a67202f6082a4100423380b2 Author: avi <avi@chromium.org> Date: Wed Oct 26 22:39:33 2016 Improve TDI render process naming in the task manager. BUG= 641776 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2437253002 Cr-Commit-Position: refs/heads/master@{#427855} [modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/chrome/app/generated_resources.grd [modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/chrome/browser/task_manager/providers/web_contents/renderer_task.h [modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/chrome/browser/task_manager/providers/web_contents/subframe_task.cc [modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/chrome/browser/task_manager/providers/web_contents/subframe_task.h [modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/chrome/browser/task_manager/providers/web_contents/subframe_task_browsertest.cc [modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/chrome/browser/task_manager/providers/web_contents/web_contents_task_provider.cc [modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/content/browser/frame_host/render_frame_host_manager.cc [modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/content/browser/site_instance_impl.cc [modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/content/browser/site_instance_impl.h [modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/content/browser/site_instance_impl_unittest.cc [modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/content/public/browser/site_instance.h [modify] https://crrev.com/85cacb7b374d9018a67202f6082a4100423380b2/content/test/content_browser_test_utils_internal.cc
,
Oct 26 2016
So the Task Manager naming issue is fixed. Does this bug include other issues that need fixing?
,
Oct 26 2016
I consider this fixed.
,
Oct 26 2016
Ojan?
,
Oct 27 2016
Agreed. Thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by nasko@chromium.org
, Aug 29 2016Owner: nick@chromium.org