Issue metadata
Sign in to add a comment
|
Regression: The Toolbar Slide In Animation is not smooth on NewTabPage when you click on the Fake-Search-Field |
||||||||||||||||||||||
Issue descriptionVersion: Version 55.0.2842.0 canary (64-bit) OS: Mac OS 10.11.6 What steps will reproduce the problem? (1) Enable "Hide Toolbars when in Fullscreen" (2) Open a NewTabPage in Fullscreen Mode (3) Click somewhere on the NTP, so that the Toolbar disappears (4) Now click on the Fake-Search-Field in the middle of the NTP What is the expected output? The Toolbar slides in with a smooth animation. What do you see instead? The Toolbar animation is not smooth. Please use labels and text to provide additional information. This is a regression. Works fine in Chrome Stable. Thanks in advance. Mehmet
,
Sep 13 2016
Verified the issue on Mac 10.11.6 using 55.0.2859.0 and Toolbar slides in with a smooth animation when in Full screen mode compared to 55.0.2842.0. Note : Attached video for reference and the screencast-O-matic is not capturing the video so smooth. spqchan@ : Please mark the status of the issue to Fixed if no further work to be done on this.
,
Sep 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cbc6cd466a75352f240c1308c96ebccb2ec4dae commit 1cbc6cd466a75352f240c1308c96ebccb2ec4dae Author: spqchan <spqchan@chromium.org> Date: Tue Sep 13 20:11:41 2016 [Mac] Fullscreen Toolbar Bar Visibility Edge Cases Fixed edge case for the toolbar visibility locks. BUG= 641751 , 641749 Review-Url: https://codereview.chromium.org/2296903002 Cr-Commit-Position: refs/heads/master@{#417799} (cherry picked from commit a431d992f7c15f070be18e6a51419c11445a785a) Review URL: https://codereview.chromium.org/2339663002 . Cr-Commit-Position: refs/branch-heads/2840@{#337} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller_private.h [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_layout.h [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_layout.mm [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_layout_unittest.mm [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm
,
Sep 14 2016
Verified the merge on the latest M-54(54.0.2840.27) on Mac OS 10.11.6 and this is working as intended there. There is distinct difference b/w the toolbar slide animation on the reported version(55.0.2842.0) and the chrome versions with the fix(canary: 55.0.28590, beta: 54.0.2840.27). Adding the verified label therefore. Note: Attached is screen-cast of the behavior on the build without the fix. Build with the fix behavior is attached in C#2.
,
Sep 14 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1cbc6cd466a75352f240c1308c96ebccb2ec4dae commit 1cbc6cd466a75352f240c1308c96ebccb2ec4dae Author: spqchan <spqchan@chromium.org> Date: Tue Sep 13 20:11:41 2016 [Mac] Fullscreen Toolbar Bar Visibility Edge Cases Fixed edge case for the toolbar visibility locks. BUG= 641751 , 641749 Review-Url: https://codereview.chromium.org/2296903002 Cr-Commit-Position: refs/heads/master@{#417799} (cherry picked from commit a431d992f7c15f070be18e6a51419c11445a785a) Review URL: https://codereview.chromium.org/2339663002 . Cr-Commit-Position: refs/branch-heads/2840@{#337} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller_private.h [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_layout.h [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_layout.mm [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_layout_unittest.mm [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h [modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 10 2016