New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 641749 link

Starred by 2 users
Status: Fixed
Owner:
█ spqc...@chromium.org
Last visit > 30 days ago
Closed: Sep 2016
Cc:
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Toolbar disappears when you close tabs

Project Member Reported by meh...@chromium.org, Aug 28 2016 
Version: Version 55.0.2842.0 canary (64-bit)
OS: Mac OS 10.11.6

What steps will reproduce the problem?
(1) Enable "Hide Toolbars when in Fullscreen"
(2) Open a window in Fullscreen Mode
(3) Open a second tab in this window
(4) Close the new created tab by clicking on the Tab Close button

What is the expected output?
The tab should close, but the toolbars (with the first tab) should be visible, because the mouse cursor is still hovering over the toolbars 

What do you see instead?
The tab closes and everything else disappears, too.

Please use labels and text to provide additional information.
This is a regression and probably broken with one of the latest fullscreen tweaks.

BTW: Your latest patch https://codereview.chromium.org/2272783002 is already in this Canary Version.

If you need more information, please let me know.

Thanks
Mehmet

Comment 1 by meh...@chromium.org, Aug 28 2016

Components: UI>Browser>FullScreen

Comment 2 by spqc...@chromium.org, Sep 1 2016

Labels: ReleaseBlock-Stable
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a431d992f7c15f070be18e6a51419c11445a785a

commit a431d992f7c15f070be18e6a51419c11445a785a
Author: spqchan <spqchan@chromium.org>
Date: Sat Sep 10 02:06:45 2016

[Mac] Fullscreen Toolbar Bar Visibility Edge Cases

Fixed edge case for the toolbar visibility locks.

BUG= 641751 ,  641749 

Review-Url: https://codereview.chromium.org/2296903002
Cr-Commit-Position: refs/heads/master@{#417799}

[modify] https://crrev.com/a431d992f7c15f070be18e6a51419c11445a785a/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/a431d992f7c15f070be18e6a51419c11445a785a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/a431d992f7c15f070be18e6a51419c11445a785a/chrome/browser/ui/cocoa/browser_window_controller_private.h
[modify] https://crrev.com/a431d992f7c15f070be18e6a51419c11445a785a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/a431d992f7c15f070be18e6a51419c11445a785a/chrome/browser/ui/cocoa/browser_window_layout.h
[modify] https://crrev.com/a431d992f7c15f070be18e6a51419c11445a785a/chrome/browser/ui/cocoa/browser_window_layout.mm
[modify] https://crrev.com/a431d992f7c15f070be18e6a51419c11445a785a/chrome/browser/ui/cocoa/browser_window_layout_unittest.mm
[modify] https://crrev.com/a431d992f7c15f070be18e6a51419c11445a785a/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h
[modify] https://crrev.com/a431d992f7c15f070be18e6a51419c11445a785a/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm

Comment 4 by krajshree@chromium.org, Sep 13 2016

Labels: TE-Verified-M55 TE-Verified-55.0.2859.0
Verified this issue on Mac 10.11.6 using chrome dev version #55.0.2859.0 and observed that the fix is working as expected.

Attaching screencast for reference.

Hence, adding the verified labels.
641749.mp4
1.9 MB View Download

Comment 5 by spqc...@chromium.org, Sep 13 2016

Labels: Merge-Request-54
Status: Started (was: Assigned)

Comment 6 by dimu@chromium.org, Sep 13 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 13 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cbc6cd466a75352f240c1308c96ebccb2ec4dae

commit 1cbc6cd466a75352f240c1308c96ebccb2ec4dae
Author: spqchan <spqchan@chromium.org>
Date: Tue Sep 13 20:11:41 2016

[Mac] Fullscreen Toolbar Bar Visibility Edge Cases

Fixed edge case for the toolbar visibility locks.

BUG= 641751 ,  641749 

Review-Url: https://codereview.chromium.org/2296903002
Cr-Commit-Position: refs/heads/master@{#417799}
(cherry picked from commit a431d992f7c15f070be18e6a51419c11445a785a)

Review URL: https://codereview.chromium.org/2339663002 .

Cr-Commit-Position: refs/branch-heads/2840@{#337}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller_private.h
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_layout.h
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_layout.mm
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_layout_unittest.mm
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm

Comment 8 by ajha@chromium.org, Sep 14 2016

Labels: TE-Verified-M54 TE-Verified-54.0.2840.27
Verified the merge of C#7 on the latest M-54(54.0.2840.27) on Mac OS 10.11.6 and this is working as intended following the test steps in C#0. 

Adding the proper verified label.

Comment 9 by spqc...@chromium.org, Sep 14 2016

Status: Fixed (was: Started)
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cbc6cd466a75352f240c1308c96ebccb2ec4dae

commit 1cbc6cd466a75352f240c1308c96ebccb2ec4dae
Author: spqchan <spqchan@chromium.org>
Date: Tue Sep 13 20:11:41 2016

[Mac] Fullscreen Toolbar Bar Visibility Edge Cases

Fixed edge case for the toolbar visibility locks.

BUG= 641751 ,  641749 

Review-Url: https://codereview.chromium.org/2296903002
Cr-Commit-Position: refs/heads/master@{#417799}
(cherry picked from commit a431d992f7c15f070be18e6a51419c11445a785a)

Review URL: https://codereview.chromium.org/2339663002 .

Cr-Commit-Position: refs/branch-heads/2840@{#337}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller.mm
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller_private.h
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_controller_private.mm
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_layout.h
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_layout.mm
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/browser_window_layout_unittest.mm
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h
[modify] https://crrev.com/1cbc6cd466a75352f240c1308c96ebccb2ec4dae/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm
►

Sign in to add a comment