Issue metadata
Sign in to add a comment
|
3% regression in speedometer at 414686:414692 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 28 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9003084541421792656
,
Aug 28 2016
=== Auto-CCing suspected CL author johnme@chromium.org === Hi johnme@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Revert of Support server categories in NTPSnippetsService. (patchset #3 id:40001 of https://codereview.chromium.org/2279863002/ ) Author : johnme Commit description: Reason for revert: I'm afraid this failed again on https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/27385/steps/components_unittests%20on%20Mac-10.9 Original issue's description: > Support server categories in NTPSnippetsService. > > Reland of: > https://crrev.com/330958ddcdcd0084d724571eddaa66f9c364115f > > Not clear why tests failed; they passed for me and in the CQ. > Removed one synchronization bit that wasn't really part of the change. > > BUG=633613 > > Committed: https://crrev.com/880bb766ee4985a8dd36be10098c5196c41f7509 > Cr-Commit-Position: refs/heads/master@{#414681} TBR=treib@chromium.org,sfiera@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=633613 Review-Url: https://codereview.chromium.org/2283743002 Cr-Commit-Position: refs/heads/master@{#414686} Commit : bc1a4e2725d8166b45bff9b8ce4edd6679ab0f1d Date : Fri Aug 26 11:25:35 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@414685 534.227 6.86021 12 good chromium@414686 542.389 6.52241 12 bad <-- chromium@414687 544.721 6.06327 12 bad chromium@414689 545.6 3.719 5 bad chromium@414692 544.393 6.97327 8 bad Bisect job ran on: winx64intel_perf_bisect Bug ID: 641746 Test Command: src/tools/perf/run_benchmark -v --browser=release_x64 --output-format=chartjson --upload-results --also-run-disabled-tests speedometer Test Metric: jQuery-TodoMVC/jQuery-TodoMVC Relative Change: 1.76% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64intel_perf_bisect/builds/1150 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9003084541421792656 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=4993481586507776 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Feb 7 2017
This patch is a revert, and the reverted patch was relanded in 880bb766ee4985a8dd36be10098c5196c41f7509, so I don't think there's any more to do here. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by nikolaos@chromium.org
, Aug 28 2016