New issue
Advanced search Search tips

Issue 641734 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

cvox2 time and system time are out of sync

Project Member Reported by chaok@google.com, Aug 28 2016

Issue description

Mode: force_next
Version: 54.0.2837.0
Reproduction Steps: 
1. search+a+d to check time with cvox2
2. alt+shift+s for status bar
3. Note #1 time is based on last time cvox2 focused status bar and #2 is always correct


 
I am not able to reliably repro this, but I have seen this as well.
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 28 2016

Labels: Hotlist-Google
This command is not listed in the CVOX + . help.


On 8/28/2016 2:28 AM, ch… via monorail wrote:
Just added it to the list of what we need to add to the command menu, thanks!

I'm not able to repro this... any further steps you've taken to experience this issue?  


Comment 5 by chaok@google.com, Aug 29 2016

I just tried it now and search+a+d said it was 1:47 pm, where alt+shift+s utterd  2:35 PM
Labels: -Pri-2 Phase3 Pri-3
Owner: dtseng@chromium.org
Status: Assigned (was: Unconfirmed)
Ah, I just was able to repro after navigating to search + A + D then to the status tray, then back to search + A + D. Got it. 
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75025da30515c2abfa9ce587ca7b0aedaad7ea4e

commit 75025da30515c2abfa9ce587ca7b0aedaad7ea4e
Author: dtseng <dtseng@chromium.org>
Date: Thu Sep 01 03:20:40 2016

Update desktop tree when Aura windows are removed.

Since the Automation API utilizes wrapper objects (necessary as it keeps its own
id map and cache) and the tree structure contains views, widgets, windows, and a
fake desktop root, we were not tied to the same lifetime as the wrapped
objects. This cl makes it so we do the needed cleanup when windows and widgets
get removed.

In particular, we try to observe as early as possible every observer method that
causes a widget or window to be detached. We still need the additional methods
(Destroy*) because accessibility events might be fired between Destroying* and
Destroyed*.

The bug in ChromeVox where time gets scrapped from the desktop tree revealed the issue and required we update the client tree with a children changed event on the parent of a removed window. Other platforms do not have this problem because they talk to the browser process directly whereas ChromeVox talks to the desktop tree in its rendere extension process.

BUG= 641734 
TEST=AutomationApiTest and manual test with ChromeVox on status tray; verify views/widgets get detached from the desktop tree in js when the status tray is hidden
Additionally, other native windows update ChromeVox appropriately when closed. Ctrl+F find, blluetooth dialog, etc.

Review-Url: https://codereview.chromium.org/2295183003
Cr-Commit-Position: refs/heads/master@{#415871}

[modify] https://crrev.com/75025da30515c2abfa9ce587ca7b0aedaad7ea4e/chrome/browser/ui/aura/accessibility/automation_manager_aura.cc
[modify] https://crrev.com/75025da30515c2abfa9ce587ca7b0aedaad7ea4e/chrome/browser/ui/aura/accessibility/automation_manager_aura.h
[modify] https://crrev.com/75025da30515c2abfa9ce587ca7b0aedaad7ea4e/ui/views/accessibility/ax_aura_obj_cache.cc
[modify] https://crrev.com/75025da30515c2abfa9ce587ca7b0aedaad7ea4e/ui/views/accessibility/ax_aura_obj_cache.h
[modify] https://crrev.com/75025da30515c2abfa9ce587ca7b0aedaad7ea4e/ui/views/accessibility/ax_widget_obj_wrapper.cc
[modify] https://crrev.com/75025da30515c2abfa9ce587ca7b0aedaad7ea4e/ui/views/accessibility/ax_widget_obj_wrapper.h
[modify] https://crrev.com/75025da30515c2abfa9ce587ca7b0aedaad7ea4e/ui/views/accessibility/ax_window_obj_wrapper.cc
[modify] https://crrev.com/75025da30515c2abfa9ce587ca7b0aedaad7ea4e/ui/views/accessibility/ax_window_obj_wrapper.h

Status: fixed (was: Assigned)

Comment 9 by chaok@google.com, Sep 12 2016

The times are insync in: 55.0.2857.0

Thanks!

Comment 10 by chaok@google.com, Sep 13 2016

Status: Verified (was: Fixed)

Sign in to add a comment