QUIC broken on OSX Canary |
||||||||
Issue descriptionOS X Canary is unable to speak QUIC. QUIC session creation is failing when trying to execute SetDoNotFragment. This method returns ERR_NOT_IMPLEMENTED on OS X, since the SO X does not provide any API for this.
,
Aug 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8449205b62b9278cb76710b9bbbb06e7a7c07077 commit 8449205b62b9278cb76710b9bbbb06e7a7c07077 Author: Ryan Hamilton <rch@chromium.org> Date: Mon Aug 29 23:24:15 2016 Ignore errors on SetDoNotFragment on platforms where it is not implemented. BUG= 641709 R=ianswett@chromium.org, jri@chromium.org Review URL: https://codereview.chromium.org/2287073002 . Cr-Commit-Position: refs/heads/master@{#415037} [modify] https://crrev.com/8449205b62b9278cb76710b9bbbb06e7a7c07077/net/quic/chromium/quic_stream_factory.cc
,
Aug 30 2016
,
Aug 30 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Aug 31 2016
Verified the Fix on the latest canary(55.0.2845.0) on Mac OS 10.11.6. Quic sessions are getting recorded and Quic indicator extension is working as well. Adding the verified label therefore.
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5fafd524c4dab8d32f583208bc53516f7685542 commit c5fafd524c4dab8d32f583208bc53516f7685542 Author: Ryan Hamilton <rch@chromium.org> Date: Wed Aug 31 15:48:31 2016 [merge m54] Ignore errors on SetDoNotFragment on platforms where it is not implemented. BUG= 641709 R=ianswett@chromium.org, jri@chromium.org Review URL: https://codereview.chromium.org/2287073002 . Cr-Commit-Position: refs/heads/master@{#415037} (cherry picked from commit 8449205b62b9278cb76710b9bbbb06e7a7c07077) Review URL: https://codereview.chromium.org/2295223002 . Cr-Commit-Position: refs/branch-heads/2840@{#71} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/c5fafd524c4dab8d32f583208bc53516f7685542/net/quic/chromium/quic_stream_factory.cc
,
Sep 1 2016
Verified the merge on Mac OS 10.11.6, chrome version: 54.0.2840.8(refs/branch-heads/2840@{#91}) and this is working as intended.
,
Sep 1 2016
,
Sep 1 2016
Excellent, thank you!
,
Sep 2 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c5fafd524c4dab8d32f583208bc53516f7685542 commit c5fafd524c4dab8d32f583208bc53516f7685542 Author: Ryan Hamilton <rch@chromium.org> Date: Wed Aug 31 15:48:31 2016 [merge m54] Ignore errors on SetDoNotFragment on platforms where it is not implemented. BUG= 641709 R=ianswett@chromium.org, jri@chromium.org Review URL: https://codereview.chromium.org/2287073002 . Cr-Commit-Position: refs/heads/master@{#415037} (cherry picked from commit 8449205b62b9278cb76710b9bbbb06e7a7c07077) Review URL: https://codereview.chromium.org/2295223002 . Cr-Commit-Position: refs/branch-heads/2840@{#71} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/c5fafd524c4dab8d32f583208bc53516f7685542/net/quic/chromium/quic_stream_factory.cc |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rch@chromium.org
, Aug 29 2016