New issue
Advanced search Search tips

Issue 641678 link

Starred by 1 user
Status: Assigned
Owner:
wychen@chromium.org
Cc:
mdjones@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Customized twitter embeds are not recognized in Dom Distiller

Project Member Reported by wychen@chromium.org, Aug 27 2016 
Some sites use customized twitter embed, which is not recognized by Dom Distiller.

Example:
http://www.telegraph.co.uk/news/worldnews/northamerica/usa/9642169/Hurricane-Sandy-live.html

HTML snippet:
<iframe src="http://s.telegraph.co.uk/graphics/html/TwitterEmbed/Version1/web8491.html" ...>...</iframe>

One possible solution is to look for <a href="*://twitter.com/*/status/*"> in the iframes.

Recent pages on telegraph use standard twitter embeds, so this is low priority.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be54205fd0475ee4de5585a3ee986b34b089bff3

commit be54205fd0475ee4de5585a3ee986b34b089bff3
Author: wychen <wychen@chromium.org>
Date: Wed Aug 31 00:12:24 2016

Roll DOM Distiller JavaScript distribution package

Diff since last roll:
https://github.com/chromium/dom-distiller/compare/b21e6a334a...d16a68c1b8

Picked up changes:
d16a68c Fix partially hidden article
85447bd Ignore exceptions in embed extractors
50efabe Skip unrecognized iframes
23830cf Use .innerText in text-only mode
7306201 Avoid creating container when possible
5323f43 Forbid usage of GWT's Element.getInnerText()

BUG=599121, 637170 ,641678

Review-Url: https://codereview.chromium.org/2297023002
Cr-Commit-Position: refs/heads/master@{#415507}

[modify] https://crrev.com/be54205fd0475ee4de5585a3ee986b34b089bff3/DEPS
[modify] https://crrev.com/be54205fd0475ee4de5585a3ee986b34b089bff3/third_party/dom_distiller_js/README.chromium

Comment 2 by wychen@chromium.org, Aug 31 2016 

This is not fixed yet. Still low priority.

Comment 3 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)
►

Sign in to add a comment