Issue metadata
Sign in to add a comment
|
10.8% regression in system_health.memory_desktop at 414221:414281 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 27 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9003192133797789552
,
Aug 27 2016
=== Auto-CCing suspected CL author waffles@chromium.org === Hi waffles@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Unbundle Flash on Linux. Author : waffles Commit description: TEST=https://docs.google.com/a/google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/pub BUG=624086 Review-Url: https://codereview.chromium.org/2270243002 Cr-Commit-Position: refs/heads/master@{#414249} Commit : 366d572053dd85c8eeda802f423716d9b008fe01 Date : Thu Aug 25 02:12:40 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@414220 30071607 217506 5 good chromium@414236 30100786 413254 5 good chromium@414244 30211964 144877 5 good chromium@414248 30022216 411986 5 good chromium@414249 33350976 385021 5 bad <-- chromium@414250 33298294 192947 5 bad chromium@414251 33764011 976062 5 bad chromium@414281 33594860 645599 5 bad Bisect job ran on: linux_perf_bisect Bug ID: 641657 Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_desktop Test Metric: memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:effective_size_avg Relative Change: 11.72% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6672 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9003192133797789552 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5287180973375488 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Aug 29 2016
Looks like this is driven by load_news. I expect https://codereview.chromium.org/2284053002/ will "fix" this, although it's no surprise to me that v8 heap increases when there is no Flash (since pages are likely to load some sort of HTML5 fallback).
,
Aug 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd59e9b913623e8fec8bbc9d5517610bc1bfc9a7 commit cd59e9b913623e8fec8bbc9d5517610bc1bfc9a7 Author: waffles <waffles@chromium.org> Date: Tue Aug 30 04:34:44 2016 Register a fake Flash with chrome://plugins during browser start-up. This enables websites to query for the presence of Flash using navigator.plugins and navigator.mimeTypes even when we don't actually have it. TEST=https://docs.google.com/a/google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/pub BUG= 641448 ,641884, 641657 Review-Url: https://codereview.chromium.org/2284053002 Cr-Commit-Position: refs/heads/master@{#415100} [modify] https://crrev.com/cd59e9b913623e8fec8bbc9d5517610bc1bfc9a7/chrome/browser/plugins/plugin_info_message_filter.cc [modify] https://crrev.com/cd59e9b913623e8fec8bbc9d5517610bc1bfc9a7/chrome/common/chrome_content_client.cc [modify] https://crrev.com/cd59e9b913623e8fec8bbc9d5517610bc1bfc9a7/chrome/common/chrome_content_client.h [modify] https://crrev.com/cd59e9b913623e8fec8bbc9d5517610bc1bfc9a7/chrome/common/chrome_content_client_constants.cc
,
Aug 30 2016
,
Aug 31 2016
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e450b2360ecde771cdfb67c647fef7523bde435f commit e450b2360ecde771cdfb67c647fef7523bde435f Author: Joshua Pawlicki <waffles@google.com> Date: Thu Sep 01 23:12:11 2016 Register a fake Flash with chrome://plugins during browser start-up. This enables websites to query for the presence of Flash using navigator.plugins and navigator.mimeTypes even when we don't actually have it. TEST=https://docs.google.com/a/google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/pub BUG= 641448 ,641884, 641657 Review-Url: https://codereview.chromium.org/2284053002 Cr-Commit-Position: refs/heads/master@{#415100} (cherry picked from commit cd59e9b913623e8fec8bbc9d5517610bc1bfc9a7) Review URL: https://codereview.chromium.org/2303983002 . Cr-Commit-Position: refs/branch-heads/2840@{#113} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/e450b2360ecde771cdfb67c647fef7523bde435f/chrome/browser/plugins/plugin_info_message_filter.cc [modify] https://crrev.com/e450b2360ecde771cdfb67c647fef7523bde435f/chrome/common/chrome_content_client.cc [modify] https://crrev.com/e450b2360ecde771cdfb67c647fef7523bde435f/chrome/common/chrome_content_client.h [modify] https://crrev.com/e450b2360ecde771cdfb67c647fef7523bde435f/chrome/common/chrome_content_client_constants.cc
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e450b2360ecde771cdfb67c647fef7523bde435f commit e450b2360ecde771cdfb67c647fef7523bde435f Author: Joshua Pawlicki <waffles@google.com> Date: Thu Sep 01 23:12:11 2016 Register a fake Flash with chrome://plugins during browser start-up. This enables websites to query for the presence of Flash using navigator.plugins and navigator.mimeTypes even when we don't actually have it. TEST=https://docs.google.com/a/google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/pub BUG= 641448 ,641884, 641657 Review-Url: https://codereview.chromium.org/2284053002 Cr-Commit-Position: refs/heads/master@{#415100} (cherry picked from commit cd59e9b913623e8fec8bbc9d5517610bc1bfc9a7) Review URL: https://codereview.chromium.org/2303983002 . Cr-Commit-Position: refs/branch-heads/2840@{#113} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/e450b2360ecde771cdfb67c647fef7523bde435f/chrome/browser/plugins/plugin_info_message_filter.cc [modify] https://crrev.com/e450b2360ecde771cdfb67c647fef7523bde435f/chrome/common/chrome_content_client.cc [modify] https://crrev.com/e450b2360ecde771cdfb67c647fef7523bde435f/chrome/common/chrome_content_client.h [modify] https://crrev.com/e450b2360ecde771cdfb67c647fef7523bde435f/chrome/common/chrome_content_client_constants.cc |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by mlippautz@chromium.org
, Aug 27 2016