New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641643 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocking:
issue 581997
issue 644572



Sign in to add a comment

GPU process crash when enabling certain extensions while a PBO is bound

Project Member Reported by kainino@chromium.org, Aug 27 2016

Issue description

Version: 54.0.2840.0 at 93f6859
OS: Ubuntu 14.04, NVIDIA (also seems to fail on most or all desktop platforms)

What steps will reproduce the problem?
(1) Create and bind a pixel buffer object to PIXEL_UNPACK_BUFFER.
(2) getExtension EXT_color_buffer_float or OES_texture_float_linear.

What is the expected output?

Nothing crashes.

What do you see instead?

GPU process crashes.
 

Comment 1 by kbr@chromium.org, Aug 27 2016

Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/803bcd7befd6a191578a8752ff82cd2bcddd7e1f

commit 803bcd7befd6a191578a8752ff82cd2bcddd7e1f
Author: kainino <kainino@chromium.org>
Date: Wed Aug 31 02:52:29 2016

Prevent crash when using getExtension while a PBO is bound.

BUG= 641643 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2291753002
Cr-Commit-Position: refs/heads/master@{#415547}

[modify] https://crrev.com/803bcd7befd6a191578a8752ff82cd2bcddd7e1f/gpu/command_buffer/service/context_group_unittest.cc
[modify] https://crrev.com/803bcd7befd6a191578a8752ff82cd2bcddd7e1f/gpu/command_buffer/service/feature_info.cc
[modify] https://crrev.com/803bcd7befd6a191578a8752ff82cd2bcddd7e1f/gpu/command_buffer/service/feature_info_unittest.cc
[modify] https://crrev.com/803bcd7befd6a191578a8752ff82cd2bcddd7e1f/gpu/command_buffer/service/framebuffer_manager_unittest.cc
[modify] https://crrev.com/803bcd7befd6a191578a8752ff82cd2bcddd7e1f/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc
[modify] https://crrev.com/803bcd7befd6a191578a8752ff82cd2bcddd7e1f/gpu/command_buffer/service/program_manager_unittest.cc
[modify] https://crrev.com/803bcd7befd6a191578a8752ff82cd2bcddd7e1f/gpu/command_buffer/service/renderbuffer_manager_unittest.cc
[modify] https://crrev.com/803bcd7befd6a191578a8752ff82cd2bcddd7e1f/gpu/command_buffer/service/test_helper.cc
[modify] https://crrev.com/803bcd7befd6a191578a8752ff82cd2bcddd7e1f/gpu/command_buffer/service/test_helper.h
[modify] https://crrev.com/803bcd7befd6a191578a8752ff82cd2bcddd7e1f/gpu/command_buffer/service/texture_manager_unittest.cc

Status: Verified (was: Assigned)
Status: Fixed (was: Verified)
Cc: zmo@chromium.org
WebGL context creation will fail if hold F5 button to keep refreshing conformance2/misc/getextension-while-pbo-bound-stability.html. If PIXEL_UNPACK_BUFFER is set previously, context creation fails due to INVALID_OPERATION errors are generated. Reset PIXEL_UNPACK_BUFFER  to 0 at the beginning of context initialization to work around this bug. See https://codereview.chromium.org/2302323002/.
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7457efe68c2227d792109c0d583c0d094bdfebdc

commit 7457efe68c2227d792109c0d583c0d094bdfebdc
Author: cwallez <cwallez@chromium.org>
Date: Tue Sep 06 20:17:45 2016

WebGL CTS: add expectations for flaky failures

BUG= 644360 
BUG= 641643 
TBR=zmo@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2317763002
Cr-Commit-Position: refs/heads/master@{#416692}

[modify] https://crrev.com/7457efe68c2227d792109c0d583c0d094bdfebdc/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 7 by kbr@chromium.org, Sep 7 2016

Blocking: 644572
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17ad0f1ca0367fbb6d28cd9ed3d4d60a44e0e655

commit 17ad0f1ca0367fbb6d28cd9ed3d4d60a44e0e655
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Fri Sep 09 20:14:05 2016

Reset PIXEL_UNPACK_BUFFER at texture manager initialization time

Otherwise, there will be some weird GL errors on some GL drivers.

BUG= 641643 ,  644572 
TEST=conformance2/misc/getextension-while-pbo-bound-stability.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2302323002
Cr-Commit-Position: refs/heads/master@{#417685}

[modify] https://crrev.com/17ad0f1ca0367fbb6d28cd9ed3d4d60a44e0e655/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/17ad0f1ca0367fbb6d28cd9ed3d4d60a44e0e655/gpu/command_buffer/service/test_helper.cc
[modify] https://crrev.com/17ad0f1ca0367fbb6d28cd9ed3d4d60a44e0e655/gpu/command_buffer/service/test_helper.h
[modify] https://crrev.com/17ad0f1ca0367fbb6d28cd9ed3d4d60a44e0e655/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/17ad0f1ca0367fbb6d28cd9ed3d4d60a44e0e655/gpu/command_buffer/service/texture_manager_unittest.cc

Sign in to add a comment