Quick View: controls missing for Mp3 when files app window is small |
|||||||||||||||||
Issue descriptionM54 | samus | 8743.0.0 Open Files app window to half way Get an MP3 with embedded album art Select it Press space See that it doesn't stay in its bounds compared to a video Compare video-1.png and mp3-1.png Make the Files app window small Repeat the above steps Since it doesn't stay in its bounds, you cannot get to the controls Compare video-2.png and mp3-2.png
,
Aug 29 2016
,
Aug 29 2016
,
Sep 8 2016
,
Sep 30 2016
,
Sep 30 2016
,
Dec 8 2016
,
Sep 5 2017
Lifting as a candidate for PE in M63.
,
Sep 6 2017
,
Sep 8 2017
,
Feb 23 2018
,
Feb 28 2018
,
Feb 28 2018
,
Oct 31
,
Nov 19
,
Nov 19
Audio quick view uses the html5 audio tag, which doesn't allow customization of its controls. So I'm sending a patch to reduce the metadata box (on the right hand side), so it has enough space for audio tag to display its controls. See attached screenshot with before and after my changes.
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18c300bc4839a26eb774ba5c2dde54193bdf5f2b commit 18c300bc4839a26eb774ba5c2dde54193bdf5f2b Author: Luciano Pacheco <lucmult@chromium.org> Date: Mon Nov 19 03:35:39 2018 Quick view: Reduce metadata box width when window is narrow Reduce metadata box width from 320px to 250px when the window is narrow (less than 720px). Reduce quick view main content left/right padding when window is less than 720px wide, from 32px to 4px. Change audio art work to be 100% width and height so it resizes with the window in the same way as video quick-view. These three changes allows for a proper display of audio tag controls when the window is narrow. See screenshot in the linked bug. Change some CSS order, 0.2s to 200ms and -webkit prefix to comply with presubmit. in behaviour. Also checked with video, img and pdf quick views. Test: Checked manually the visual with a window 480px wide, no change Bug: 641629 Change-Id: I4af2c8ea83f9167c6c398c0002ee2df8ec6a5531 Reviewed-on: https://chromium-review.googlesource.com/c/1341439 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#609172} [modify] https://crrev.com/18c300bc4839a26eb774ba5c2dde54193bdf5f2b/ui/file_manager/file_manager/foreground/elements/files_metadata_box.html [modify] https://crrev.com/18c300bc4839a26eb774ba5c2dde54193bdf5f2b/ui/file_manager/file_manager/foreground/elements/files_metadata_entry.html [modify] https://crrev.com/18c300bc4839a26eb774ba5c2dde54193bdf5f2b/ui/file_manager/file_manager/foreground/elements/files_quick_view.css
,
Nov 19
|
|||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||
Comment 1 by oka@chromium.org
, Aug 29 2016Summary: Quick View: controls missing for Mp3 when files app window is small (was: Quick view controls missing for Mp3 when files app window is small )