Issue 641628 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	isherman@chromium.org
Closed:	Oct 2016
Cc:	skare@chromium.org isherman@chromium.org asvitk...@chromium.org █ rkaplow@chromium.org
Components:	Internals>CrashReporting Internals>Metrics
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	2
Type:	Feature
M-54

Allow users to manually upload unsent crash reports on Android.

Project Member Reported by isherman@chromium.org, Aug 27 2016

Issue description

We are introducing sampling, such that some users who opt in to reporting crashes to Google will not have their crashes reported.  For these users, there is currently no way to upload their crash dumps to share with Google.  We'd like to enable them to share their crash dumps if they wish to.

This will also allow a user to decide to opt in to crash reporting *after* experiencing a crash -- either in general, or just for that specific crash -- and share their crash report at that time.

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17ad87db2d875747460f05b46a1f1032b57c77b9

commit 17ad87db2d875747460f05b46a1f1032b57c77b9
Author: isherman <isherman@chromium.org>
Date: Tue Aug 30 04:37:32 2016

[Android] Do not immediately delete skipped crash dump uploads.

This will give users a chance to decide to manually upload any skipped
crashes, which can be useful when reporting bugs.

This CL pairs nicely with [ https://codereview.chromium.org/2280313002/ ],
which adds some heuristics to clean up old/obsolete crash reports.

BUG= 641628 
TEST=CrashFileManagerTest.*, MinidumpUploadCallableTest.*
R=gayane@chromium.org

Review-Url: https://codereview.chromium.org/2281373002
Cr-Commit-Position: refs/heads/master@{#415103}

[modify] https://crrev.com/17ad87db2d875747460f05b46a1f1032b57c77b9/chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java
[modify] https://crrev.com/17ad87db2d875747460f05b46a1f1032b57c77b9/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java
[modify] https://crrev.com/17ad87db2d875747460f05b46a1f1032b57c77b9/chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashFileManagerTest.java
[modify] https://crrev.com/17ad87db2d875747460f05b46a1f1032b57c77b9/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f31ae5c0f5cc1f2337e16c68fdc3048336eff666

commit f31ae5c0f5cc1f2337e16c68fdc3048336eff666
Author: isherman <isherman@chromium.org>
Date: Thu Sep 01 01:36:20 2016

[Android] Delete old crash reports

Unsent crash reports can currently accumulate indefinitely, costing
users storage space.  This CL limits (1) the maximum number of unsent
reports that will be saved, and (2) the maximum age of a report.

BUG= 641628 
TEST=CrashFileManagerTest.*

Review-Url: https://codereview.chromium.org/2280313002
Cr-Commit-Position: refs/heads/master@{#415838}

[modify] https://crrev.com/f31ae5c0f5cc1f2337e16c68fdc3048336eff666/chrome/android/java/src/org/chromium/chrome/browser/crash/CrashFileManager.java
[modify] https://crrev.com/f31ae5c0f5cc1f2337e16c68fdc3048336eff666/chrome/android/javatests/src/org/chromium/chrome/browser/crash/CrashFileManagerTest.java
[modify] https://crrev.com/f31ae5c0f5cc1f2337e16c68fdc3048336eff666/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java
[modify] https://crrev.com/f31ae5c0f5cc1f2337e16c68fdc3048336eff666/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2da657316ab4cd2144cac614dddbf78551d71a28

commit 2da657316ab4cd2144cac614dddbf78551d71a28
Author: gayane <gayane@chromium.org>
Date: Wed Sep 07 22:19:32 2016

Show not uploaded crashes for Android.

In order to allow on-demand crash report uploads for Android
users, first show not uploaded or skipped crash reports.

BUG= 641628 

Review-Url: https://codereview.chromium.org/2301943003
Cr-Commit-Position: refs/heads/master@{#417089}

[modify] https://crrev.com/2da657316ab4cd2144cac614dddbf78551d71a28/chrome/browser/BUILD.gn
[modify] https://crrev.com/2da657316ab4cd2144cac614dddbf78551d71a28/chrome/browser/crash_upload_list/crash_upload_list.cc
[add] https://crrev.com/2da657316ab4cd2144cac614dddbf78551d71a28/chrome/browser/crash_upload_list/crash_upload_list_android.cc
[add] https://crrev.com/2da657316ab4cd2144cac614dddbf78551d71a28/chrome/browser/crash_upload_list/crash_upload_list_android.h
[modify] https://crrev.com/2da657316ab4cd2144cac614dddbf78551d71a28/components/upload_list/upload_list.cc
[modify] https://crrev.com/2da657316ab4cd2144cac614dddbf78551d71a28/components/upload_list/upload_list.h

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc7d54eab860b6c17661ae641a6024514a511f0e

commit cc7d54eab860b6c17661ae641a6024514a511f0e
Author: gayane <gayane@chromium.org>
Date: Wed Sep 14 16:53:49 2016

Show crash report size in crashes UI for Android.

As on Android manual crash uploads can happen on cellular
connection it is important to display the size of the crash reports.

BUG= 641628 

Review-Url: https://codereview.chromium.org/2330573002
Cr-Commit-Position: refs/heads/master@{#418590}

[modify] https://crrev.com/cc7d54eab860b6c17661ae641a6024514a511f0e/chrome/browser/crash_upload_list/crash_upload_list_android.cc
[modify] https://crrev.com/cc7d54eab860b6c17661ae641a6024514a511f0e/components/crash/core/browser/crashes_ui_util.cc
[modify] https://crrev.com/cc7d54eab860b6c17661ae641a6024514a511f0e/components/crash/core/browser/resources/crashes.js
[modify] https://crrev.com/cc7d54eab860b6c17661ae641a6024514a511f0e/components/crash_strings.grdp
[modify] https://crrev.com/cc7d54eab860b6c17661ae641a6024514a511f0e/components/upload_list/upload_list.cc
[modify] https://crrev.com/cc7d54eab860b6c17661ae641a6024514a511f0e/components/upload_list/upload_list.h

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fb2ead4ab711de980cad0f0a1fcae906ebd5c52

commit 4fb2ead4ab711de980cad0f0a1fcae906ebd5c52
Author: isherman <isherman@chromium.org>
Date: Thu Sep 22 01:21:33 2016

[Android] Wire up manual crash uploads.

BUG= 641628 
R=gayane@chromium.org

Review-Url: https://codereview.chromium.org/2324983002
Cr-Commit-Position: refs/heads/master@{#420227}

[modify] https://crrev.com/4fb2ead4ab711de980cad0f0a1fcae906ebd5c52/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java
[modify] https://crrev.com/4fb2ead4ab711de980cad0f0a1fcae906ebd5c52/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java
[modify] https://crrev.com/4fb2ead4ab711de980cad0f0a1fcae906ebd5c52/chrome/browser/BUILD.gn
[modify] https://crrev.com/4fb2ead4ab711de980cad0f0a1fcae906ebd5c52/chrome/browser/crash_upload_list/crash_upload_list_android.cc
[modify] https://crrev.com/4fb2ead4ab711de980cad0f0a1fcae906ebd5c52/chrome/browser/crash_upload_list/crash_upload_list_android.h
[modify] https://crrev.com/4fb2ead4ab711de980cad0f0a1fcae906ebd5c52/chrome/browser/ui/webui/crashes_ui.cc
[modify] https://crrev.com/4fb2ead4ab711de980cad0f0a1fcae906ebd5c52/components/upload_list/upload_list.cc

Comment 6 by isherman@chromium.org, Oct 6 2016

Status: Fixed (was: Started)

►

Issue 641628 link

Issue metadata

Allow users to manually upload unsent crash reports on Android.

Issue description

Comment 1 by bugdroid1@chromium.org, Aug 30 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Sep 1 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Sep 7 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Sep 14 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Sep 22 2016

Comment 5 Deleted

Comment 6 by isherman@chromium.org, Oct 6 2016

Comment 6 Deleted

Sign in to add a comment