New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641617 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 640685



Sign in to add a comment

Quick View: Cannot open quick view in the file selector / file download window

Project Member Reported by dhadd...@chromium.org, Aug 26 2016

Issue description

M54 | samus | 8743.0.0

Go to crbug.com
Start a new issue
Try to attach a file to your bug report 
Try to use quick view in the file selector window

Expected: You can preview files
Actual: You can't

Go to Chrome and try to download some cat pictures
In the save as dialog, try to use quick view 

Expected: You can preview files
Actual: You can't
 

Comment 1 by oka@chromium.org, Aug 29 2016

Owner: oka@chromium.org
Summary: Quick View: Cannot open quick view in the file selector / file download window (was: Cannot open quick view in the file selector / file download window )

Comment 2 by oka@chromium.org, Aug 29 2016

Status: Started (was: Untriaged)
Blocking: 640685

Comment 4 by oka@chromium.org, Aug 30 2016

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3161c433a2fee484834a3c587e6d3ed111934f64

commit 3161c433a2fee484834a3c587e6d3ed111934f64
Author: oka <oka@chromium.org>
Date: Tue Aug 30 04:40:08 2016

Enable Quick View on file selector / file download window.

BUG= 641617 
TEST=manually tested.

Review-Url: https://codereview.chromium.org/2288663002
Cr-Commit-Position: refs/heads/master@{#415106}

[modify] https://crrev.com/3161c433a2fee484834a3c587e6d3ed111934f64/ui/file_manager/file_manager/foreground/js/file_manager.js

Comment 6 by oka@chromium.org, Sep 8 2016

Labels: Merge-Request-54
Merge request: I'd like to merge #c5 to M54.

Comment 7 by dimu@chromium.org, Sep 8 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 9 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c365be637d280bc4a8a5a112e2c2d7343f86c58e

commit c365be637d280bc4a8a5a112e2c2d7343f86c58e
Author: Keigo Oka <oka@chromium.org>
Date: Fri Sep 09 00:48:19 2016

Enable Quick View on file selector / file download window.

BUG= 641617 
TEST=manually tested.

Review-Url: https://codereview.chromium.org/2288663002
Cr-Commit-Position: refs/heads/master@{#415106}
(cherry picked from commit 3161c433a2fee484834a3c587e6d3ed111934f64)

Review URL: https://codereview.chromium.org/2323183002 .

Cr-Commit-Position: refs/branch-heads/2840@{#261}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/c365be637d280bc4a8a5a112e2c2d7343f86c58e/ui/file_manager/file_manager/foreground/js/file_manager.js

Status: Verified (was: Fixed)
Verified on ChromeOS 8743.57.0 / 54.0.2840.51
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c365be637d280bc4a8a5a112e2c2d7343f86c58e

commit c365be637d280bc4a8a5a112e2c2d7343f86c58e
Author: Keigo Oka <oka@chromium.org>
Date: Fri Sep 09 00:48:19 2016

Enable Quick View on file selector / file download window.

BUG= 641617 
TEST=manually tested.

Review-Url: https://codereview.chromium.org/2288663002
Cr-Commit-Position: refs/heads/master@{#415106}
(cherry picked from commit 3161c433a2fee484834a3c587e6d3ed111934f64)

Review URL: https://codereview.chromium.org/2323183002 .

Cr-Commit-Position: refs/branch-heads/2840@{#261}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/c365be637d280bc4a8a5a112e2c2d7343f86c58e/ui/file_manager/file_manager/foreground/js/file_manager.js

Sign in to add a comment