New issue
Advanced search Search tips

Issue 641614 link

Starred by 2 users
Status: Fixed
Owner:
nparker@chromium.org
Closed: Sep 2016
Cc:
vakh@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Remove .osx extension from download classification

Project Member Reported by nparker@chromium.org, Aug 26 2016 
We don't know what it is, and we don't warn for it, yet we classify it as a Mac exec. Seems to be vestigial.

https://cs.chromium.org/chromium/src/chrome/common/safe_browsing/download_protection_util.cc?l=39

Comment 1 by karandeepb@chromium.org, Aug 29 2016

Owner: mattm@chromium.org
Status: Assigned (was: Untriaged)
Assigning to mattm@ as per blame.

Comment 2 by vakh@chromium.org, Sep 9 2016

Labels: SafeBrowsing-Triaged
Owner: nparker@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53e11ec60dd24dea99334c51142b3386540a7c99

commit 53e11ec60dd24dea99334c51142b3386540a7c99
Author: nparker <nparker@chromium.org>
Date: Tue Sep 13 00:49:18 2016

Remove .osx file extension as a type of Mac executable

BUG= 641614 

Review-Url: https://codereview.chromium.org/2331323002
Cr-Commit-Position: refs/heads/master@{#418125}

[modify] https://crrev.com/53e11ec60dd24dea99334c51142b3386540a7c99/chrome/common/safe_browsing/download_protection_util.cc

Comment 4 by nparker@chromium.org, Sep 13 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment