New issue
Advanced search Search tips

Issue 641613 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

"TextureLayerMailboxIsActivatedDuringCommit.RunMultiThread_DelegatingRenderer" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 26 2016

Issue description

"TextureLayerMailboxIsActivatedDuringCommit.RunMultiThread_DelegatingRenderer" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkxUZXh0dXJlTGF5ZXJNYWlsYm94SXNBY3RpdmF0ZWREdXJpbmdDb21taXQuUnVuTXVsdGlUaHJlYWRfRGVsZWdhdGluZ1JlbmRlcmVyDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by perkj@chromium.org, Aug 29 2016

Labels: -Sheriff-Chromium
Owner: danakj@chromium.org
Can you please take a look at this and find an owner? 
I have not yet disabled the tests since it does not happen that often.
Project Member

Comment 2 by chromium...@appspot.gserviceaccount.com, Aug 30 2016

Labels: Sheriff-Chromium
Detected 4 new flakes for test/step "TextureLayerMailboxIsActivatedDuringCommit.RunMultiThread_DelegatingRenderer". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkxUZXh0dXJlTGF5ZXJNYWlsYm94SXNBY3RpdmF0ZWREdXJpbmdDb21taXQuUnVuTXVsdGlUaHJlYWRfRGVsZWdhdGluZ1JlbmRlcmVyDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Pri-1 -Sheriff-Chromium OS-Windows Pri-2
Disabling the flaky tests in https://crrev.com/2292893005 :(
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f22b769f7207c390feaed9cd6238d17f8ecd7702

commit f22b769f7207c390feaed9cd6238d17f8ecd7702
Author: dgrogan <dgrogan@chromium.org>
Date: Tue Aug 30 23:24:08 2016

Disable TextureLayerMailboxIsActivatedDuringCommit.* on windows

BUG= 641613 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=danakj@chromium.org

Review-Url: https://codereview.chromium.org/2292893005
Cr-Commit-Position: refs/heads/master@{#415489}

[modify] https://crrev.com/f22b769f7207c390feaed9cd6238d17f8ecd7702/cc/layers/texture_layer_unittest.cc

Cc: piman@chromium.org enne@chromium.org
Status: Assigned (was: Untriaged)
Maybe probably due to Display changes or idk maybe its been flaky longer.
Before the logs are lost:

TextureLayerMailboxIsActivatedDuringCommit.RunMultiThread_DelegatingRenderer (run #1):
[ RUN      ] TextureLayerMailboxIsActivatedDuringCommit.RunMultiThread_DelegatingRenderer
[       OK ] TextureLayerMailboxIsActivatedDuringCommit.RunMultiThread_DelegatingRenderer (15 ms)
[----------] 2 tests from TextureLayerMailboxIsActivatedDuringCommit (29 ms total)

[----------] Global test environment tear-down
[==========] 10 tests from 5 test cases ran. (111 ms total)
[  PASSED  ] 10 tests.
[4952:4868:0830/071129:16724695:FATAL:texture_layer.cc(251)] Check failed: 0u == internal_references_ (0 vs. 1)
Backtrace:
	base::debug::StackTrace::StackTrace [0x0083D787+23]
	logging::LogMessage::~LogMessage [0x0080AA11+49]
	cc::TextureLayer::TextureMailboxHolder::~TextureMailboxHolder [0x006BB63B+91]
	cc::TextureLayer::TextureMailboxHolder::`scalar deleting destructor' [0x006BB70B+11]
	base::internal::BindState<void (__thiscall cc::TextureLayer::TextureMailboxHolder::*)(void),scoped_refptr<cc::TextureLayer::TextureMailboxHolder> >::Destroy [0x006BB8D2+50]
	base::internal::CallbackBase<0>::~CallbackBase<0> [0x0080BEFD+29]
	base::MessageLoop::~MessageLoop [0x00816747+247]
	base::MessageLoop::`scalar deleting destructor' [0x00816EBB+11]
	cc::CCTestSuite::Shutdown [0x005EE38C+20]
	base::LaunchUnitTests [0x00775D38+746]
	base::LaunchUnitTests [0x00775A98+74]
	main [0x005EE428+77]
	__scrt_common_main_seh [0x00BB5364+255] (f:\ddctools\crtcstartup\src\startup\exe_common.inl:255)
	BaseThreadInitThunk [0x754B337A+18]
	RtlInitializeExceptionChain [0x770392B2+99]
	RtlInitializeExceptionChain [0x77039285+54]

So it's a shutdown problem where the test is quitting too soon I think, maybe probably.
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7

commit bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7
Author: danakj <danakj@chromium.org>
Date: Thu Sep 08 01:33:53 2016

cc: Remove DelegatingRenderer.

Inline the tiny code left there into LayerTreeHostImpl, delete the
|renderer_| member and change references to the |output_surface_|
instead.

R=enne
BUG= 641613 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2323583002
Cr-Commit-Position: refs/heads/master@{#417150}

[modify] https://crrev.com/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7/cc/BUILD.gn
[modify] https://crrev.com/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7/cc/layers/picture_layer_impl.cc
[delete] https://crrev.com/85ec08ff3fe81629264fa6e9dcc39eb7dbbee9fd/cc/output/delegating_renderer.cc
[delete] https://crrev.com/85ec08ff3fe81629264fa6e9dcc39eb7dbbee9fd/cc/output/delegating_renderer.h
[delete] https://crrev.com/85ec08ff3fe81629264fa6e9dcc39eb7dbbee9fd/cc/output/delegating_renderer_unittest.cc
[modify] https://crrev.com/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7/cc/trees/layer_tree_impl.cc

Ops wrong bug.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 8 2016

Labels: merge-merged-2854
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7

commit bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7
Author: danakj <danakj@chromium.org>
Date: Thu Sep 08 01:33:53 2016

cc: Remove DelegatingRenderer.

Inline the tiny code left there into LayerTreeHostImpl, delete the
|renderer_| member and change references to the |output_surface_|
instead.

R=enne
BUG= 641613 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2323583002
Cr-Commit-Position: refs/heads/master@{#417150}

[modify] https://crrev.com/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7/cc/BUILD.gn
[modify] https://crrev.com/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7/cc/layers/picture_layer_impl.cc
[delete] https://crrev.com/85ec08ff3fe81629264fa6e9dcc39eb7dbbee9fd/cc/output/delegating_renderer.cc
[delete] https://crrev.com/85ec08ff3fe81629264fa6e9dcc39eb7dbbee9fd/cc/output/delegating_renderer.h
[delete] https://crrev.com/85ec08ff3fe81629264fa6e9dcc39eb7dbbee9fd/cc/output/delegating_renderer_unittest.cc
[modify] https://crrev.com/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7/cc/trees/layer_tree_host_impl.h
[modify] https://crrev.com/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7/cc/trees/layer_tree_impl.cc

Project Member

Comment 10 by chromium...@appspot.gserviceaccount.com, Sep 22 2016

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "TextureLayerMailboxIsActivatedDuringCommit.RunMultiThread_DelegatingRenderer". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkxUZXh0dXJlTGF5ZXJNYWlsYm94SXNBY3RpdmF0ZWREdXJpbmdDb21taXQuUnVuTXVsdGlUaHJlYWRfRGVsZWdhdGluZ1JlbmRlcmVyDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
The errors in comment #10 are the same as in comment #6.
Project Member

Comment 12 by chromium...@appspot.gserviceaccount.com, Sep 23 2016

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "TextureLayerMailboxIsActivatedDuringCommit.RunMultiThread_DelegatingRenderer". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkxUZXh0dXJlTGF5ZXJNYWlsYm94SXNBY3RpdmF0ZWREdXJpbmdDb21taXQuUnVuTXVsdGlUaHJlYWRfRGVsZWdhdGluZ1JlbmRlcmVyDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Project Member

Comment 13 by chromium...@appspot.gserviceaccount.com, Sep 27 2016

Detected 3 new flakes for test/step "TextureLayerMailboxIsActivatedDuringCommit.RunMultiThread_DelegatingRenderer". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkxUZXh0dXJlTGF5ZXJNYWlsYm94SXNBY3RpdmF0ZWREdXJpbmdDb21taXQuUnVuTXVsdGlUaHJlYWRfRGVsZWdhdGluZ1JlbmRlcmVyDA. This message was posted automatically by the chromium-try-flakes app.
Project Member

Comment 14 by chromium...@appspot.gserviceaccount.com, Sep 28 2016

Detected 4 new flakes for test/step "TextureLayerMailboxIsActivatedDuringCommit.RunMultiThread_DelegatingRenderer". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyVwsSBUZsYWtlIkxUZXh0dXJlTGF5ZXJNYWlsYm94SXNBY3RpdmF0ZWREdXJpbmdDb21taXQuUnVuTXVsdGlUaHJlYWRfRGVsZWdhdGluZ1JlbmRlcmVyDA. This message was posted automatically by the chromium-try-flakes app.
Labels: -Sheriff-Chromium
I'm landing a test disable for Linux here: https://codereview.chromium.org/2378953002/.
Project Member

Comment 16 by bugdroid1@chromium.org, Sep 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f41fd0f8213b37aa19f8e0cc8fe48287afa73303

commit f41fd0f8213b37aa19f8e0cc8fe48287afa73303
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Sep 29 00:20:39 2016

Disable TextLayerMailboxIsActivatedDuringCommit.* on Linux

BUG= 641613 
TBR=danakj@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2378953002
Cr-Commit-Position: refs/heads/master@{#421693}

[modify] https://crrev.com/f41fd0f8213b37aa19f8e0cc8fe48287afa73303/cc/layers/texture_layer_unittest.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0834fe043155e4fa29304939380d5b90a3ad3658

commit 0834fe043155e4fa29304939380d5b90a3ad3658
Author: samans <samans@chromium.org>
Date: Fri Mar 03 17:03:22 2017

Fixing flakiness of TextureLayerMailboxIsActivatedDuringCommit

BUG= 641613 , 696203 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2729183002
Cr-Commit-Position: refs/heads/master@{#454599}

[modify] https://crrev.com/0834fe043155e4fa29304939380d5b90a3ad3658/cc/layers/texture_layer_unittest.cc

Cc: samans@chromium.org
Cc: danakj@chromium.org
Owner: samans@chromium.org
Thanks for fixing this samans@
Status: Fixed (was: Assigned)

Sign in to add a comment