Screencast.

Deleted: line-numbers-rietveld.mov 17.3 MB

line-numbers-rietveld.mov 17.3 MB Download

Note: this happens with any other range I click on in the file, not just that one.

Also, I just checked, and the content that is inserted comes from the wrong line numbers (629 in my example).

Yeah this is an old bug, the API that rietveld provides for doing content expansion is actually just HTML that the server renders, parses as HTML in python, then transforms into JSON. To insert the context into the Polymer UI I have to them map the lines (which are not source lines, but *UI lines from the old UI* into the line numbers shown in the new UI which map to real source numbers).

I think this is pretty rare, I wouldn't say it's "unreliable" most of the time :P

I'll see if I have some time to figure out if this is something that's fixable. :)

> I think this is pretty rare

That would be reassuring. But how can I tell when it does strike?
It's important that context expansion gives me the right result every time it appears to work, or I won't want to trust it.

For what it's worth, context expansion in the Polymer Rietveld UI is now completely broken for me

I'm being paranoid and switching to the deprecated UI and back in order to avoid missing stuff.

lgarron@ - can we put you on the list to be an early polygerrit dogfooder?  I think that is the best answer I can give you right now.

Please! :-)

lgarron@: You're already on the list as the point-of-contact for getting the //net/http directory using PolyGerrit once it is ready for src.git. Are there other subdirectories you'd like to bring over early as well?

The switch to gerrit means the polymer UI is no longer relevant.