New issue
Advanced search Search tips

Issue 641611 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

JIT Flash Fetch on Linux has confusing output

Project Member Reported by waff...@chromium.org, Aug 26 2016

Issue description

(1) Fresh install/build of Linux Google Chrome.
(2) Navigate to http://www.adobe.com/software/flash/about/
Expected: plugin placeholder says "Downloading" and then is replaced with something meaningful.
Actual: plugin placeholder says "Downloading" forever.

(Note: If the download fails, the placeholder will say that instead.)

On most platforms, once the download completes successfully we replace it with the content. However, because we cannot load Flash without restarting the browser, the plugin fails to load on Linux.

In the short term, we should have text that says something along the lines of "restart Chrome to run Flash".

There is a related issue in that subsequent navigations that attempt to find Flash will result in "download failed" because the component updater states ComponentNotUpdated. These placeholders should also say "restart Chrome to run Flash".

 
Cc: kerrnel@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7759f75a134bfb7e94c984488916423e0cf6ebf

commit e7759f75a134bfb7e94c984488916423e0cf6ebf
Author: waffles <waffles@chromium.org>
Date: Mon Oct 10 23:41:25 2016

Implement restart-required message on Linux.

When a plugin (Flash) can't be found in the registered plugins list, but
the component updater says it knows about and has an implementation of
that plugin, give a "restart required" message on Linux.

If the plugin is disabled because it is out of date, this flow is not
triggered - the browser instead displays "Couldn't load plugin". (This
existing behavior is not modified by this changelist.)

BUG= 641611 

Review-Url: https://codereview.chromium.org/2370923005
Cr-Commit-Position: refs/heads/master@{#424288}

[modify] https://crrev.com/e7759f75a134bfb7e94c984488916423e0cf6ebf/chrome/app/chromium_strings.grd
[modify] https://crrev.com/e7759f75a134bfb7e94c984488916423e0cf6ebf/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/e7759f75a134bfb7e94c984488916423e0cf6ebf/chrome/browser/plugins/plugin_info_message_filter.cc
[modify] https://crrev.com/e7759f75a134bfb7e94c984488916423e0cf6ebf/chrome/common/render_messages.h
[modify] https://crrev.com/e7759f75a134bfb7e94c984488916423e0cf6ebf/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/e7759f75a134bfb7e94c984488916423e0cf6ebf/components/component_updater/component_updater_service.cc
[modify] https://crrev.com/e7759f75a134bfb7e94c984488916423e0cf6ebf/components/component_updater/component_updater_service.h

Status: Fixed (was: Assigned)

Sign in to add a comment