New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641609 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 640685



Sign in to add a comment

Quick view arrow buttons are confusing in List View

Project Member Reported by dhadd...@chromium.org, Aug 26 2016

Issue description

M54 | Samus | 8743.0.0

Open Files app with 10 files (in list view)
Click the first file 
Press space key to open Quick View
Press down arrow 

I expect to be able to press the up and down arrows since the files are in a list. 
 
Blocking: 640685
This is currently working as spec'd, but adding to the Quick View enhancements launch to review the existing behavior.
Labels: -m-54
Cc: -rookrishna@chromium.org mcirimele@chromium.org
Labels: -Pri-2 M-63 Pri-3
Owner: weifangsun@chromium.org
I'd like to lift this as a PE candidate for M63.

Files most commonly previewed are likely images (and won't need scrolling with arrows). I suggest we change this so up/down arrows step through the list of files instead of right/left arrows.  
Labels: -M-63 M-64

Comment 5 by oka@chromium.org, Sep 25 2017

I'm not sure we should do this change.
- Google docs's preview moves between files with left and right arrow keys. Up, down keys are used to scroll.
- As I tested on Quick View, we can scroll a large text preview with Up and Down keys.

Comment 6 by fukino@chromium.org, Oct 18 2017

The preview in macOS finder uses UP and DOWN to change the file. (and UP,DOWN,LEFT,and RIGHT in grid view).
This behavior also makes sense to me.

Comment 7 by oka@chromium.org, Oct 30 2017

Thank you for your feedback. It makes sense to me.
How about keeping LEFT/RIGHT key behaviors in list mode and making UP/DOWN also change the selection?
Labels: -M-64 M-65
Labels: -M-65 M-66
Labels: Hotlist-GoodFirstBug
Re:#7 STGM!
Owner: sashab@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12fbef44e88171f835bac490cf3705dc2e752c63

commit 12fbef44e88171f835bac490cf3705dc2e752c63
Author: Sasha Morrissey <sashab@chromium.org>
Date: Tue Feb 13 08:09:56 2018

Make left/right arrows also navigate between files in CrOS QuickView

Make left/right arrows also navigate between files as well as up/down
arrows in ChromeOS QuickView in the file manager.

Also fixes an unrelated presubmit check to do with polymer selectors.

arrows and test they go to the previous and next files, respectively.

Bug:  641609 
Test: Open a file in quick view (space), then use the left and right
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Icf66ce41370b88a5aa9cee0387347213f72ff66c
Reviewed-on: https://chromium-review.googlesource.com/907991
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536286}
[modify] https://crrev.com/12fbef44e88171f835bac490cf3705dc2e752c63/ui/file_manager/file_manager/foreground/js/quick_view_controller.js

Status: Fixed (was: Assigned)
Labels: CrOS-FilesApp-QuickView
<files-triage>
Status: Verified (was: Fixed)
Chrome OS 10431.0.0, 66.0.3352.0

Sign in to add a comment