New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641591 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 606522



Sign in to add a comment

The "Screen lock" dialog should receive focus when it is shown

Project Member Reported by xiaoyinh@chromium.org, Aug 26 2016

Issue description

Review comments from accessbility reveiw:

The "Screen lock" dialog should receive focus when it is shown,
user should not be able to move focus outside of dialog until it is closed.

When using tab to navigate the focus, tab will escape to other elements that are outside the screen lock dialog.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52a7b63c62cead577ede092be908b7027e45e3cd

commit 52a7b63c62cead577ede092be908b7027e45e3cd
Author: xiaoyinh <xiaoyinh@chromium.org>
Date: Tue Aug 30 04:13:53 2016

A11y improvements for quick unlock settings

1. Make screen lock element tab reachable
2. Add a button on the overlay
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

BUG= 641591 

Review-Url: https://codereview.chromium.org/2280253002
Cr-Commit-Position: refs/heads/master@{#415080}

[modify] https://crrev.com/52a7b63c62cead577ede092be908b7027e45e3cd/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.html
[modify] https://crrev.com/52a7b63c62cead577ede092be908b7027e45e3cd/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js

Labels: Merge-Request-54
Status: Fixed (was: Assigned)
Status: Started (was: Fixed)
This fix need to be merged to M54. Remove status "Fixed" to avoid confusion.

Comment 5 by dimu@chromium.org, Aug 31 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 31 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b7ad919aaa66eaa134f3dd95e26215a09202fe0

commit 1b7ad919aaa66eaa134f3dd95e26215a09202fe0
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Aug 31 17:42:53 2016

A11y improvements for quick unlock settings

1. Make screen lock element tab reachable
2. Add a button on the overlay
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

BUG= 641591 

Review-Url: https://codereview.chromium.org/2280253002
Cr-Commit-Position: refs/heads/master@{#415080}
(cherry picked from commit 52a7b63c62cead577ede092be908b7027e45e3cd)

Review URL: https://codereview.chromium.org/2302503002 .

Cr-Commit-Position: refs/branch-heads/2840@{#73}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/1b7ad919aaa66eaa134f3dd95e26215a09202fe0/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.html
[modify] https://crrev.com/1b7ad919aaa66eaa134f3dd95e26215a09202fe0/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js

Status: Fixed (was: Started)

Comment 8 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b7ad919aaa66eaa134f3dd95e26215a09202fe0

commit 1b7ad919aaa66eaa134f3dd95e26215a09202fe0
Author: Jacob Dufault <jdufault@google.com>
Date: Wed Aug 31 17:42:53 2016

A11y improvements for quick unlock settings

1. Make screen lock element tab reachable
2. Add a button on the overlay
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

BUG= 641591 

Review-Url: https://codereview.chromium.org/2280253002
Cr-Commit-Position: refs/heads/master@{#415080}
(cherry picked from commit 52a7b63c62cead577ede092be908b7027e45e3cd)

Review URL: https://codereview.chromium.org/2302503002 .

Cr-Commit-Position: refs/branch-heads/2840@{#73}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/1b7ad919aaa66eaa134f3dd95e26215a09202fe0/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.html
[modify] https://crrev.com/1b7ad919aaa66eaa134f3dd95e26215a09202fe0/chrome/browser/resources/options/chromeos/quick_unlock_configure_overlay.js

Comment 10 by dchan@google.com, Nov 19 2016

Labels: VerifyIn-56

Comment 11 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 12 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 13 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 14 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 16 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment