Resume offline page download doesn't seem to work |
||||||||||
Issue descriptionI can reproduce this on a kitkat nexus4 To repro, Go to cnn.com, as it takes longer for the page to load. While page is loading, click the download button from menu, and from notification, click pause then resume. Resume takes forever to finish.
,
Aug 26 2016
ok, it is just taking really long to finish. closing this now
,
Aug 26 2016
I am not sure if this is a repro: 1. go to cnn.com, click download button from menu. 2. Swipe chrome away from the recent apps drawer. 3. click the resume button to resume download. After about half an hour the download is still ongoing.
,
Aug 30 2016
,
Sep 2 2016
I tested this a little bit. To make it repro I need to choose to save page later, as it is still loading, or when offline (using async loading feature). What I do is: 3. go offline 4. select a link to download later 5. swipe chrome away 6. go online 7. hit resume Expected: Download happens, notification is updated Actual: download happens, notification is not updated, just lingers on the screen
,
Sep 2 2016
I was just able to log events that happen: (1) this is where the download is requested: 09-02 13:33:21.333: W/chromium(14870): [WARNING:download_notifying_observer.cc(37)] @@@@@@ download notifying observer initialized 09-02 13:33:21.380: W/chromium(14870): [WARNING:download_notifying_observer.cc(49)] @@@@@@ On added called. https://en.m.wikipedia.org/wiki/Academy_of_Motion_Picture_Arts_and_Sciences, 17da8762-9364-474b-9679-35ccc2435ecb (2) This is where Chrome is swiped away, and then resume clicked: 09-02 13:33:28.918: W/chromium(15575): [WARNING:download_notifying_observer.cc(37)] @@@@@@ download notifying observer initialized download was resumed: 09-02 13:33:28.949: W/chromium(15575): [WARNING:download_notifying_observer.cc(58)] @@@@@@ On changed called. https://en.m.wikipedia.org/wiki/Academy_of_Motion_Picture_Arts_and_Sciences, 17da8762-9364-474b-9679-35ccc2435ecb download was completed: 09-02 13:33:34.580: W/chromium(15575): [WARNING:download_notifying_observer.cc(70)] @@@@@@ On completed called. https://en.m.wikipedia.org/wiki/Academy_of_Motion_Picture_Arts_and_Sciences, 17da8762-9364-474b-9679-35ccc2435ecb For some reason the last notification does not get to the UI. Because handling of resume button sets the progress to in progress, I suspect both messages are actually dropped before they get to DownloadNotificationService, or within the notification. I'll keep digging.
,
Sep 2 2016
I suspect that after Chrome restart, we don't yet have DownloadManagerService, therefor hasDownloadManagerService returns false, which fails to provide a notifier for OfflinePageNotificationBridge.
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bae90340ad5e6a7aabe02213d7237c77a1ca6a1d commit bae90340ad5e6a7aabe02213d7237c77a1ca6a1d Author: fgorski <fgorski@chromium.org> Date: Fri Sep 02 22:22:18 2016 [Offline pages] Ensure that download notifications are updated after restart of Chrome * This patch removes checks for DownloadManagementService to be initialized, as it might not have been right after a restart of Chrome. BUG= 641590 R=qinmin@chromium.org Review-Url: https://codereview.chromium.org/2302423003 Cr-Commit-Position: refs/heads/master@{#416366} [modify] https://crrev.com/bae90340ad5e6a7aabe02213d7237c77a1ca6a1d/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java
,
Sep 2 2016
,
Sep 2 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 2 2016
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c5993368edd5f48b071980f9e80d9755a777dc6 commit 8c5993368edd5f48b071980f9e80d9755a777dc6 Author: Filip Gorski <fgorski@chromium.org> Date: Fri Sep 02 23:35:15 2016 [Offline pages] Ensure that download notifications are updated after restart of Chrome * This patch removes checks for DownloadManagementService to be initialized, as it might not have been right after a restart of Chrome. BUG= 641590 R=qinmin@chromium.org Review-Url: https://codereview.chromium.org/2302423003 Cr-Commit-Position: refs/heads/master@{#416366} (cherry picked from commit bae90340ad5e6a7aabe02213d7237c77a1ca6a1d) Review URL: https://codereview.chromium.org/2308923002 . Cr-Commit-Position: refs/branch-heads/2840@{#137} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/8c5993368edd5f48b071980f9e80d9755a777dc6/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c5993368edd5f48b071980f9e80d9755a777dc6 commit 8c5993368edd5f48b071980f9e80d9755a777dc6 Author: Filip Gorski <fgorski@chromium.org> Date: Fri Sep 02 23:35:15 2016 [Offline pages] Ensure that download notifications are updated after restart of Chrome * This patch removes checks for DownloadManagementService to be initialized, as it might not have been right after a restart of Chrome. BUG= 641590 R=qinmin@chromium.org Review-Url: https://codereview.chromium.org/2302423003 Cr-Commit-Position: refs/heads/master@{#416366} (cherry picked from commit bae90340ad5e6a7aabe02213d7237c77a1ca6a1d) Review URL: https://codereview.chromium.org/2308923002 . Cr-Commit-Position: refs/branch-heads/2840@{#137} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/8c5993368edd5f48b071980f9e80d9755a777dc6/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by qin...@chromium.org
, Aug 26 2016