Quick View: Cannot toggle out of quick view after closing side pane |
||||||||
Issue descriptionM54 | samus | 8743.0.0 Open Files app Select image file Press space Click File info button to dismiss side pane Press space again This starts toggling the side pane in and out instead of getting me out of quick view
,
Aug 29 2016
,
Sep 1 2016
,
Sep 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8f31d60b1c0895387266a24d63c3d44f5df97ea5 commit 8f31d60b1c0895387266a24d63c3d44f5df97ea5 Author: oka <oka@chromium.org> Date: Fri Sep 02 01:20:52 2016 Quick View: avoid to lose focus when metadata button is clicked. BUG= 641587 TEST=manually tested. 1. Click -> Space closes Quick View. 2. Move the focus to the button with tab -> Space -> Space closes Quick View. Review-Url: https://codereview.chromium.org/2305563002 Cr-Commit-Position: refs/heads/master@{#416152} [modify] https://crrev.com/8f31d60b1c0895387266a24d63c3d44f5df97ea5/ui/file_manager/file_manager/foreground/elements/files_quick_view.html [modify] https://crrev.com/8f31d60b1c0895387266a24d63c3d44f5df97ea5/ui/file_manager/file_manager/foreground/elements/files_quick_view.js
,
Sep 2 2016
,
Sep 8 2016
Merge request: I'd like to merge #c4 to M54.
,
Sep 8 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d28aae1c305384437514c55dd2896d248891d12 commit 9d28aae1c305384437514c55dd2896d248891d12 Author: Keigo Oka <oka@chromium.org> Date: Fri Sep 09 00:52:31 2016 Quick View: avoid to lose focus when metadata button is clicked. BUG= 641587 TEST=manually tested. 1. Click -> Space closes Quick View. 2. Move the focus to the button with tab -> Space -> Space closes Quick View. Review-Url: https://codereview.chromium.org/2305563002 Cr-Commit-Position: refs/heads/master@{#416152} (cherry picked from commit 8f31d60b1c0895387266a24d63c3d44f5df97ea5) Review URL: https://codereview.chromium.org/2324993002 . Cr-Commit-Position: refs/branch-heads/2840@{#262} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/9d28aae1c305384437514c55dd2896d248891d12/ui/file_manager/file_manager/foreground/elements/files_quick_view.html [modify] https://crrev.com/9d28aae1c305384437514c55dd2896d248891d12/ui/file_manager/file_manager/foreground/elements/files_quick_view.js
,
Oct 11 2016
Verified on ChromeOS 8743.57.0 / 54.0.2840.51
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d28aae1c305384437514c55dd2896d248891d12 commit 9d28aae1c305384437514c55dd2896d248891d12 Author: Keigo Oka <oka@chromium.org> Date: Fri Sep 09 00:52:31 2016 Quick View: avoid to lose focus when metadata button is clicked. BUG= 641587 TEST=manually tested. 1. Click -> Space closes Quick View. 2. Move the focus to the button with tab -> Space -> Space closes Quick View. Review-Url: https://codereview.chromium.org/2305563002 Cr-Commit-Position: refs/heads/master@{#416152} (cherry picked from commit 8f31d60b1c0895387266a24d63c3d44f5df97ea5) Review URL: https://codereview.chromium.org/2324993002 . Cr-Commit-Position: refs/branch-heads/2840@{#262} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/9d28aae1c305384437514c55dd2896d248891d12/ui/file_manager/file_manager/foreground/elements/files_quick_view.html [modify] https://crrev.com/9d28aae1c305384437514c55dd2896d248891d12/ui/file_manager/file_manager/foreground/elements/files_quick_view.js |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by oka@chromium.org
, Aug 29 2016Summary: Quick View: Cannot toggle out of quick view after closing side pane (was: Cannot toggle out of quick view after closing side pane)