New issue
Advanced search Search tips

Issue 641576 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Remove offline URL

Project Member Reported by jianli@chromium.org, Aug 26 2016

Issue description

Offline URL is not longer needed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bca15e7888f8e412329fb014079190eebfde9915

commit bca15e7888f8e412329fb014079190eebfde9915
Author: jianli <jianli@chromium.org>
Date: Wed Oct 05 21:30:55 2016

Remove OfflineURL from offline page since the concept of offline file URL is deprecated

BUG= 641576 

Review-Url: https://codereview.chromium.org/2284933002
Cr-Commit-Position: refs/heads/master@{#423299}

[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageItem.java
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeUnitTest.java
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/android/offline_pages/offline_page_bridge.h
[delete] https://crrev.com/8434b579f8ececab58243e97b1ab758b671cccd0/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/android/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/android/offline_pages/offline_page_utils.h
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/downloads/download_ui_adapter.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/downloads/download_ui_adapter.h
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/offline_page_item.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/offline_page_item.h
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/offline_page_model.h
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/offline_page_model_impl.h
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/offline_page_model_impl_unittest.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/stub_offline_page_model.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/stub_offline_page_model.h

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bca15e7888f8e412329fb014079190eebfde9915

commit bca15e7888f8e412329fb014079190eebfde9915
Author: jianli <jianli@chromium.org>
Date: Wed Oct 05 21:30:55 2016

Remove OfflineURL from offline page since the concept of offline file URL is deprecated

BUG= 641576 

Review-Url: https://codereview.chromium.org/2284933002
Cr-Commit-Position: refs/heads/master@{#423299}

[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageItem.java
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/android/junit/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeUnitTest.java
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/android/offline_pages/offline_page_bridge.h
[delete] https://crrev.com/8434b579f8ececab58243e97b1ab758b671cccd0/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/android/offline_pages/offline_page_utils.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/android/offline_pages/offline_page_utils.h
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/android/tab_android.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider_unittest.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/downloads/download_ui_adapter.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/downloads/download_ui_adapter.h
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/offline_page_item.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/offline_page_item.h
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/offline_page_model.h
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/offline_page_model_impl.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/offline_page_model_impl.h
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/offline_page_model_impl_unittest.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/stub_offline_page_model.cc
[modify] https://crrev.com/bca15e7888f8e412329fb014079190eebfde9915/components/offline_pages/stub_offline_page_model.h

Comment 4 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840

Sign in to add a comment