The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06342c587b4cdedcf484f2660ea915024c6a4d1c

commit 06342c587b4cdedcf484f2660ea915024c6a4d1c
Author: dmazzoni <dmazzoni@chromium.org>
Date: Tue Aug 30 22:27:38 2016

Fix small error in relative bounds calc for Chrome OS only.

The new relative bounds calculation code walks up the hierarchy applying
offsets and transforms to convert from the relative coordinates of one
object to the global screen coordinates.

This was broken for an obscure case where one of the parents of a node has
width and height zero because we were calling ComputeLocalNodeBounds on
every ancestor, when it was intended to only be called on the node you're
trying to get the bounds of.

BUG= 641574 

Review-Url: https://codereview.chromium.org/2285913002
Cr-Commit-Position: refs/heads/master@{#415461}

[modify] https://crrev.com/06342c587b4cdedcf484f2660ea915024c6a4d1c/chrome/browser/extensions/api/automation/automation_apitest.cc
[modify] https://crrev.com/06342c587b4cdedcf484f2660ea915024c6a4d1c/chrome/renderer/extensions/automation_internal_custom_bindings.cc
[add] https://crrev.com/06342c587b4cdedcf484f2660ea915024c6a4d1c/chrome/test/data/extensions/api_test/automation/sites/location2.html
[add] https://crrev.com/06342c587b4cdedcf484f2660ea915024c6a4d1c/chrome/test/data/extensions/api_test/automation/tests/tabs/location2.html
[add] https://crrev.com/06342c587b4cdedcf484f2660ea915024c6a4d1c/chrome/test/data/extensions/api_test/automation/tests/tabs/location2.js

checked on  54.0.2840.44. When i move to login page , and navigate in the login page, i can a focus on the password field but the orange focus is not seen. Please see the attached screenshot

Deleted: IMG_1940.JPG 1.3 MB

	IMG_1940.JPG 1.3 MB View Download

Let us track the UI showing the selection in https://bugs.chromium.org/p/chromium/issues/detail?id=641574 instead of here, I suspect these are going to be the same root cause.

Sorry, the bug for the ui selection is 651379

checked on 8743.65.0 / 54.0.2840.59 ,in the login page the orange is at different place only when focus is on password field. On other elements the orange highlight woks fine.

Deleted: IMG_2071.JPG 2.0 MB

	IMG_2071.JPG 2.0 MB View Download

Was this seen in previous M54 Beta?

Dominic, can you confirm if this is dup of  issue 651379 ?

651379 is about keyboard focus highlighting (thin blue outline).  This is about the ChromeVox orange focus ring.  I suspect they are unrelated.

Dominic, did you close this because you think it's fixed (we just reproduced in latest M54) or because it's fixed in later builds?

I also don't think the bug as-is needs to block Stable.  Please re-add the label if you disagree.

Katherine, I believe this is fixed in M55, please verify and let me know if not.

It was fixed as a side-effect of a major rewrite of the code to compute the bounds of accessible objects that was finished in M55, so I can't merge it to M54. If we can live with it in M54, let's mark it as fixed and move on.

If you see any highlighting that's wrong in M55 or higher, I definitely want to fix it and merge it because the code is a lot cleaner now and it's supposed to be taking care of all of the corner cases that were missed before.

The only issue left is when the object that gets focus moves or animates. I'm aware of that issue but if it fixes itself if you move focus away and re-focus then I think it's a lower priority - but I do hope to fix those cases too.

verified on 55.0.2883.25 / 8872.22.0

[Auto-generated comment by a script] We noticed that this issue is targeted for M-55; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-55 label, otherwise remove Merge-TBD label. Thanks.