New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641551 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Undefined-shift in CPDF_PSEngine::DoOperator

Project Member Reported by ClusterFuzz, Aug 26 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6438469184520192

Fuzzer: libfuzzer_pdf_psengine_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  CPDF_PSEngine::DoOperator
  CPDF_PSProc::Execute
  _start
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=413192:413325

Minimized Testcase (0.23 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95p8-AwIeKbLkbhOAXELMYzqpOQRhQBbqZd_vJITxjZlVd2i6K-mXzvtUlShzLdL3h0DaQEfqcrpgHAmk75Zsy-4GJHdRx_F1OclZpCMcp0tDolKBrtkGsw-kqVuhTSzB5ejphqixTtLVxQR1RSjSF-umDSPg?testcase_id=6438469184520192

Issue manually filed by: mmoroz

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 26 2016

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6276286807015424

Fuzzer: libfuzzer_pdf_psengine_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  CPDF_PSEngine::DoOperator
  CPDF_PSProc::Execute
  _start
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=413192:413325

Minimized Testcase (0.10 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97AyrqZ66ytyddJ9GiiOSNo1kDW41GszyTR2FUXdvvq0aOg555u8awatymvoUTgp_BfA1DcJ-Nq7v7McED6Vpa-mtZEDkplVUl3Q6z96OtWequsYaAXEyjWSStWO3iEOZ4BGx4kVPq8E0GYgdhnQEQHDhpJZg?testcase_id=6276286807015424

Issue manually filed by: mmoroz

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

Comment 2 by mmoroz@chromium.org, Aug 26 2016

Cc: tsepez@chromium.org mmoroz@chromium.org kcc@chromium.org aizatsky@chromium.org
Components: Internals>Plugins>PDF
Tom, do you want to take this one as well?

Comment 4 by tsepez@chromium.org, Aug 26 2016

Sure.

Comment 5 by tsepez@chromium.org, Aug 26 2016

Owner: tsepez@chromium.org
Status: Assigned (was: Untriaged)

Comment 6 by tsepez@chromium.org, Oct 12 2016

Owner: thestig@chromium.org
Lei, looks like you just fixed a couple of these, want to finish this one off?
Status: Started (was: Assigned)
https://codereview.chromium.org/2414473003
Owner: tsepez@chromium.org
Status: Assigned (was: Started)
This effectively goes back to tsepez since we are going to implement proper shift checking in the safe math library.
Project Member

Comment 9 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
 Issue 682333  has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15266c12e33354dc8d8b06c1c2ca58513ae31080

commit 15266c12e33354dc8d8b06c1c2ca58513ae31080
Author: pdfium-deps-roller <pdfium-deps-roller@chromium.org>
Date: Tue Jan 24 21:28:16 2017

Roll src/third_party/pdfium/ 8804940c9..6e162b54f (5 commits).

https://pdfium.googlesource.com/pdfium.git/+log/8804940c9a39..6e162b54f708

$ git log 8804940c9..6e162b54f --date=short --no-merges --format='%ad %ae %s'
2017-01-24 dsinclair Fixup coverage build
2017-01-24 halcanary No need to define SK_SCALAR_IS_FLOAT
2017-01-24 tsepez Replace some loose (ptr, len) pairs with CFX_ByteStringC in fpdfapi.
2017-01-19 agable Make Gerrit the default for pdfium code reviews
2017-01-24 tsepez Undefined shift in CPDF_PSEngine::DoOperator

BUG= 665583 , 641551 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2654623003
Cr-Commit-Position: refs/heads/master@{#445821}

[modify] https://crrev.com/15266c12e33354dc8d8b06c1c2ca58513ae31080/DEPS

Project Member

Comment 13 by ClusterFuzz, Jan 25 2017

ClusterFuzz has detected this issue as fixed in range 445740:445846.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6438469184520192

Fuzzer: libfuzzer_pdf_psengine_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Undefined-shift
Crash Address: 
Crash State:
  CPDF_PSEngine::DoOperator
  CPDF_PSProc::Execute
  _start
  
Sanitizer: undefined (UBSAN)

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=413192:413325
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=445740:445846

Minimized Testcase (0.23 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95p8-AwIeKbLkbhOAXELMYzqpOQRhQBbqZd_vJITxjZlVd2i6K-mXzvtUlShzLdL3h0DaQEfqcrpgHAmk75Zsy-4GJHdRx_F1OclZpCMcp0tDolKBrtkGsw-kqVuhTSzB5ejphqixTtLVxQR1RSjSF-umDSPg?testcase_id=6438469184520192

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 14 by ClusterFuzz, Jan 25 2017

ClusterFuzz has detected this issue as fixed in range 445740:445846.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6276286807015424

Fuzzer: libfuzzer_pdf_psengine_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: Integer-overflow
Crash Address: 
Crash State:
  CPDF_PSEngine::DoOperator
  CPDF_PSProc::Execute
  _start
  
Sanitizer: undefined (UBSAN)

Regressed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=413192:413325
Fixed: https://cluster-fuzz.appspot.com/revisions?job=libfuzzer_chrome_ubsan&range=445740:445846

Minimized Testcase (0.10 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97AyrqZ66ytyddJ9GiiOSNo1kDW41GszyTR2FUXdvvq0aOg555u8awatymvoUTgp_BfA1DcJ-Nq7v7McED6Vpa-mtZEDkplVUl3Q6z96OtWequsYaAXEyjWSStWO3iEOZ4BGx4kVPq8E0GYgdhnQEQHDhpJZg?testcase_id=6276286807015424

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reproducing.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.

Sign in to add a comment