New issue
Advanced search Search tips

Issue 641550 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Nov 2016
Cc:
seanmccullough@chromium.org
martiniss@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Actually parse the Alerts JSON on the server

Project Member Reported by seanmccullough@google.com, Aug 26 2016 
We don't have to actually put the Alerts messages into the datastore in addition to the raw json bytes, but we should at least verify that the alerts format still parses according to what the current Sheriff-o-Matic was built with.

Then log metric counts for alerts json parse errors, and add monitoring to alert on spikes.

Comment 1 by martiniss@chromium.org, Aug 26 2016

Owner: martiniss@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 28 2016

Labels: Hotlist-Google

Comment 3 by benhenry@chromium.org, Sep 1 2016

Labels: Type-Bug

Comment 4 by zhangtiff@google.com, Oct 5 2016

Labels: -Milestone-SoMNGFollowUp Milestone-Reliability

Comment 5 by aga...@chromium.org, Nov 22 2016

Labels: -Infra-DX

Comment 6 by martiniss@chromium.org, Nov 29 2016

Owner: ----
Status: Available (was: Assigned)
Sean, is there a bug we can merge this into? Or close in favor of?

Comment 7 by seanmccullough@chromium.org, Nov 29 2016

Status: Fixed (was: Available)
We can close this since it's implemented :) It returns http.StatusBadRequest if it can't json.Unmarshal the blob into a messages.AlertsSummary struct:

https://chromium.googlesource.com/infra/infra/+/master/go/src/infra/appengine/sheriff-o-matic/som/alerts.go#93

Elevated 400s will be visible to monarch, alertmanager etc.
►

Sign in to add a comment