New issue
Advanced search Search tips

Issue 641547 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

better client-side error reporting

Project Member Reported by seanmccullough@google.com, Aug 26 2016

Issue description

Sheriff-o-Matic's client-side errors should be collected and monitored so that we can detect spikes in javascript errors from end users.
 
Labels: -Milestone-SoMFollowUp Milestone-SoMNGFollowUp
Hooking into window.onerror might be a good starting point:

https://mikewest.org/2013/08/debugging-runtime-errors-with-window-onerror


Project Member

Comment 3 by sheriffbot@chromium.org, Aug 28 2016

Labels: Hotlist-Google
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/5d1917dc6ae5959593693fd3949d0cc338d31ac1

commit 5d1917dc6ae5959593693fd3949d0cc338d31ac1
Author: Sean McCullough <seanmccullough@chromium.org>
Date: Mon Aug 29 19:26:43 2016

[som] Add very basic client side JS error reporting.

Hooks into window.onerror to fire on any uncaught JS error. Note this
doesn't do anything for errors which are caught already by JS
application code.

Throttles the POSTs so we don't DDoS ourselves with a bad client push.

The post body contains a JSON map of the error signature (including
stack trace if there was one) to occurrence count.

Server logs the body in error logs so we can inspect further if we
notice errors spiking.

BUG= 641547 

Change-Id: I74f9c5c12b28c959f32852c5ab1fc3b7c5d34765
Reviewed-on: https://chromium-review.googlesource.com/376827
Reviewed-by: Andrew Bonventre <andybons@chromium.org>
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/5d1917dc6ae5959593693fd3949d0cc338d31ac1/go/src/infra/appengine/sheriff-o-matic/app.yaml
[modify] https://crrev.com/5d1917dc6ae5959593693fd3949d0cc338d31ac1/go/src/infra/appengine/sheriff-o-matic/index.html
[modify] https://crrev.com/5d1917dc6ae5959593693fd3949d0cc338d31ac1/go/src/infra/appengine/sheriff-o-matic/main.go
[add] https://crrev.com/5d1917dc6ae5959593693fd3949d0cc338d31ac1/go/src/infra/appengine/sheriff-o-matic/scripts/ecatcher.js

Labels: Type-Bug
Labels: -Milestone-SoMNGFollowUp Milestone-Reliability
Status: Fixed (was: Available)

Sign in to add a comment