New issue
Advanced search Search tips

Issue 641543 link

Starred by 2 users
Status: Fixed
Owner:
donnd@chromium.org
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[TTS] Stop sending the ctxsl_resolve parameter to GWS

Project Member Reported by donnd@chromium.org, Aug 26 2016 
We should remove the obsolete parameter ctxsl_resolve -- it's unused on the server side and always set to 1 on the client.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9fc4d9e6bfd9f673671b2280351ce7ba41dc68d

commit d9fc4d9e6bfd9f673671b2280351ce7ba41dc68d
Author: donnd <donnd@chromium.org>
Date: Fri Sep 16 00:30:49 2016

[TTS] Request Now on Tap data in the Resolve request.

Updates TemplateURL to know how to request Now on Tap data for Contextual Search.
Also remove the old unused flag about whether to resolve or not.

BUG=646664, 641543 

Review-Url: https://codereview.chromium.org/2343523002
Cr-Commit-Position: refs/heads/master@{#419054}

[modify] https://crrev.com/d9fc4d9e6bfd9f673671b2280351ce7ba41dc68d/chrome/browser/android/contextualsearch/contextual_search_delegate.cc
[modify] https://crrev.com/d9fc4d9e6bfd9f673671b2280351ce7ba41dc68d/components/search_engines/template_url.cc
[modify] https://crrev.com/d9fc4d9e6bfd9f673671b2280351ce7ba41dc68d/components/search_engines/template_url.h
[modify] https://crrev.com/d9fc4d9e6bfd9f673671b2280351ce7ba41dc68d/components/search_engines/template_url_unittest.cc

Comment 2 by donnd@chromium.org, Sep 26 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment