New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 641540 link

Starred by 3 users
Status: Fixed
Owner:
█ penny...@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
█ jwd@chromium.org
scottmg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

[install_static] GetCollectStatsConsentImpl not returning early true

Project Member Reported by penny...@chromium.org, Aug 26 2016 
Found by scottmg.

When ReportingIsEnforcedByPolicy(), no longer returning early with true.

Subtle bug introduced in: https://codereview.chromium.org/1841573002/diff/500001/chrome/install_static/install_util.cc

landed in CL: https://chromium.googlesource.com/chromium/src/+/84fd669f74832ccab02fcbb8b96dc4ed58d11b43

Comment 1 by scottmg@chromium.org, Aug 26 2016

Cc: jwd@chromium.org
Found by Jesse and a seemingly-somewhat-regrettable (?) addition of a DCHECK. :)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cacf882777a38c292f82e5b90229bb0b24c9746f

commit cacf882777a38c292f82e5b90229bb0b24c9746f
Author: pennymac <pennymac@chromium.org>
Date: Tue Aug 30 05:53:55 2016

[install_static] GetCollectStatsConsentImpl() not returning true early

...when reporting policy enforced.

R=robertshield@chromium.org
BUG= 641540 

Review-Url: https://codereview.chromium.org/2282143002
Cr-Commit-Position: refs/heads/master@{#415185}

[modify] https://crrev.com/cacf882777a38c292f82e5b90229bb0b24c9746f/chrome/install_static/install_util.cc

Comment 4 by penny...@chromium.org, Aug 30 2016

Status: Fixed (was: Started)
►

Sign in to add a comment