New issue
Advanced search Search tips

Issue 641539 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

boot_test.sh in bisect tools doesn't work.

Project Member Reported by laszio@chromium.org, Aug 26 2016

Issue description

The tool gave three options when the dut failed to boot with the bad image: flash through usb, flash over internet again, skip. Apparently "skip" is the only reasonable choice when testing with boot_test.sh. However, after choosing "skip" the tool raised an exception and broke.


./bisect.py package peach_pit 192.168.1.2 -t cros_pkg/boot_test.sh

...

Pushing built image onto device.
cros flash --board=peach_pit --clobber-stateful 192.168.1.2 ~/trunk/src/build/images/peach_pit/latest/chromiumos_test_image.bin
13:46:18: NOTICE: Preparing to update the remote device 192.168.1.2
13:51:38: NOTICE: Finalizing image.
13:52:29: NOTICE: Update completed.
13:53:22: NOTICE: rebooting device...
13:54:32: NOTICE: Verifying that the device has been updated...
13:54:32: ERROR: Device update failed.
13:54:33: ERROR: cros flash failed before completing.
13:54:33: ERROR: Failed to boot into the new version. Possibly there was a signing problem, or an automated rollback occurred because your new image failed to 
boot.

cros flash has failed! From here you can:
1. Flash through USB
2. Retry flashing over ethernet
3. Abort this installation and skip this image
Which method would you like to do? 3
Traceback (most recent call last):
  File "./bisect.py", line 398, in <module>
    sys.exit(Main(sys.argv[1:]))
  File "./bisect.py", line 393, in Main
    return Run(bisector)
  File "./bisect.py", line 296, in Run
    ret = bisector.Run()
  File "./bisect.py", line 158, in Run
    return binary_search_state.Run(**self.default_kwargs)
  File "/mnt/host/source/src/third_party/toolchain-utils/binary_search_tool/binary_search_state.py", line 557, in Run
    bss.DoVerify()
  File "/mnt/host/source/src/third_party/toolchain-utils/binary_search_tool/binary_search_state.py", line 212, in DoVerify
    assert status == 0, 'When reset_to_bad, test setup should succeed.'
AssertionError: When reset_to_bad, test setup should succeed.

 
Owner: cmt...@chromium.org
Status: Assigned (was: Untriaged)
Caroline, please consult with Ting-Yuan on best way to fix this problem. 
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/toolchain-utils/+/0a6266710aa7133cb8ef105575b8fb9e74f7896d

commit 0a6266710aa7133cb8ef105575b8fb9e74f7896d
Author: Caroline Tice <cmtice@google.com>
Date: Tue Sep 27 17:54:16 2016

Comment 3 by cmt...@chromium.org, Sep 29 2016

Status: Fixed (was: Assigned)

Comment 4 by cmt...@chromium.org, Mar 17 2017

Status: Verified (was: Fixed)

Sign in to add a comment