Working plan as of September 8 is to group the omnibox within the toolbar, ala desktop and mobile. Behavior of the toolbar will be as described above (press app button to show/hide). The toolbar will automatically show during site-to-site transitions, and hide once loading is complete (timing TBD).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59c4b66c37827da7e3853a0d5e8c6947e627c7fa

commit 59c4b66c37827da7e3853a0d5e8c6947e627c7fa
Author: cjgrant <cjgrant@chromium.org>
Date: Thu Oct 20 21:25:13 2016

Implement a means of letting native VR Shell control the HTML UI.

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2434013002
Cr-Commit-Position: refs/heads/master@{#426601}

[modify] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/chrome/browser/android/vr_shell/BUILD.gn
[add] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/chrome/browser/android/vr_shell/ui_interface.cc
[add] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/chrome/browser/android/vr_shell/ui_interface.h
[modify] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/chrome/browser/resources/vr_shell/vr_shell_ui.js
[modify] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc
[modify] https://crrev.com/59c4b66c37827da7e3853a0d5e8c6947e627c7fa/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3a203c74e4caa36d85c2ef70f680449fb295276

commit b3a203c74e4caa36d85c2ef70f680449fb295276
Author: cjgrant <cjgrant@chromium.org>
Date: Thu Oct 20 23:12:48 2016

Control visibility of 2D VR menu buttons using native state.

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2437823002
Cr-Commit-Position: refs/heads/master@{#426639}

[modify] https://crrev.com/b3a203c74e4caa36d85c2ef70f680449fb295276/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/b3a203c74e4caa36d85c2ef70f680449fb295276/chrome/browser/resources/vr_shell/vr_shell_ui.js
[modify] https://crrev.com/b3a203c74e4caa36d85c2ef70f680449fb295276/chrome/browser/resources/vr_shell/vr_shell_ui_api.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc8c1a9376f9a33c9130f78e7beea1038c57431d

commit bc8c1a9376f9a33c9130f78e7beea1038c57431d
Author: cjgrant <cjgrant@chromium.org>
Date: Fri Oct 21 14:38:54 2016

Cut VrShell dependency on WebUi.

Adding the native-to-HTML-UI path caused VrShell to depend on WebUi,
which creates a circular dependency and breaks unit tests.  Fix this.

BUG= 641508 

Review-Url: https://chromiumcodereview.appspot.com/2440823002
Cr-Commit-Position: refs/heads/master@{#426791}

[modify] https://crrev.com/bc8c1a9376f9a33c9130f78e7beea1038c57431d/chrome/browser/android/vr_shell/ui_interface.cc
[modify] https://crrev.com/bc8c1a9376f9a33c9130f78e7beea1038c57431d/chrome/browser/android/vr_shell/ui_interface.h
[modify] https://crrev.com/bc8c1a9376f9a33c9130f78e7beea1038c57431d/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc
[modify] https://crrev.com/bc8c1a9376f9a33c9130f78e7beea1038c57431d/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b00148c7f200318663d4f8cf887427941e94544

commit 5b00148c7f200318663d4f8cf887427941e94544
Author: cjgrant <cjgrant@chromium.org>
Date: Fri Oct 21 15:16:59 2016

Add passive and FOV-locked properties to UI elements.

- Passive implies visible, but ignoring input.
- Field-of-view locked implies that the element is rendered relative to
  the field of view, independent of the head pose.  This lets the HTML
  UI place elements like a HUD.

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2433253002
Cr-Commit-Position: refs/heads/master@{#426796}

[modify] https://crrev.com/5b00148c7f200318663d4f8cf887427941e94544/chrome/browser/android/vr_shell/ui_elements.h
[modify] https://crrev.com/5b00148c7f200318663d4f8cf887427941e94544/chrome/browser/android/vr_shell/ui_scene.cc
[modify] https://crrev.com/5b00148c7f200318663d4f8cf887427941e94544/chrome/browser/android/vr_shell/ui_scene_unittest.cc
[modify] https://crrev.com/5b00148c7f200318663d4f8cf887427941e94544/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/5b00148c7f200318663d4f8cf887427941e94544/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/5b00148c7f200318663d4f8cf887427941e94544/chrome/browser/resources/vr_shell/vr_shell_ui_api.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07570419278e71a3bdaf60b581b18895d13942a7

commit 07570419278e71a3bdaf60b581b18895d13942a7
Author: cjgrant <cjgrant@chromium.org>
Date: Fri Oct 21 21:46:15 2016

Implement (but do not enable) HTML UI-driven WebVR security warnings.

These will be enabled in a follow-on change that adjusts VR shell to
render UI elements whether or not we're in WebVR mode.

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2435623003
Cr-Commit-Position: refs/heads/master@{#426897}

[modify] https://crrev.com/07570419278e71a3bdaf60b581b18895d13942a7/chrome/browser/resources/vr_shell/vr_shell_ui.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cda687ffaf139a991a8a74728b34a36a28e529f6

commit cda687ffaf139a991a8a74728b34a36a28e529f6
Author: cjgrant <cjgrant@chromium.org>
Date: Tue Oct 25 21:34:55 2016

Use the HTML UI to render WebVR warnings

This pulls custom warning rendering code out of the native side, and
uses the HTML UI logic to drive it instead.

BUG= 641508 

Review-Url: https://codereview.chromium.org/2436863002
Cr-Commit-Position: refs/heads/master@{#427484}

[modify] https://crrev.com/cda687ffaf139a991a8a74728b34a36a28e529f6/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/cda687ffaf139a991a8a74728b34a36a28e529f6/chrome/browser/android/vr_shell/vr_shell.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d6a76c7ec3e75766018df88d95deea600c9afee

commit 3d6a76c7ec3e75766018df88d95deea600c9afee
Author: cjgrant <cjgrant@chromium.org>
Date: Wed Oct 26 04:59:09 2016

Control the VrShell content quad via the HTML UI.

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2442873002
Cr-Commit-Position: refs/heads/master@{#427593}

[modify] https://crrev.com/3d6a76c7ec3e75766018df88d95deea600c9afee/chrome/browser/android/vr_shell/ui_elements.h
[modify] https://crrev.com/3d6a76c7ec3e75766018df88d95deea600c9afee/chrome/browser/android/vr_shell/ui_scene.cc
[modify] https://crrev.com/3d6a76c7ec3e75766018df88d95deea600c9afee/chrome/browser/android/vr_shell/ui_scene.h
[modify] https://crrev.com/3d6a76c7ec3e75766018df88d95deea600c9afee/chrome/browser/android/vr_shell/ui_scene_unittest.cc
[modify] https://crrev.com/3d6a76c7ec3e75766018df88d95deea600c9afee/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/3d6a76c7ec3e75766018df88d95deea600c9afee/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/3d6a76c7ec3e75766018df88d95deea600c9afee/chrome/browser/resources/vr_shell/vr_shell_ui.js
[modify] https://crrev.com/3d6a76c7ec3e75766018df88d95deea600c9afee/chrome/browser/resources/vr_shell/vr_shell_ui_api.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0cecd7df4cb20f9c5302d44da3547de4895a521

commit f0cecd7df4cb20f9c5302d44da3547de4895a521
Author: cjgrant <cjgrant@chromium.org>
Date: Sun Oct 30 03:24:05 2016

Provide URL-related info to the VR HTML UI.

This lets UI render a basic URL bar.

BUG= 641508 

Review-Url: https://codereview.chromium.org/2461503002
Cr-Commit-Position: refs/heads/master@{#428621}

[modify] https://crrev.com/f0cecd7df4cb20f9c5302d44da3547de4895a521/chrome/browser/android/vr_shell/BUILD.gn
[modify] https://crrev.com/f0cecd7df4cb20f9c5302d44da3547de4895a521/chrome/browser/android/vr_shell/ui_interface.cc
[modify] https://crrev.com/f0cecd7df4cb20f9c5302d44da3547de4895a521/chrome/browser/android/vr_shell/ui_interface.h
[modify] https://crrev.com/f0cecd7df4cb20f9c5302d44da3547de4895a521/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/f0cecd7df4cb20f9c5302d44da3547de4895a521/chrome/browser/android/vr_shell/vr_shell.h
[add] https://crrev.com/f0cecd7df4cb20f9c5302d44da3547de4895a521/chrome/browser/android/vr_shell/vr_web_contents_observer.cc
[add] https://crrev.com/f0cecd7df4cb20f9c5302d44da3547de4895a521/chrome/browser/android/vr_shell/vr_web_contents_observer.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95c8077faabeac737d9c18169d2916647cb2cc65

commit 95c8077faabeac737d9c18169d2916647cb2cc65
Author: cjgrant <cjgrant@chromium.org>
Date: Thu Nov 10 19:09:34 2016

Add an initial omnibox to HTML UI content.

- It currently displays only the current URL
- It is not interactive
- It needs better styling

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2473443002
Cr-Commit-Position: refs/heads/master@{#431311}

[modify] https://crrev.com/95c8077faabeac737d9c18169d2916647cb2cc65/chrome/browser/resources/vr_shell/vr_shell_ui.css
[modify] https://crrev.com/95c8077faabeac737d9c18169d2916647cb2cc65/chrome/browser/resources/vr_shell/vr_shell_ui.html
[modify] https://crrev.com/95c8077faabeac737d9c18169d2916647cb2cc65/chrome/browser/resources/vr_shell/vr_shell_ui.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5799b40595a08411e54c9a2ee205a524c04568ad

commit 5799b40595a08411e54c9a2ee205a524c04568ad
Author: cjgrant <cjgrant@chromium.org>
Date: Tue Nov 15 00:23:35 2016

Remove fixed positioning of HTML UI elements.

This change lets the UI elements float wherever the browser positions
them.  In summary:

- Use css 'float' to position elements; we can refine this as needed.
- Add a margin around all elements (gets rid of artifacts where edges of
  neighbouring elements appear in the scene).
- Correct the rounding of element "pixel" boundaries, to avoid (for
  example) flattened edges on round buttons.
- Choose the boundaries based on the extremities of the elements
  (including border and padding), rather than their inner width/height.

Also, fix the new omnibox security icon in non-UI-development builds.

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2490313002
Cr-Commit-Position: refs/heads/master@{#432013}

[modify] https://crrev.com/5799b40595a08411e54c9a2ee205a524c04568ad/chrome/browser/resources/vr_shell/vr_shell_ui.css
[modify] https://crrev.com/5799b40595a08411e54c9a2ee205a524c04568ad/chrome/browser/resources/vr_shell/vr_shell_ui.html
[modify] https://crrev.com/5799b40595a08411e54c9a2ee205a524c04568ad/chrome/browser/resources/vr_shell/vr_shell_ui.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc4752355449dc6452ad51d45f534f633abad7f8

commit dc4752355449dc6452ad51d45f534f633abad7f8
Author: cjgrant <cjgrant@chromium.org>
Date: Thu Nov 17 23:12:39 2016

Allow the VR omnibox to be transient.

Let the omnibox appear when its content changes, show for a few seconds,
then fade away.  Any changes to page loading state or the URL extend the
time for which the box stays visible.

This fading behaviour can be disabled by setting the timeout to 0.

Currently, CSS transitions are used to hide and drop the omnibox when it
disappears.  These transitions may appear choppy when content is
loading.  Hence, this change may be a stepping stone towards a
native-driven transition.

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2500283003
Cr-Commit-Position: refs/heads/master@{#433008}

[modify] https://crrev.com/dc4752355449dc6452ad51d45f534f633abad7f8/chrome/browser/resources/vr_shell/vr_shell_ui.css
[modify] https://crrev.com/dc4752355449dc6452ad51d45f534f633abad7f8/chrome/browser/resources/vr_shell/vr_shell_ui.html
[modify] https://crrev.com/dc4752355449dc6452ad51d45f534f633abad7f8/chrome/browser/resources/vr_shell/vr_shell_ui.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a38ed6430b5688221a944d9994cc2231405a7360

commit a38ed6430b5688221a944d9994cc2231405a7360
Author: cjgrant <cjgrant@chromium.org>
Date: Tue Nov 29 16:18:20 2016

Make Omnibox stay visible during long page loads.

The omnibox visibility timer should not be active during a page load; it
should be started only after loading finishes.

BUG= 641508 
TEST=Viewed a page that takes 10s to load; omnibox stays visible.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2534963002
Cr-Commit-Position: refs/heads/master@{#435007}

[modify] https://crrev.com/a38ed6430b5688221a944d9994cc2231405a7360/chrome/browser/resources/vr_shell/vr_shell_ui.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/340d1da550dbf8290c7da82add22af59b0fa47e4

commit 340d1da550dbf8290c7da82add22af59b0fa47e4
Author: cjgrant <cjgrant@chromium.org>
Date: Wed Dec 07 16:24:05 2016

Omnibox improvements and fixes.

- Show the correct security icon on the omnibar when out of WebVR.  This
  change uses the tab's security level to determine whether the security
  warnings are shown, rather than the secure origin flag that was
  plumbed through the WebVR code path.
- Keep the omnibox visible at all times in 2D browsing.
- Take URLs only from the main frame on a page.

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2536223002
Cr-Commit-Position: refs/heads/master@{#436974}

[modify] https://crrev.com/340d1da550dbf8290c7da82add22af59b0fa47e4/chrome/browser/android/vr_shell/BUILD.gn
[modify] https://crrev.com/340d1da550dbf8290c7da82add22af59b0fa47e4/chrome/browser/android/vr_shell/ui_interface.cc
[modify] https://crrev.com/340d1da550dbf8290c7da82add22af59b0fa47e4/chrome/browser/android/vr_shell/ui_interface.h
[modify] https://crrev.com/340d1da550dbf8290c7da82add22af59b0fa47e4/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/340d1da550dbf8290c7da82add22af59b0fa47e4/chrome/browser/android/vr_shell/vr_web_contents_observer.cc
[modify] https://crrev.com/340d1da550dbf8290c7da82add22af59b0fa47e4/chrome/browser/android/vr_shell/vr_web_contents_observer.h
[modify] https://crrev.com/340d1da550dbf8290c7da82add22af59b0fa47e4/chrome/browser/resources/vr_shell/vr_shell_ui.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d2397c4a60454a20ddc189d5966c72c63b551e8

commit 7d2397c4a60454a20ddc189d5966c72c63b551e8
Author: cjgrant <cjgrant@chromium.org>
Date: Thu Dec 08 21:30:00 2016

Wire the VR omnibox directly to visible security state changes.

Rather than querying for security state changes on navigation events,
let WebContentsObserver trigger observers on a state change.

BUG= 641508 

Review-Url: https://codereview.chromium.org/2556963006
Cr-Commit-Position: refs/heads/master@{#437348}

[modify] https://crrev.com/7d2397c4a60454a20ddc189d5966c72c63b551e8/chrome/browser/android/vr_shell/vr_web_contents_observer.cc
[modify] https://crrev.com/7d2397c4a60454a20ddc189d5966c72c63b551e8/chrome/browser/android/vr_shell/vr_web_contents_observer.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d1d727a5e0aad78d6151820c8b3ae4d6616cf56

commit 6d1d727a5e0aad78d6151820c8b3ae4d6616cf56
Author: cjgrant <cjgrant@chromium.org>
Date: Fri Dec 09 21:16:57 2016

Generalize WebContentsObserver::SecurityStyleChanged.

This will put the onus on individual observers to extract the security
information they require, after a change has occurred.  The intent is to
allow chrome/browser-residing observers to monitor security level
changes, independent of style.

BUG= 641508 

Review-Url: https://codereview.chromium.org/2562503002
Cr-Commit-Position: refs/heads/master@{#437659}

[modify] https://crrev.com/6d1d727a5e0aad78d6151820c8b3ae4d6616cf56/chrome/browser/android/vr_shell/vr_web_contents_observer.cc
[modify] https://crrev.com/6d1d727a5e0aad78d6151820c8b3ae4d6616cf56/chrome/browser/android/vr_shell/vr_web_contents_observer.h
[modify] https://crrev.com/6d1d727a5e0aad78d6151820c8b3ae4d6616cf56/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/6d1d727a5e0aad78d6151820c8b3ae4d6616cf56/chrome/browser/ssl/security_state_tab_helper_browser_tests.cc
[modify] https://crrev.com/6d1d727a5e0aad78d6151820c8b3ae4d6616cf56/content/browser/devtools/protocol/security_handler.cc
[modify] https://crrev.com/6d1d727a5e0aad78d6151820c8b3ae4d6616cf56/content/browser/devtools/protocol/security_handler.h
[modify] https://crrev.com/6d1d727a5e0aad78d6151820c8b3ae4d6616cf56/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/6d1d727a5e0aad78d6151820c8b3ae4d6616cf56/content/public/browser/web_contents_observer.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ba56be0eb8af3ea64331207859110036c77464cf

commit ba56be0eb8af3ea64331207859110036c77464cf
Author: cjgrant <cjgrant@chromium.org>
Date: Tue Dec 20 23:35:56 2016

Fix omnibox security icons.

- Previously, a long URL would compress the space available to the
security icon, shrinking the image.
- Add the dangerous icon.

A future change will rework these icons to be properly colored
(hopefully via SVG properties).

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2557743006
Cr-Commit-Position: refs/heads/master@{#439926}

[modify] https://crrev.com/ba56be0eb8af3ea64331207859110036c77464cf/chrome/browser/resources/vr_shell/vr_shell_ui.css
[modify] https://crrev.com/ba56be0eb8af3ea64331207859110036c77464cf/chrome/browser/resources/vr_shell/vr_shell_ui.html
[modify] https://crrev.com/ba56be0eb8af3ea64331207859110036c77464cf/chrome/browser/resources/vr_shell/vr_shell_ui.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e16ba97bc9e52eb3b58d26ca6d0bb216e7150812

commit e16ba97bc9e52eb3b58d26ca6d0bb216e7150812
Author: cjgrant <cjgrant@chromium.org>
Date: Tue Jan 03 18:10:23 2017

Color the VR omnibox security icons.

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2550243002
Cr-Commit-Position: refs/heads/master@{#441154}

[modify] https://crrev.com/e16ba97bc9e52eb3b58d26ca6d0bb216e7150812/chrome/browser/resources/vr_shell/vr_shell_ui.css
[modify] https://crrev.com/e16ba97bc9e52eb3b58d26ca6d0bb216e7150812/chrome/browser/resources/vr_shell/vr_shell_ui.html

This is required for Fishfood.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a3be238572ce97fd3de4cdc93b9f2df16ff32ba

commit 7a3be238572ce97fd3de4cdc93b9f2df16ff32ba
Author: cjgrant <cjgrant@chromium.org>
Date: Tue Jan 10 18:13:29 2017

Support showing loading progress in the VR omnibox.

- This change renders a partial blue border around the omnibox, according
  to page load state. When loading completes, the blue disappears.
- Remove CSS-based movement of the box; this will move to native
  animation.
- This change depends on a change to WebContentsObserver to pull the
  load status.

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2615003004
Cr-Commit-Position: refs/heads/master@{#442631}

[modify] https://crrev.com/7a3be238572ce97fd3de4cdc93b9f2df16ff32ba/chrome/browser/resources/vr_shell/vr_shell_ui.css
[modify] https://crrev.com/7a3be238572ce97fd3de4cdc93b9f2df16ff32ba/chrome/browser/resources/vr_shell/vr_shell_ui.html
[modify] https://crrev.com/7a3be238572ce97fd3de4cdc93b9f2df16ff32ba/chrome/browser/resources/vr_shell/vr_shell_ui.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48a22a1c2870a87e9e6ee10af358717480f72589

commit 48a22a1c2870a87e9e6ee10af358717480f72589
Author: cjgrant <cjgrant@chromium.org>
Date: Wed Jan 11 16:43:39 2017

Move the omnibox natively when showing or hiding.

The omnibox drops slightly when fading.  Previously, the omnibox was moved by
adjusting its CSS margins. This is an inefficient way to handle movement (it
wastes space and doesn't always appear smooth).

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2622593003
Cr-Commit-Position: refs/heads/master@{#442923}

[modify] https://crrev.com/48a22a1c2870a87e9e6ee10af358717480f72589/chrome/browser/resources/vr_shell/vr_shell_ui.css
[modify] https://crrev.com/48a22a1c2870a87e9e6ee10af358717480f72589/chrome/browser/resources/vr_shell/vr_shell_ui.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f298498d0bc01765cec4bbd323e2d55f7609b35

commit 5f298498d0bc01765cec4bbd323e2d55f7609b35
Author: cjgrant <cjgrant@chromium.org>
Date: Thu Jan 12 22:39:34 2017

Tie VR omnibox to page load progress through TabObserver.

This change enables the page loading indicator in the HTML UI by
plumbing status through the Android WebContentsDelegate. If future work
exposes this information via WebContentsObserver, most of this plumbing
can be removed.

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2620383007
Cr-Commit-Position: refs/heads/master@{#443389}

[modify] https://crrev.com/5f298498d0bc01765cec4bbd323e2d55f7609b35/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/5f298498d0bc01765cec4bbd323e2d55f7609b35/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/5f298498d0bc01765cec4bbd323e2d55f7609b35/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/5f298498d0bc01765cec4bbd323e2d55f7609b35/chrome/browser/android/vr_shell/ui_interface.cc
[modify] https://crrev.com/5f298498d0bc01765cec4bbd323e2d55f7609b35/chrome/browser/android/vr_shell/ui_interface.h
[modify] https://crrev.com/5f298498d0bc01765cec4bbd323e2d55f7609b35/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/5f298498d0bc01765cec4bbd323e2d55f7609b35/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/5f298498d0bc01765cec4bbd323e2d55f7609b35/chrome/browser/resources/vr_shell/vr_shell_ui.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/094aaa164f434475b0d16f03677a0fe965497ba2

commit 094aaa164f434475b0d16f03677a0fe965497ba2
Author: cjgrant <cjgrant@chromium.org>
Date: Fri Jan 20 18:09:29 2017

Rename the VR pop-up URL indicator, making way for a real omnibox

What started out as the omnibox is not going to be the omnibox.

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2642783009
Cr-Commit-Position: refs/heads/master@{#445089}

[modify] https://crrev.com/094aaa164f434475b0d16f03677a0fe965497ba2/chrome/browser/resources/vr_shell/vr_shell_ui.css
[modify] https://crrev.com/094aaa164f434475b0d16f03677a0fe965497ba2/chrome/browser/resources/vr_shell/vr_shell_ui.html
[modify] https://crrev.com/094aaa164f434475b0d16f03677a0fe965497ba2/chrome/browser/resources/vr_shell/vr_shell_ui.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0ef9a78b5c8879e904ea51c02fbb3e7a36af600

commit f0ef9a78b5c8879e904ea51c02fbb3e7a36af600
Author: cjgrant <cjgrant@chromium.org>
Date: Mon Jan 30 22:09:00 2017

Add initial VR interactive omnibox.

- It depends on the HTML-based virtual keyboard.
- It can accept URL text entry and trigger navigation.
- It offers suggestions based on text entered.
- It allows navigation from suggestions.
- It is NOT styled well.
- It is NOT yet enabled in any mode.
- It is NOT yet complete in any way.

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2647053002
Cr-Commit-Position: refs/heads/master@{#447086}

[modify] https://crrev.com/f0ef9a78b5c8879e904ea51c02fbb3e7a36af600/chrome/browser/android/vr_shell/BUILD.gn
[modify] https://crrev.com/f0ef9a78b5c8879e904ea51c02fbb3e7a36af600/chrome/browser/android/vr_shell/ui_interface.cc
[modify] https://crrev.com/f0ef9a78b5c8879e904ea51c02fbb3e7a36af600/chrome/browser/android/vr_shell/ui_interface.h
[add] https://crrev.com/f0ef9a78b5c8879e904ea51c02fbb3e7a36af600/chrome/browser/android/vr_shell/vr_omnibox.cc
[add] https://crrev.com/f0ef9a78b5c8879e904ea51c02fbb3e7a36af600/chrome/browser/android/vr_shell/vr_omnibox.h
[modify] https://crrev.com/f0ef9a78b5c8879e904ea51c02fbb3e7a36af600/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/f0ef9a78b5c8879e904ea51c02fbb3e7a36af600/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/f0ef9a78b5c8879e904ea51c02fbb3e7a36af600/chrome/browser/resources/vr_shell/vr_shell_ui.css
[modify] https://crrev.com/f0ef9a78b5c8879e904ea51c02fbb3e7a36af600/chrome/browser/resources/vr_shell/vr_shell_ui.html
[modify] https://crrev.com/f0ef9a78b5c8879e904ea51c02fbb3e7a36af600/chrome/browser/resources/vr_shell/vr_shell_ui.js
[modify] https://crrev.com/f0ef9a78b5c8879e904ea51c02fbb3e7a36af600/chrome/browser/resources/vr_shell/vr_shell_ui_api.js
[modify] https://crrev.com/f0ef9a78b5c8879e904ea51c02fbb3e7a36af600/chrome/browser/ui/webui/vr_shell/vr_shell_ui_message_handler.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db713b182a14c3aacabed95d3b28f8885b1a633f

commit db713b182a14c3aacabed95d3b28f8885b1a633f
Author: cjgrant <cjgrant@chromium.org>
Date: Mon Feb 06 17:44:10 2017

Improve VR omnibox styling and function

- Improve the spacing and alignment of suggestions.
- Clear suggestions when doing a navigation action.
- Tweak the "Reload UI" debugging button to be more usable.

BUG= 641508 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2670833005
Cr-Commit-Position: refs/heads/master@{#448291}

[modify] https://crrev.com/db713b182a14c3aacabed95d3b28f8885b1a633f/chrome/browser/resources/vr_shell/vr_shell_ui.css
[modify] https://crrev.com/db713b182a14c3aacabed95d3b28f8885b1a633f/chrome/browser/resources/vr_shell/vr_shell_ui.html
[modify] https://crrev.com/db713b182a14c3aacabed95d3b28f8885b1a633f/chrome/browser/resources/vr_shell/vr_shell_ui.js

Status: This bug is now only waiting on the VKB, at which point we can say we have the ability to do basic URL entry w/ suggestions.

We're waiting to hear back on results from Feb 1 user testing session, but tentatively the plan is:

* Loading indicator appears during site transitions. It displays same information as Chrome for Android omnibox would during transition, but is inert. It cannot be clicked, interacted with, etc.

* Interactive omnibox is available inside menu mode. It is visually distinct from the loading indicator. 

We may want to split these into distinct bugs. We should hold off until we get that feedback from user testing, though.

On splitting bugs:

- The URL indicator already works, and is no longer referred to as an Omnibox.
- The very basic Omnibox has landed, and appears in the new menu mode screen.

I've made bugs to track:

- Enabling and verifying all the basic elements in WebVR (as opposed to VR shell):  crbug.com/687960 
- Omnibox refinement and styling:  crbug.com/683344 
- Toolbar on WebVR site-to-site:  crbug.com/645135

Once the VK lands, I'd like to close off this bug.  In addition to the issues above, we should file new, much more specific issues to track omnibox improvements.

I've opened a separate bug to track wiring the omnibox to the keyboard, when it lands.  This bug has ceased to be useful, so I'm shutting it down...