New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 641501 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Jan 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Manual memory dump mode through UI

Project Member Reported by mariakho...@chromium.org, Aug 26 2016

Issue description

It would be nice if the tracing UI had an additional manual memory dump mode. I imagine it being a button on the tracing screen, along the lines of "dump now".

Use case:
 - I am trying to reproduce a memory leak by hand with a set of steps

It would be very helpful if I could control exactly when detailed memory dumps occur.

Why I had trouble with the existing tools:
 - Trace is getting too large during the reproduction, so I lose early data
 - I would like specifically to compare allocation between two points of stuff I did, but it's hard to tell from the trace when I did what. (I suppose I can find it if I look at traces enough, but that could be easier).

Seems like it would be pretty simple to do..
 

Comment 1 by dskiba@chromium.org, Aug 26 2016

Hmm, I was thinking of implementing chrome://dump_providers or something, that would just query all dump providers and render results as simple text. To get new values you simply refresh.
I want full heap dumps (and a way to compare them). Since the current UI makes that pretty convenient, I think your solution wouldn't quite solve my problem.
Given that we already have the Tracing.requestMemoryDump DevTools method in Chrome (used by Telemetry), adding the button to the UI (and making it work) should be a very easy task.

The issue is that, if you start memory tracing from the UI, it currently performs periodic memory dumps, which I suppose is undesirable if you want manual memory dumps. In other words, I think that we first need to make it possible to disable periodic memory dumps from the chrome://tracing UI (https://github.com/catapult-project/catapult/issues/2013).
Just to be clear: I completely support the idea and I think we should add the button :-)
I agree that it would only work well with the periodic dumps disabled. In the bug you linked, dependency 1 is already marked as fixed and dependency 2 is nice to have. Any chance this would be easy to do? I am even happy to write the code if you point me in the right direction.

Comment 6 by ssid@chromium.org, Aug 30 2016

IIUC we have all support from Chrome and Devtools for being able to do this. The only missing part is the UI.
In case it is a long discussion / hard work to figure out how to add UI to set periodic dumps, how about we have an option for text box to specify MemoryDumpConfig? If we have this then the button for triggering dump can be added.
I agree with #6. Also, I've just realized that you can disable periodic memory dumps by passing the "--enable-memory-benchmarking" flag to Chrome: https://cs.chromium.org/chromium/src/base/trace_event/memory_dump_manager.cc?l=696
Cc: nedngu...@google.com
#5: The reason why we didn't do the hacky solution is that the recording selection dialog (in chrome://tracing) is in the process of being overhauled (https://github.com/catapult-project/catapult/issues/1943). I've just pinged the bug and Ned replied that he would resume working on the overhaul.
>  Also, I've just realized that you can disable periodic memory dumps by passing the "--enable-memory-benchmarking" flag to Chrome
That one is "temporary" and I'm looking forward to ditch it. IIRC the only blocker is waiting for the "ref" (Stable) build to roll to the point where that part of traceconfig is supported also in stable channel.

Comment 10 by ssid@chromium.org, Aug 31 2016

+1 to ditching the --enable-memory-benchmarking sooner.  Issue 513692 .
Cc: -petrcermak@chromium.org
Project Member

Comment 12 by sheriffbot@chromium.org, Oct 5 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Archived (was: Untriaged)
Archiving P3s older than 1 year with no owner or component.

Sign in to add a comment