New issue
Advanced search Search tips

Issue 641496 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

VoiceOver: bookmarks bar disclosure arrow issues

Project Member Reported by ellyjo...@chromium.org, Aug 26 2016

Issue description

1) The disclosure arrow when the bookmarks bar is too full is read as "button" instead of "More Bookmarks" or something similar.
2) Opening it yields "Press Button" and no indication that a menu is present
3) VO focus becomes "trapped" in the menu unless the user knows to press Esc to get out of it

Probably the "More Bookmarks" menu needs to inform VoiceOver that it's present somehow and the disclosure button needs to be labelled.
 
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a69355bda63ba06fe176616bba00d026ae368d0

commit 5a69355bda63ba06fe176616bba00d026ae368d0
Author: ellyjones <ellyjones@chromium.org>
Date: Tue Aug 30 04:21:36 2016

a11y: add a11y title for bookmark chevron / "off the side button"

Before: VO reads "button"
After: VO reads "Menu containing hidden bookmarks, button"

BUG= 641496 

Review-Url: https://codereview.chromium.org/2288763002
Cr-Commit-Position: refs/heads/master@{#415088}

[modify] https://crrev.com/5a69355bda63ba06fe176616bba00d026ae368d0/chrome/browser/ui/cocoa/bookmarks/bookmark_button_cell.mm

Status: Started (was: Assigned)
That CL fixed (1) in the OP.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fbddcd5c63c21cfa820aa9f36003f91e847d825

commit 3fbddcd5c63c21cfa820aa9f36003f91e847d825
Author: ellyjones <ellyjones@chromium.org>
Date: Fri Sep 09 13:43:30 2016

cocoa: give bookmarks menu an accessible title

Without this VoiceOver reads the window title, which is "BmbPopUpWindow".

BUG= 641496 

Review-Url: https://codereview.chromium.org/2320723006
Cr-Commit-Position: refs/heads/master@{#417573}

[modify] https://crrev.com/3fbddcd5c63c21cfa820aa9f36003f91e847d825/chrome/app/generated_resources.grd
[modify] https://crrev.com/3fbddcd5c63c21cfa820aa9f36003f91e847d825/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_window.mm

Status: Fixed (was: Started)
This is fully fixed now.

Sign in to add a comment