New issue
Advanced search Search tips

Issue 641485 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

accelerated_video_encode erroneously reported as enabled on Linux?

Reported by pdk...@gmail.com, Aug 26 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.70 Safari/537.36

Example URL:

Steps to reproduce the problem:
chrome://gpu

Video Decode: Software only, hardware acceleration unavailable
Video Encode: Hardware accelerated

...

Accelerated video decode is unavailable on Linux: 137247
Disabled Features: accelerated_video_decode

What is the expected behavior?

What went wrong?
It's unlikely that encoding is supported, when decoding isn't.

There is no mention of Linux in the source either.

https://cs.chromium.org/chromium/src/media/gpu/ipc/service/gpu_video_encode_accelerator.cc

I don't know how to verify.

Did this work before? N/A 

Is it a problem with Flash or HTML5? HTML5

Does this work in other browsers? N/A 

Chrome version: 53.0.2785.70  Channel: n/a
OS Version: Uuntu 14.04
Flash Version:
 
Owner: dalecur...@chromium.org
Status: Assigned (was: Unconfirmed)
I see the same thing on linux.
Dale, where is the Video Decode/ Video Encode info retrieved from? It may need be fixed. There is no point for video encoding being Hardware accelerated on Linux.
Can you assign appropriately?
Cc: emir...@chromium.org mcasas@chromium.org
Owner: ----
Status: Available (was: Assigned)
Not sure who owns this feature, but +some folk.
Owner: chfremer@chromium.org
chfremer@ can you PTAL? This might be related to your recent work about encoder/decoder flags.
It appears that the Graphics Feature Status section of chrome://gpu only models 
whether or not a feature is blacklisted or disabled and whether or not it has 
a software fallback. It does not have a notion of a feature being "not 
supported". 

Therefore, "Hardware accelerated" really means "not blacklisted, not disabled, 
but maybe unsupported". Also "unavailable" really means "blacklisted", so it 
does not say anything about whether or not something is supported.

Video decode on Linux is reported as unavailable, because it is blacklisted, 
see [1,2].

Video encode is reported as available, because it is neither blacklisted nor 
disabled via command-line flag kDisableWebRtcHWEncoding, see [3]. Note that
the thing being reported seems to only represent video encode acceleration for 
WebRtc. It probably does not represent other areas that do video encoding, such 
as Cast or MediaRecorder.

To make the report say that video encode is no accelerated, we could do what 
is done for video decode, which is to add a blacklist entry to [2]. I am going to post a CL for that shortly.

[1] https://cs.chromium.org/chromium/src/content/browser/gpu/compositor_util.cc?type=cs&l=112
[2] https://cs.chromium.org/chromium/src/gpu/config/software_rendering_list_json.cc?gsn=kSoftwareRenderingListJson&l=399
[3] https://cs.chromium.org/chromium/src/content/browser/gpu/compositor_util.cc?type=cs&l=119

Comment 5 by pdk...@gmail.com, Mar 9 2017

​Your comment reminded me of an earlier bug I had filed, whose discussion
may or may not be useful to you.

https://bugs.chromium.org/p/chromium/issues/detail?id=600499​
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31ec638091fc05bd13c41f8cd19cae7479cd5a1c

commit 31ec638091fc05bd13c41f8cd19cae7479cd5a1c
Author: chfremer <chfremer@chromium.org>
Date: Fri Mar 10 20:47:41 2017

Add Gpu blacklist entry for video encoding on Linux.

On Linux, Video encoding is currently erroneously reported on chrome://gpu as "Hardware
accelerated". This CL fixes this by adding a blacklist entry.

BUG= 641485 
TEST=Open chrome://gpu on Linux and check that Video Encode is reported as
     Software only, hardware acceleration unavailable
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2744683002
Cr-Commit-Position: refs/heads/master@{#456153}

[modify] https://crrev.com/31ec638091fc05bd13c41f8cd19cae7479cd5a1c/gpu/config/software_rendering_list_json.cc

Status: Fixed (was: Available)

Sign in to add a comment