New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 641468 link

Starred by 1 user
Status: Fixed
Owner:
alph@chromium.org
Closed: Aug 2016
Cc:
█ lushnikov@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

TargetManager fails to iterate over model listeners.

Project Member Reported by alph@chromium.org, Aug 26 2016 
TargetManager fails to iterate over model listeners.

The symptoms include the console does work.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/895cd721262c4fcf86ea35e5a3fdb92bb8b85fdd

commit 895cd721262c4fcf86ea35e5a3fdb92bb8b85fdd
Author: alph <alph@chromium.org>
Date: Fri Aug 26 21:38:40 2016

DevTools: Use a Map for modelListeners in TargetManager

The Object used to store the listeners before does not support iteration
over Symbol keys.

BUG= 641468 

Review-Url: https://codereview.chromium.org/2284663003
Cr-Commit-Position: refs/heads/master@{#414816}

[modify] https://crrev.com/895cd721262c4fcf86ea35e5a3fdb92bb8b85fdd/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Comment 2 by alph@chromium.org, Aug 26 2016

Labels: Merge-Request-54

Comment 3 by dimu@chromium.org, Aug 27 2016

Labels: -Merge-Request-54 Merge-Approved-54 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M54 (branch: 2840)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 28 2016

Labels: -merge-approved-54 merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b78c8f740d3059bc3d837ef23196af8fa5a2ac58

commit b78c8f740d3059bc3d837ef23196af8fa5a2ac58
Author: Alexei Filippov <alph@chromium.org>
Date: Sun Aug 28 22:00:42 2016

DevTools: Use a Map for modelListeners in TargetManager

The Object used to store the listeners before does not support iteration
over Symbol keys.

BUG= 641468 

Review-Url: https://codereview.chromium.org/2284663003
Cr-Commit-Position: refs/heads/master@{#414816}
(cherry picked from commit 895cd721262c4fcf86ea35e5a3fdb92bb8b85fdd)

Review URL: https://codereview.chromium.org/2288593002 .

Cr-Commit-Position: refs/branch-heads/2840@{#9}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/b78c8f740d3059bc3d837ef23196af8fa5a2ac58/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Comment 5 by alph@chromium.org, Aug 28 2016

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b78c8f740d3059bc3d837ef23196af8fa5a2ac58

commit b78c8f740d3059bc3d837ef23196af8fa5a2ac58
Author: Alexei Filippov <alph@chromium.org>
Date: Sun Aug 28 22:00:42 2016

DevTools: Use a Map for modelListeners in TargetManager

The Object used to store the listeners before does not support iteration
over Symbol keys.

BUG= 641468 

Review-Url: https://codereview.chromium.org/2284663003
Cr-Commit-Position: refs/heads/master@{#414816}
(cherry picked from commit 895cd721262c4fcf86ea35e5a3fdb92bb8b85fdd)

Review URL: https://codereview.chromium.org/2288593002 .

Cr-Commit-Position: refs/branch-heads/2840@{#9}
Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607}

[modify] https://crrev.com/b78c8f740d3059bc3d837ef23196af8fa5a2ac58/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
►

Sign in to add a comment