New issue
Advanced search Search tips

Issue 641453 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

Change Separator opacity

Project Member Reported by yiyix@chromium.org, Aug 26 2016

Issue description

The separator looks too dim in the current MD implementation. Update the alpha value to 0.3 from 0.24.

 
Screenshot from 2016-08-26 15:09:40.png
4.3 KB View Download
Components: UI>Shell>Shelf
Labels: -Type-Bug -Pri-3 M-55 OS-Chrome Pri-2 Type-Feature

Comment 2 by yiyix@chromium.org, Aug 26 2016

After the change, the separator looks like this:
Screenshot from 2016-08-26 15:25:28.png
4.3 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fde074ca9cad340a826f85834e5b942fcd555a8d

commit fde074ca9cad340a826f85834e5b942fcd555a8d
Author: yiyix <yiyix@chromium.org>
Date: Fri Aug 26 20:29:25 2016

Update Tray Separator Opacity

The tray separator has an opacity of 0.24 and it looks too dim when the
shelf is completely opaque. Update the tray separator's opacity to 0.3.

BUG= 641453 

Review-Url: https://codereview.chromium.org/2281173002
Cr-Commit-Position: refs/heads/master@{#414798}

[modify] https://crrev.com/fde074ca9cad340a826f85834e5b942fcd555a8d/ash/common/system/tray/tray_constants.cc

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)

Comment 6 by yiyix@chromium.org, Oct 31 2016

Status: Started (was: Verified)
The separator still looks too dim. Update the alpha value to 0.6.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07bf97af7414cc14268f99055f5f9671e1b9fea2

commit 07bf97af7414cc14268f99055f5f9671e1b9fea2
Author: yiyix <yiyix@chromium.org>
Date: Tue Nov 01 00:10:57 2016

Update Tray Separator Opacity

The tray separator has an opacity of 0.3 and it looks too dim when the
shelf is completely opaque. Update the tray separator's opacity to 0.6.

BUG= 641453 

Review-Url: https://codereview.chromium.org/2470543002
Cr-Commit-Position: refs/heads/master@{#428876}

[modify] https://crrev.com/07bf97af7414cc14268f99055f5f9671e1b9fea2/ash/common/system/tray/tray_constants.cc

Yi, can this be marked as Fixed (did you show Sebastien a screenshot of the separator with the new opacity)?
Labels: Pri-1
Status: Fixed (was: Started)
I have showed the screenshot to Sebastien. We both like the final appearance. 
Status: Verified (was: Fixed)

Sign in to add a comment